You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-12-05] [Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account. #13008
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Hmm, I can reproduce this in web chrome too, but seems like I have to first resize the screen to make it "mobile size". I'm able to click one contact then it freezes.
I think this is about rendering the full list when that list is very big. I can see that even the first render a long time and I see it slowly adding the rows to the DOM:
changed the title [-]Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/-][+][Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/+]on Nov 24, 2022
I have tested it by reverting the PR and it's working correctly. The issue is not only related to split bill it's present at other pages. I have a branch ready with the changes to revert since I was confirming the PR. I can spin up a quick PR let me know.
changed the title [-][Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/-][+][HOLD for payment 2022-12-05] [Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/+]on Nov 28, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
OSBotify commentedon Nov 24, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 24, 2022
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.aldo-expensify commentedon Nov 24, 2022
Reproduced in staging with my expensifail account
aldo-expensify commentedon Nov 24, 2022
Hmm, I can reproduce this in web chrome too, but seems like I have to first resize the screen to make it "mobile size". I'm able to click one contact then it freezes.
aldo-expensify commentedon Nov 24, 2022
Reproduced this slowness in production
Screen.Recording.2022-11-24.at.10.18.18.AM.mov
@kbecciv can you check if this happens in production? I'm pretty sure it does...
aldo-expensify commentedon Nov 24, 2022
I think this is about rendering the full list when that list is very big. I can see that even the first render a long time and I see it slowly adding the rows to the DOM:
Screen.Recording.2022-11-24.at.10.34.32.AM.mov
aldo-expensify commentedon Nov 24, 2022
The list doesn't render all elements when the screen size is big (desktop), it only happens in a small screen.
1 remaining item
aldo-expensify commentedon Nov 24, 2022
Removing
DeployBlockerCashas this is happening in production too.[-]Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/-][+][Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/+]Puneet-here commentedon Nov 24, 2022
This is a regression from #12366
Same as #13011
I have tested it by reverting the PR and it's working correctly. The issue is not only related to split bill it's present at other pages. I have a branch ready with the changes to revert since I was confirming the PR. I can spin up a quick PR let me know.
aldo-expensify commentedon Nov 24, 2022
Yep, I reverted some parts of that PR and it gets fixed.
Thanks for finding that!
aldo-expensify commentedon Nov 24, 2022
I'm not sure if there is something to save from that PR, but I only had to revert this part to make it work:
luacmartins commentedon Nov 25, 2022
Revert was deployed. Closing issue.
[-][Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/-][+][HOLD for payment 2022-12-05] [Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/+]melvin-bot commentedon Nov 28, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-05. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue: