Skip to content

[HOLD for payment 2022-12-05] [Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account. #13008

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open staging.new.expensify.com
  2. Sign into a HT account
  3. Tap on + > Split Bill > Proceed until you have to select the participants
  4. Try and tap on the selected participants

Expected Result:

User expects to be able to select the participants and for them to appear with the check mark immediately

Actual Result:

The user taps and nothing happens, the wait time is very long and sometimes the page even reloads itself because of the unresponsiveness

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web/Safari ONLY

Version Number: 1.2.31.5

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5835138_Nothing_happens_when_tapping_on_names_in_split_bill_with_HT_account.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Nov 24, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Nov 24, 2022

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    Reproduced in staging with my expensifail account

  4. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    Hmm, I can reproduce this in web chrome too, but seems like I have to first resize the screen to make it "mobile size". I'm able to click one contact then it freezes.

  5. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    Reproduced this slowness in production

    Screen.Recording.2022-11-24.at.10.18.18.AM.mov

    @kbecciv can you check if this happens in production? I'm pretty sure it does...

  6. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    I think this is about rendering the full list when that list is very big. I can see that even the first render a long time and I see it slowly adding the rows to the DOM:

    Screen.Recording.2022-11-24.at.10.34.32.AM.mov
  7. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    The list doesn't render all elements when the screen size is big (desktop), it only happens in a small screen.

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 24, 2022
  9. 1 remaining item

  10. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    Removing DeployBlockerCash as this is happening in production too.

  11. changed the title [-]Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/-] [+][Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/+] on Nov 24, 2022
  12. Puneet-here commented on Nov 24, 2022

    @Puneet-here
    Contributor

    This is a regression from #12366
    Same as #13011

    I have tested it by reverting the PR and it's working correctly. The issue is not only related to split bill it's present at other pages. I have a branch ready with the changes to revert since I was confirming the PR. I can spin up a quick PR let me know.

  13. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    Yep, I reverted some parts of that PR and it gets fixed.

    Thanks for finding that!

  14. aldo-expensify commented on Nov 24, 2022

    @aldo-expensify
    Contributor

    I'm not sure if there is something to save from that PR, but I only had to revert this part to make it work:

    Screen Shot 2022-11-24 at 11 26 42 AM

  15. self-assigned this
    on Nov 24, 2022
  16. luacmartins commented on Nov 25, 2022

    @luacmartins
    Contributor

    Revert was deployed. Closing issue.

  17. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 28, 2022
  18. changed the title [-][Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/-] [+][HOLD for payment 2022-12-05] [Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account.[/+] on Nov 28, 2022
  19. melvin-bot commented on Nov 28, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-05. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions