Skip to content

[$2000] Empty state icons for reimbursementAccountLoadingAnimation don't have a transparent background in Dark Theme. #13151

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any workspace and attempt the Connect Bank Account step
  2. Enter the bank account details, go to the company step
  3. Fill in the company step, and wait for the reimbursement account loading animation (screen with the title One moment)
  4. Check that the icons don't have a transparent background (instead have a gray background).

Expected Result:

The Icons should have a transparent background

Actual Result:

the icons have a gray background.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.2.33-2
Reproducible in staging?: y
Reproducible in production?: Could not verify in production
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1669717357.MP4
JFZT3783.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @mananjadhav
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669717660117089

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d555366565521d92
  • Upwork Job ID: 1597976370465353728
  • Last Price Increase: 2022-12-20

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 29, 2022
  2. melvin-bot commented on Nov 29, 2022

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. mananjadhav commented on Nov 29, 2022

    @mananjadhav
    Collaborator

    Tagging @Expensify/design and @shawnborton too

  4. abekkala commented on Nov 29, 2022

    @abekkala
    Contributor

    @shawnborton is this going to be fixed internally?
    If so, then I can just create an Upwork posting to hire/pay the contributor who reported the issue.

  5. shawnborton commented on Nov 29, 2022

    @shawnborton
    Contributor

    The new .gif can be created internally, but we can use a contributor to update the .gif (it's just a file path that points to cloudfront) in the app.

  6. self-assigned this
    on Nov 29, 2022
  7. Puneet-here commented on Nov 30, 2022

    @Puneet-here
    Contributor

    @shawnborton, I can make the change (it needs to be done here). We also need to update other gif that we are using locally (check the one below)

    https://github.com/Expensify/App/blob/main/assets/images/confetti-pop.gif

  8. shawnborton commented on Nov 30, 2022

    @shawnborton
    Contributor

    Where are we using confetti pop? I thought we stopped using it with the new workspace illustrations that we merged?

  9. Puneet-here commented on Nov 30, 2022

    @Puneet-here
    Contributor

    It's at password confirmation screen and request call confirmation
    Once you change your password successfully you will see it or after requesting a call.

    <Image
    source={confettiPop}

    <Image
    source={confettiPop}

  10. shawnborton commented on Nov 30, 2022

    @shawnborton
    Contributor

    Can you share screenshots of those two pages?

  11. Puneet-here commented on Nov 30, 2022

    @Puneet-here
    Contributor

    Screenshot 2022-11-30 at 5 54 58 AM

    Screenshot 2022-11-30 at 5 55 41 AM

  12. Puneet-here commented on Nov 30, 2022

    @Puneet-here
    Contributor

    We can use Illustrations.TadaBlue instead

                <Icon
                    src={Illustrations.TadaBlue}
                    height={100}
                    width={100}
                    fill={defaultTheme.iconSuccessFill}
                />

    Screenshot 2022-11-30 at 5 58 17 AM

    and maybe some margin below the icon.

  13. shawnborton commented on Nov 30, 2022

    @shawnborton
    Contributor

    I think we can use the new simple thumbs up illustration for those:

    image

  14. 85 remaining items

  15. changed the title [-][hold for payment 2023-01-05] [$2000] Empty state icons for `reimbursementAccountLoadingAnimation` don't have a transparent background in Dark Theme.[/-] [+][$2000] Empty state icons for `reimbursementAccountLoadingAnimation` don't have a transparent background in Dark Theme.[/+] on Jan 5, 2023
  16. joekaufmanexpensify commented on Jan 5, 2023

    @joekaufmanexpensify
    Contributor

    Okay 7 day regression period has passed, and we're all set to issue payment here. Given the PR was merged within 3 business days from when the contributor was assigned to the issue, both the contributor and C+ qualify for a 50% bonus here. We need to pay the following amounts:

    • @mananjadhav - $250 for reporting bug.
    • @Puneet-here - $3,000 for PR fixing the bug (includes 50% bonus of $1,000).
    • @sobitneupane - $3,000 for C+ review (includes 50% bonus of $1,000).
  17. joekaufmanexpensify commented on Jan 5, 2023

    @joekaufmanexpensify
    Contributor

    @mananjadhav $250 sent, and contract ended!

  18. joekaufmanexpensify commented on Jan 5, 2023

    @joekaufmanexpensify
    Contributor

    @Puneet-here $3,000 sent, and contract ended!

  19. joekaufmanexpensify commented on Jan 5, 2023

    @joekaufmanexpensify
    Contributor

    @sobitneupane $3,000 sent, and contract ended!

  20. joekaufmanexpensify commented on Jan 5, 2023

    @joekaufmanexpensify
    Contributor

    Job closed in upwork.

  21. joekaufmanexpensify commented on Jan 5, 2023

    @joekaufmanexpensify
    Contributor

    Proposed new regression test here!

  22. mountiny commented on Jan 6, 2023

    @mountiny
    Contributor

    To complete the checklist, I have commented on this Pr where we have made the switch to the dark mode #12944 (comment) and we should have probably update the icons there or at least have a follow up ready.

    Posted a discussion in Slack https://expensify.slack.com/archives/C049HHMV9SM/p1672994272661819

    I think the regression tests Joe posted should be enough for this going forwards.

  23. joekaufmanexpensify commented on Jan 6, 2023

    @joekaufmanexpensify
    Contributor

    Added new regression test issue above!

  24. joekaufmanexpensify commented on Jan 6, 2023

    @joekaufmanexpensify
    Contributor

    Okay, bug is fixed, payment is handled, and BZ checklist is complete. This is all set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions