You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$2000] Empty state icons for reimbursementAccountLoadingAnimation don't have a transparent background in Dark Theme. #13151
Go to any workspace and attempt the Connect Bank Account step
Enter the bank account details, go to the company step
Fill in the company step, and wait for the reimbursement account loading animation (screen with the title One moment)
Check that the icons don't have a transparent background (instead have a gray background).
Expected Result:
The Icons should have a transparent background
Actual Result:
the icons have a gray background.
Workaround:
unknown
Platform:
Where is this issue occurring?
Mobile Web
Version Number: 1.2.33-2 Reproducible in staging?: y Reproducible in production?: Could not verify in production Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
It's at password confirmation screen and request call confirmation
Once you change your password successfully you will see it or after requesting a call.
changed the title [-][hold for payment 2023-01-05] [$2000] Empty state icons for `reimbursementAccountLoadingAnimation` don't have a transparent background in Dark Theme.[/-][+][$2000] Empty state icons for `reimbursementAccountLoadingAnimation` don't have a transparent background in Dark Theme.[/+]on Jan 5, 2023
Okay 7 day regression period has passed, and we're all set to issue payment here. Given the PR was merged within 3 business days from when the contributor was assigned to the issue, both the contributor and C+ qualify for a 50% bonus here. We need to pay the following amounts:
To complete the checklist, I have commented on this Pr where we have made the switch to the dark mode #12944 (comment) and we should have probably update the icons there or at least have a follow up ready.
Activity
melvin-bot commentedon Nov 29, 2022
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.mananjadhav commentedon Nov 29, 2022
Tagging @Expensify/design and @shawnborton too
abekkala commentedon Nov 29, 2022
@shawnborton is this going to be fixed internally?
If so, then I can just create an Upwork posting to hire/pay the contributor who reported the issue.
shawnborton commentedon Nov 29, 2022
The new .gif can be created internally, but we can use a contributor to update the .gif (it's just a file path that points to cloudfront) in the app.
Puneet-here commentedon Nov 30, 2022
@shawnborton, I can make the change (it needs to be done here). We also need to update other gif that we are using locally (check the one below)
https://github.com/Expensify/App/blob/main/assets/images/confetti-pop.gif
shawnborton commentedon Nov 30, 2022
Where are we using confetti pop? I thought we stopped using it with the new workspace illustrations that we merged?
Puneet-here commentedon Nov 30, 2022
It's at password confirmation screen and request call confirmation
Once you change your password successfully you will see it or after requesting a call.
App/src/pages/RequestCallConfirmationScreen.js
Lines 18 to 19 in 3c22789
App/src/pages/settings/PasswordConfirmationScreen.js
Lines 18 to 19 in 11072a6
shawnborton commentedon Nov 30, 2022
Can you share screenshots of those two pages?
Puneet-here commentedon Nov 30, 2022
Puneet-here commentedon Nov 30, 2022
We can use
Illustrations.TadaBlueinsteadand maybe some margin below the icon.
shawnborton commentedon Nov 30, 2022
I think we can use the new simple thumbs up illustration for those:
85 remaining items
[-][hold for payment 2023-01-05] [$2000] Empty state icons for `reimbursementAccountLoadingAnimation` don't have a transparent background in Dark Theme.[/-][+][$2000] Empty state icons for `reimbursementAccountLoadingAnimation` don't have a transparent background in Dark Theme.[/+]joekaufmanexpensify commentedon Jan 5, 2023
Okay 7 day regression period has passed, and we're all set to issue payment here. Given the PR was merged within 3 business days from when the contributor was assigned to the issue, both the contributor and C+ qualify for a 50% bonus here. We need to pay the following amounts:
joekaufmanexpensify commentedon Jan 5, 2023
@mananjadhav $250 sent, and contract ended!
joekaufmanexpensify commentedon Jan 5, 2023
@Puneet-here $3,000 sent, and contract ended!
joekaufmanexpensify commentedon Jan 5, 2023
@sobitneupane $3,000 sent, and contract ended!
joekaufmanexpensify commentedon Jan 5, 2023
Job closed in upwork.
joekaufmanexpensify commentedon Jan 5, 2023
Proposed new regression test here!
mountiny commentedon Jan 6, 2023
To complete the checklist, I have commented on this Pr where we have made the switch to the dark mode #12944 (comment) and we should have probably update the icons there or at least have a follow up ready.
Posted a discussion in Slack https://expensify.slack.com/archives/C049HHMV9SM/p1672994272661819
I think the regression tests Joe posted should be enough for this going forwards.
joekaufmanexpensify commentedon Jan 6, 2023
Added new regression test issue above!
joekaufmanexpensify commentedon Jan 6, 2023
Okay, bug is fixed, payment is handled, and BZ checklist is complete. This is all set. Thanks everyone!