Skip to content

[HOLD for payment 2022-12-20] [$1000] (Dark Theme) Tab highlight color is not correct. #13256

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app on web.
  2. Click on the search icon on LHN.
  3. Use Escape key to close the page.
  4. Press Tab multiple times until first item on the LHN is highlighted.

Expected Result:

The Highlight outline should be #5AB0FF, and ensure we use this regardless of dark or light mode.

Actual Result:

The highlight outline is blue which is part of light theme and should match the dark theme

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.2.35-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
image

Recording.1038.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669646862849829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 2, 2022
  2. melvin-bot commented on Dec 2, 2022

    @melvin-bot

    Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. dhairyasenjaliya commented on Dec 2, 2022

    @dhairyasenjaliya
    Contributor

    Proposal

    • We need to change the color on the below file to focus-visible & focus[data-focusvisible-polyfill] property box-shadow to greenHover: '#00C271',

    • This greenHover color looks neat & clean and but might we need to confirm the color with the design team

    App/web/index.html

    Lines 35 to 42 in a8e3cb5

    :focus-visible {
    outline: 0;
    box-shadow: inset 0px 0px 0px 1px #0185ff;
    }
    :focus[data-focusvisible-polyfill] {
    outline: 0;
    box-shadow: inset 0px 0px 0px 1px #0185ff;
    }

            :focus-visible {
                outline: 0;
    -            box-shadow: inset 0px 0px 0px 1px #0185ff;
    +            box-shadow: inset 0px 0px 0px 1px #00C271;
            }
            :focus[data-focusvisible-polyfill] {
                outline: 0;
    -            box-shadow: inset 0px 0px 0px 1px #0185ff;
    +            box-shadow: inset 0px 0px 0px 1px #00C271;
            }
    

    Result
    Screenshot 2022-12-02 at 11 49 29 AM

  4. sketchydroide commented on Dec 2, 2022

    @sketchydroide
    Contributor

    picking this up myself

  5. self-assigned this
    on Dec 2, 2022
  6. parasharrajat commented on Dec 2, 2022

    @parasharrajat
    Member

    I would suggest discussing this first with Design team to decide if this is really needed. I had doubt on this as I posted on slack.

    Note: Please discuss this issue if we really need to change the outline color.

  7. sketchydroide commented on Dec 2, 2022

    @sketchydroide
    Contributor

    @Expensify/design any input here?

  8. michaelhaxhiu commented on Dec 2, 2022

    @michaelhaxhiu
    Contributor

    Hm I'm not convinced this is a bug as it stands.

    The Expected Result section needs to be more specific too, as right now it's open ended:

    Expected Result:

    The Highlight outline should match the dark theme.

    What would matching the dark theme actually mean?

  9. parasharrajat commented on Dec 2, 2022

    @parasharrajat
    Member

    What would matching the dark theme actually mean?

    This is where the design team kicks in.

  10. michaelhaxhiu commented on Dec 2, 2022

    @michaelhaxhiu
    Contributor

    Understood. I'm not going to export this job to Upwork until we define/agree on the Expected Result.

    https://expensify.slack.com/archives/C049HHMV9SM/p1669986622516479?thread_ts=1669646862.849829&cid=C049HHMV9SM

  11. shawnborton commented on Dec 2, 2022

    @shawnborton
    Contributor

    Cool, commenting over in Slack.

  12. sketchydroide commented on Dec 5, 2022

    @sketchydroide
    Contributor

    seem like @shawnborton has decided on a blue color, the one from the links on the app, which I think it's still different from this one. So this GH still makes some sense

  13. 29 remaining items

  14. aimane-chnaif commented on Dec 13, 2022

    @aimane-chnaif
    Contributor

    @michaelhaxhiu Also, C+ payment for PR review

  15. parasharrajat commented on Dec 13, 2022

    @parasharrajat
    Member

    Accepted.

  16. michaelhaxhiu commented on Dec 13, 2022

    @michaelhaxhiu
    Contributor

    @aimane-chnaif yep, don't worry! :) I will dispatch you payment in 2 days via https://www.upwork.com/jobs/~012a0e934343a83aee

    Invited you to that job ^

  17. aimane-chnaif commented on Dec 13, 2022

    @aimane-chnaif
    Contributor

    Invited you to that job ^

    Accepted. Thanks @michaelhaxhiu

  18. michaelhaxhiu commented on Dec 13, 2022

    @michaelhaxhiu
    Contributor

    Cool, hired!

  19. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 13, 2022
  20. melvin-bot commented on Dec 13, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-20. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  21. changed the title [-][$1000] (Dark Theme) Tab highlight color is not correct.[/-] [+][HOLD for payment 2022-12-20] [$1000] (Dark Theme) Tab highlight color is not correct.[/+] on Dec 13, 2022
  22. melvin-bot commented on Dec 13, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif / @sketchydroide] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif / @sketchydroide] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif / @sketchydroide] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@michaelhaxhiu] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
  23. sketchydroide commented on Dec 14, 2022

    @sketchydroide
    Contributor

    I don't think there is an offending PR here, it's jus that the UI changes made this apparent, maybe it was forgotten, IDK

  24. michaelhaxhiu commented on Dec 14, 2022

    @michaelhaxhiu
    Contributor

    Agreed, this isn't a bug or error in our process. Checking the final box.

  25. michaelhaxhiu commented on Dec 20, 2022

    @michaelhaxhiu
    Contributor

    All paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions