You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-12-20] [$1000] (Dark Theme) Tab highlight color is not correct. #13256
Press Tab multiple times until first item on the LHN is highlighted.
Expected Result:
The Highlight outline should be #5AB0FF, and ensure we use this regardless of dark or light mode.
Actual Result:
The highlight outline is blue which is part of light theme and should match the dark theme
Workaround:
unknown
Platform:
Where is this issue occurring?
Web
Desktop App
Version Number: 1.2.35-0 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
seem like @shawnborton has decided on a blue color, the one from the links on the app, which I think it's still different from this one. So this GH still makes some sense
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][$1000] (Dark Theme) Tab highlight color is not correct.[/-][+][HOLD for payment 2022-12-20] [$1000] (Dark Theme) Tab highlight color is not correct.[/+]on Dec 13, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif / @sketchydroide] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif / @sketchydroide] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@michaelhaxhiu] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
Activity
melvin-bot commentedon Dec 2, 2022
Triggered auto assignment to @michaelhaxhiu (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.dhairyasenjaliya commentedon Dec 2, 2022
Proposal
We need to change the color on the below file to
focus-visible&focus[data-focusvisible-polyfill]propertybox-shadowtogreenHover: '#00C271',This
greenHovercolor looks neat & clean and but might we need to confirm the color with the design teamApp/web/index.html
Lines 35 to 42 in a8e3cb5
:focus-visible { outline: 0; - box-shadow: inset 0px 0px 0px 1px #0185ff; + box-shadow: inset 0px 0px 0px 1px #00C271; } :focus[data-focusvisible-polyfill] { outline: 0; - box-shadow: inset 0px 0px 0px 1px #0185ff; + box-shadow: inset 0px 0px 0px 1px #00C271; }Result

sketchydroide commentedon Dec 2, 2022
picking this up myself
parasharrajat commentedon Dec 2, 2022
I would suggest discussing this first with Design team to decide if this is really needed. I had doubt on this as I posted on slack.
sketchydroide commentedon Dec 2, 2022
@Expensify/design any input here?
michaelhaxhiu commentedon Dec 2, 2022
Hm I'm not convinced this is a bug as it stands.
The Expected Result section needs to be more specific too, as right now it's open ended:
What would matching the dark theme actually mean?
parasharrajat commentedon Dec 2, 2022
This is where the design team kicks in.
michaelhaxhiu commentedon Dec 2, 2022
Understood. I'm not going to export this job to Upwork until we define/agree on the Expected Result.
https://expensify.slack.com/archives/C049HHMV9SM/p1669986622516479?thread_ts=1669646862.849829&cid=C049HHMV9SM
shawnborton commentedon Dec 2, 2022
Cool, commenting over in Slack.
sketchydroide commentedon Dec 5, 2022
seem like @shawnborton has decided on a blue color, the one from the links on the app, which I think it's still different from this one. So this GH still makes some sense
29 remaining items
aimane-chnaif commentedon Dec 13, 2022
@michaelhaxhiu Also, C+ payment for PR review
parasharrajat commentedon Dec 13, 2022
Accepted.
michaelhaxhiu commentedon Dec 13, 2022
@aimane-chnaif yep, don't worry! :) I will dispatch you payment in 2 days via https://www.upwork.com/jobs/~012a0e934343a83aee
Invited you to that job ^
aimane-chnaif commentedon Dec 13, 2022
Accepted. Thanks @michaelhaxhiu
michaelhaxhiu commentedon Dec 13, 2022
Cool, hired!
melvin-bot commentedon Dec 13, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-20. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
[-][$1000] (Dark Theme) Tab highlight color is not correct.[/-][+][HOLD for payment 2022-12-20] [$1000] (Dark Theme) Tab highlight color is not correct.[/+]melvin-bot commentedon Dec 13, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sketchydroide commentedon Dec 14, 2022
I don't think there is an offending PR here, it's jus that the UI changes made this apparent, maybe it was forgotten, IDK
michaelhaxhiu commentedon Dec 14, 2022
Agreed, this isn't a bug or error in our process. Checking the final box.
michaelhaxhiu commentedon Dec 20, 2022
All paid.