Skip to content

The outline around the buttons shows rectangle in shape when used Tab to focus #13372

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open NewDot
  2. Enter email address
  3. Use Tab to focus on the Continue button

Expected Result:

Outline should be rounded at the ends

Actual Result:

Outline is rectangular

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.2.36-2

Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
11

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670215788196829?thread_ts=1669646862.849829&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c209fa348bb863c8
  • Upwork Job ID: 1608159495458529280
  • Last Price Increase: 2022-12-28

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 6, 2022
  2. melvin-bot commented on Dec 6, 2022

    @melvin-bot

    Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. added
    InternalRequires API changes or must be handled by Expensify staff
    on Dec 6, 2022
  4. marcaaron commented on Dec 6, 2022

    @marcaaron
    Contributor

    @shawnborton let me know if something like this would work for you...

    2022-12-06_10-30-57.mp4

    I'm thinking that another direction we could possibly take this in is to:

    • Disable the default outline (like we did with the text input)
    • Use the same light green color for focusing buttons
  5. shawnborton commented on Dec 6, 2022

    @shawnborton
    Contributor

    I like the blue so it is differentiated from the button color, and yeah, what you have there looks great in terms of shape!

  6. melvin-bot commented on Dec 12, 2022

    @melvin-bot

    @marcaaron Eep! 4 days overdue now. Issues have feelings too...

  7. marcaaron commented on Dec 12, 2022

    @marcaaron
    Contributor

    Have to test this on a few more platforms, but should be in review soon.

  8. melvin-bot commented on Dec 19, 2022

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. 17 remaining items

  10. changed the title [-][Regression test steps needed] The outline around the buttons shows rectangle in shape when used `Tab` to focus[/-] [+]The outline around the buttons shows rectangle in shape when used `Tab` to focus[/+] on Jan 12, 2023
  11. mallenexpensify commented on Jan 12, 2023

    @mallenexpensify
    Contributor

    @marcaaron @aimane-chnaif are the top three below needed for this? I got #4

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/254826
  12. trjExpensify commented on Jan 13, 2023

    @trjExpensify
    Contributor

    👋 Just to confirm. This is the only PR needed for this issue and it has been deployed, right? If so, let's add the reviewing label so it doesn't appear like it's still without one (and as a result breaking WAQ come Monday). Thanks!

  13. marcaaron commented on Jan 13, 2023

    @marcaaron
    Contributor

    I don't think it was a regression @mallenexpensify so no. It was on production when reported so none of those steps are necessary AFAICT. Unless I have missed something..

  14. marcaaron commented on Jan 13, 2023

    @marcaaron
    Contributor

    @trjExpensify Re-adding the reviewing label.

  15. trjExpensify commented on Jan 13, 2023

    @trjExpensify
    Contributor

    Thank yah

  16. marcaaron commented on Jan 13, 2023

    @marcaaron
    Contributor

    Actually I mean it's on production right so it should be closed? I'm lost on why this is still open.

  17. marcaaron commented on Jan 13, 2023

    @marcaaron
    Contributor

    Maybe we haven't paid @aimane-chnaif - been 3 weeks though 😬

  18. trjExpensify commented on Jan 13, 2023

    @trjExpensify
    Contributor

    Presumably for the checklist? Regression test issue was created today, for example.

  19. aimane-chnaif commented on Jan 13, 2023

    @aimane-chnaif
    Contributor

    Maybe we haven't paid @aimane-chnaif - been 3 weeks though 😬

    I got payment. Thanks for reminder.
    Feel free to close if BugZero Checklists are complete.

  20. mallenexpensify commented on Jan 13, 2023

    @mallenexpensify
    Contributor

    Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions