You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The outline around the buttons shows rectangle in shape when used Tab to focus #13372
changed the title [-][Regression test steps needed] The outline around the buttons shows rectangle in shape when used `Tab` to focus[/-][+]The outline around the buttons shows rectangle in shape when used `Tab` to focus[/+]on Jan 12, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
👋 Just to confirm. This is the only PR needed for this issue and it has been deployed, right? If so, let's add the reviewing label so it doesn't appear like it's still without one (and as a result breaking WAQ come Monday). Thanks!
I don't think it was a regression @mallenexpensify so no. It was on production when reported so none of those steps are necessary AFAICT. Unless I have missed something..
Activity
melvin-bot commentedon Dec 6, 2022
Triggered auto assignment to @davidcardoza (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.marcaaron commentedon Dec 6, 2022
@shawnborton let me know if something like this would work for you...
2022-12-06_10-30-57.mp4
I'm thinking that another direction we could possibly take this in is to:
shawnborton commentedon Dec 6, 2022
I like the blue so it is differentiated from the button color, and yeah, what you have there looks great in terms of shape!
melvin-bot commentedon Dec 12, 2022
@marcaaron Eep! 4 days overdue now. Issues have feelings too...
marcaaron commentedon Dec 12, 2022
Have to test this on a few more platforms, but should be in review soon.
melvin-bot commentedon Dec 19, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
17 remaining items
[-][Regression test steps needed] The outline around the buttons shows rectangle in shape when used `Tab` to focus[/-][+]The outline around the buttons shows rectangle in shape when used `Tab` to focus[/+]mallenexpensify commentedon Jan 12, 2023
@marcaaron @aimane-chnaif are the top three below needed for this? I got #4
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
trjExpensify commentedon Jan 13, 2023
👋 Just to confirm. This is the only PR needed for this issue and it has been deployed, right? If so, let's add the
reviewinglabel so it doesn't appear like it's still without one (and as a result breaking WAQ come Monday). Thanks!marcaaron commentedon Jan 13, 2023
I don't think it was a regression @mallenexpensify so no. It was on production when reported so none of those steps are necessary AFAICT. Unless I have missed something..
marcaaron commentedon Jan 13, 2023
@trjExpensify Re-adding the reviewing label.
trjExpensify commentedon Jan 13, 2023
Thank yah
marcaaron commentedon Jan 13, 2023
Actually I mean it's on production right so it should be closed? I'm lost on why this is still open.
marcaaron commentedon Jan 13, 2023
Maybe we haven't paid @aimane-chnaif - been 3 weeks though 😬
trjExpensify commentedon Jan 13, 2023
Presumably for the checklist? Regression test issue was created today, for example.
aimane-chnaif commentedon Jan 13, 2023
I got payment. Thanks for reminder.
Feel free to close if BugZero Checklists are complete.
mallenexpensify commentedon Jan 13, 2023
Closing!