You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-12-20] Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel #13406
changed the title [-]Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel[/-][+][HOLD for payment 2022-12-20] Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel[/+]on Dec 13, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR: Wouldn't say this is a regression, just something we missed considering while implementing the dark mode.
[@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: I don't think this is necessary, the dark mode implementation is application wide and I would say it is expected to miss small things here and there like this one.
[@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Activity
melvin-bot commentedon Dec 7, 2022
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 7, 2022
A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.
[-]Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel[/-][+][HOLD for payment 2022-12-20] Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel[/+]melvin-bot commentedon Dec 13, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-20. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Dec 13, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
1 remaining item
bfitzexpensify commentedon Dec 21, 2022
Posted on the regression test here
mallenexpensify commentedon Dec 24, 2022
Hired @rushatgabhane and @Santhosh-Sellavel can you please accept the job and reply here once you have?
Santhosh-Sellavel commentedon Dec 24, 2022
@mallenexpensify I think everyone got paid here, this one is already taken care of by @bfitzexpensify.
mallenexpensify commentedon Dec 26, 2022
I'm a bit confused so I'll wait for @bfitzexpensify to return. I currently see
bfitzexpensify commentedon Dec 28, 2022
Good catch @mallenexpensify. Paid and ended the contract for @rushatgabhane.
bfitzexpensify commentedon Jan 2, 2023
Regression test update complete.
melvin-bot commentedon Jan 5, 2023
@bfitzexpensify, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
aldo-expensify commentedon Jan 5, 2023
Are we ready to close this? I commented on the checklist above
mallenexpensify commentedon Jan 6, 2023
Looks like it!