Skip to content

[HOLD for payment 2022-12-20] Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel #13406

Closed

Description

@aldo-expensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat with PDF sent as attachment
  2. Go offline
  3. Try to open attachment
  4. Error show

Expected Result:

The shown error should be visible clearly

Actual Result:

Not visible clearly as the text is in black

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670440109874269

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 7, 2022
  2. melvin-bot commented on Dec 7, 2022

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. added
    InternalRequires API changes or must be handled by Expensify staff
    on Dec 7, 2022
  4. melvin-bot commented on Dec 7, 2022

    @melvin-bot

    A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 13, 2022
  6. changed the title [-]Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel[/-] [+][HOLD for payment 2022-12-20] Failed to load PDF message color should be white for dark theme - reported by Santhosh-Sellavel[/+] on Dec 13, 2022
  7. melvin-bot commented on Dec 13, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-20. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  8. melvin-bot commented on Dec 13, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR: Wouldn't say this is a regression, just something we missed considering while implementing the dark mode.
    • [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: I don't think this is necessary, the dark mode implementation is application wide and I would say it is expected to miss small things here and there like this one.
    • [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@bfitzexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/251597
  9. 1 remaining item

  10. bfitzexpensify commented on Dec 21, 2022

    @bfitzexpensify
    Contributor

    Posted on the regression test here

  11. mallenexpensify commented on Dec 24, 2022

    @mallenexpensify
    Contributor

    Hired @rushatgabhane and @Santhosh-Sellavel can you please accept the job and reply here once you have?

  12. Santhosh-Sellavel commented on Dec 24, 2022

    @Santhosh-Sellavel
    Collaborator

    @mallenexpensify I think everyone got paid here, this one is already taken care of by @bfitzexpensify.

  13. mallenexpensify commented on Dec 26, 2022

    @mallenexpensify
    Contributor

    I'm a bit confused so I'll wait for @bfitzexpensify to return. I currently see

  14. bfitzexpensify commented on Dec 28, 2022

    @bfitzexpensify
    Contributor

    Good catch @mallenexpensify. Paid and ended the contract for @rushatgabhane.

  15. bfitzexpensify commented on Jan 2, 2023

    @bfitzexpensify
    Contributor

    Regression test update complete.

  16. melvin-bot commented on Jan 5, 2023

    @melvin-bot

    @bfitzexpensify, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. aldo-expensify commented on Jan 5, 2023

    @aldo-expensify
    ContributorAuthor

    Are we ready to close this? I commented on the checklist above

  18. mallenexpensify commented on Jan 6, 2023

    @mallenexpensify
    Contributor

    Looks like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions