Skip to content

[Regression test steps needed? Design] Fix font CSS so that we display the correct font weights #13413

Closed

Description

@shawnborton

We are not implementing the font CSS correctly. For example, take a look at how we are calling ExpensifyNeue-Regular but setting the font-weight to 700. What’s actually happening here is that the browser is adding a “fake bold” effect to the regular weight font, and the correct bold font files aren’t being used. But if we call the correct bold weight family that we are setting in our CSS here, notice how much more crisp this is.

Wrong:
image

Right:
image

Compare:
image

Solution:
Let's make all of the CSS use the font family ExpensifyNeue-Regular but then we can use things like font-weight: 700 or font-style: italic to get the desired weights/styles we need. This will make sure we're always using the correct font files and thus we won't have the fake browser bolding happening.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013936adee3d2f99bd
  • Upwork Job ID: 1608287987603697664
  • Last Price Increase: 2022-12-29

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Dec 7, 2022
  2. melvin-bot commented on Dec 19, 2022

    @melvin-bot

    @shawnborton, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

  3. shawnborton commented on Dec 19, 2022

    @shawnborton
    ContributorAuthor

    Not overdue, this was just merged!

  4. melvin-bot commented on Dec 27, 2022

    @melvin-bot

    @shawnborton, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. grgia commented on Dec 27, 2022

    @grgia
    Contributor

    I think we should be good to close as completed!

  6. mananjadhav commented on Dec 29, 2022

    @mananjadhav
    Collaborator

    @grgia this still needs to be open for the internal PR Review. Can you please assign someone (I've also posted on the slack in case we don't want to reopen the issue)

  7. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Dec 29, 2022
  8. melvin-bot commented on Dec 29, 2022

    @melvin-bot
  9. melvin-bot commented on Dec 29, 2022

    @melvin-bot

    Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

  10. mallenexpensify commented on Dec 29, 2022

    @mallenexpensify
    Contributor

    PR - #13415
    @mananjadhav can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~013936adee3d2f99bd

  11. mananjadhav commented on Dec 30, 2022

    @mananjadhav
    Collaborator
  12. mallenexpensify commented on Dec 30, 2022

    @mallenexpensify
    Contributor

    Paid @mananjadhav
    hmm.... I think this is another we should leave open until we suss out if we want regression test steps for design issues. I'm going to assign myself, update the title and bump to weekly for now.

  13. changed the title [-]Fix font CSS so that we display the correct font weights[/-] [+][Regression test steps needed? Design] Fix font CSS so that we display the correct font weights[/+] on Dec 30, 2022
  14. mananjadhav commented on Jan 12, 2023

    @mananjadhav
    Collaborator

    @mallenexpensify I think we've got many issues where we're not updating regression steps. Can you or @shawnborton confirm so that we can close this one out faster?

  15. shawnborton commented on Jan 12, 2023

    @shawnborton
    ContributorAuthor

    Yeah, from my understanding I think we can just close this one out. This wasn't so much a regression but it was just not implemented correctly, so we followed up and fixed it.

  16. mallenexpensify commented on Jan 12, 2023

    @mallenexpensify
    Contributor

    We're definitely learning the regression test steps process on the fly. Gonna close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions