You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Regression test steps needed? Design] Fix font CSS so that we display the correct font weights #13413
We are not implementing the font CSS correctly. For example, take a look at how we are calling ExpensifyNeue-Regular but setting the font-weight to 700. What’s actually happening here is that the browser is adding a “fake bold” effect to the regular weight font, and the correct bold font files aren’t being used. But if we call the correct bold weight family that we are setting in our CSS here, notice how much more crisp this is.
Wrong:
Right:
Compare:
Solution:
Let's make all of the CSS use the font family ExpensifyNeue-Regular but then we can use things like font-weight: 700 or font-style: italic to get the desired weights/styles we need. This will make sure we're always using the correct font files and thus we won't have the fake browser bolding happening.
@grgia this still needs to be open for the internal PR Review. Can you please assign someone (I've also posted on the slack in case we don't want to reopen the issue)
Paid @mananjadhav
hmm.... I think this is another we should leave open until we suss out if we want regression test steps for design issues. I'm going to assign myself, update the title and bump to weekly for now.
changed the title [-]Fix font CSS so that we display the correct font weights[/-][+][Regression test steps needed? Design] Fix font CSS so that we display the correct font weights[/+]on Dec 30, 2022
@mallenexpensify I think we've got many issues where we're not updating regression steps. Can you or @shawnborton confirm so that we can close this one out faster?
Yeah, from my understanding I think we can just close this one out. This wasn't so much a regression but it was just not implemented correctly, so we followed up and fixed it.
Activity
melvin-bot commentedon Dec 19, 2022
@shawnborton, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!
shawnborton commentedon Dec 19, 2022
Not overdue, this was just merged!
melvin-bot commentedon Dec 27, 2022
@shawnborton, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
grgia commentedon Dec 27, 2022
I think we should be good to close as completed!
mananjadhav commentedon Dec 29, 2022
@grgia this still needs to be open for the internal PR Review. Can you please assign someone (I've also posted on the slack in case we don't want to reopen the issue)
melvin-bot commentedon Dec 29, 2022
Job added to Upwork: https://www.upwork.com/jobs/~013936adee3d2f99bd
melvin-bot commentedon Dec 29, 2022
Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.
mallenexpensify commentedon Dec 29, 2022
PR - #13415
@mananjadhav can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~013936adee3d2f99bd
mananjadhav commentedon Dec 30, 2022
Accepted @mallenexpensify
mallenexpensify commentedon Dec 30, 2022
Paid @mananjadhav
hmm.... I think this is another we should leave open until we suss out if we want regression test steps for design issues. I'm going to assign myself, update the title and bump to weekly for now.
[-]Fix font CSS so that we display the correct font weights[/-][+][Regression test steps needed? Design] Fix font CSS so that we display the correct font weights[/+]mananjadhav commentedon Jan 12, 2023
@mallenexpensify I think we've got many issues where we're not updating regression steps. Can you or @shawnborton confirm so that we can close this one out faster?
shawnborton commentedon Jan 12, 2023
Yeah, from my understanding I think we can just close this one out. This wasn't so much a regression but it was just not implemented correctly, so we followed up and fixed it.
mallenexpensify commentedon Jan 12, 2023
We're definitely learning the regression test steps process on the fly. Gonna close this