You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] The cursor is displayed as pointer on the archived room banner text #13452
Hover over the “This chat room has been archived.” text
Expected Result:
Standard cursor is displayed as the text is not pressable
Actual Result:
Pointer/hand cursor is displayed
Workaround:
unknown
Platform:
Where is this issue occurring?
Web
Version Number: 1.2.37-0 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
I reported this bug and proposed the solution on slack. Posting it here too.
Proposal
Inside the Banner.js component, onPress is added to the Text component on line 79, which makes this text pressable. I don't think that onPress is being used or needed there, so removing that will fix this issue.
I don't think we need onPress in the text component as that text component only renders when shouldRenderHTML prop is false and shouldRenderHTML prop is false only when the archiveReason is default i.e. this case.
However, if we still don't want to remove onPress due to any reason, then we can either use shouldRenderHTML prop to add pressable condition or we can create a separate prop for it i.e. isTextPressable.
changed the title [-]The cursor is displayed as pointer on the archived room banner text[/-][+][$1000] The cursor is displayed as pointer on the archived room banner text[/+]on Dec 9, 2022
@JmillsExpensify@puneetlathThis PR was merged within 3 days and was released to production a week ago. I believe it has passed the 7 days so just waiting for the payment to be finalised
@JmillsExpensify@puneetlathThis PR was merged within 3 days and was released to production a week ago. I believe it has passed the 7 days so just waiting for the payment to be finalised
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Render banner in Concierge chat #11363 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Activity
melvin-bot commentedon Dec 9, 2022
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.syedsaroshfarrukhdot commentedon Dec 9, 2022
Proposal :-
We need to pass
pointerEventsNonetotextAfter Fix:-
Screen.Recording.2022-12-09.at.5.46.42.AM.mov
adeel0202 commentedon Dec 9, 2022
I reported this bug and proposed the solution on slack. Posting it here too.
Proposal
Inside the
Banner.jscomponent,onPressis added to theTextcomponent online 79, which makes this text pressable. I don't think thatonPressis being used or needed there, so removing that will fix this issue.Result
cursor.result.mov
syedsaroshfarrukhdot commentedon Dec 9, 2022
Update Proposal
As we need onPress In Some Situations We Can Take A New Props
isPressableinArchivedReportFooterto pass inBanner.jsAfter Fix :-
Screen.Recording.2022-12-09.at.9.03.54.AM.mov
adeel0202 commentedon Dec 9, 2022
Proposal 2
I don't think we need
onPressin the text component as that text component only renders whenshouldRenderHTMLprop is false andshouldRenderHTMLprop is false only when thearchiveReasonis default i.e. this case.However, if we still don't want to remove
onPressdue to any reason, then we can either useshouldRenderHTMLprop to add pressable condition or we can create a separate prop for it i.e.isTextPressable.melvin-bot commentedon Dec 9, 2022
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.
[-]The cursor is displayed as pointer on the archived room banner text[/-][+][$1000] The cursor is displayed as pointer on the archived room banner text[/+]melvin-bot commentedon Dec 9, 2022
Job added to Upwork: https://www.upwork.com/jobs/~01776d53155c170045
melvin-bot commentedon Dec 9, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (
External)38 remaining items
melvin-bot commentedon Dec 28, 2022
@puneetlath, @priyeshshah11, @Santhosh-Sellavel Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
JmillsExpensify commentedon Dec 28, 2022
@puneetlath You want me to jump in and help move this one forward?
priyeshshah11 commentedon Dec 29, 2022
@JmillsExpensify @puneetlath This PR was merged within 3 days and was released to production a week ago. I believe it has passed the 7 days so just waiting for the payment to be finalised
priyeshshah11 commentedon Jan 2, 2023
@JmillsExpensify @puneetlath any updates on this please?
JmillsExpensify commentedon Jan 2, 2023
Just assigned myself to help out. Based on the linked PR, this PR is eligible for a 50% bonus. That means that the following payouts are due:
JmillsExpensify commentedon Jan 2, 2023
Based on the above, I've just paid out @priyeshshah11 and @Santhosh-Sellavel. @adeel0202 Contract for reporting has been shared.
JmillsExpensify commentedon Jan 2, 2023
Update: All contributors are now paid out! Sorry for the delay.
JmillsExpensify commentedon Jan 2, 2023
@puneetlath I don't see a BZ checklist for this one. Mind chiming in on the regression/convo parts of that list?
adeel0202 commentedon Jan 2, 2023
Thanks, @JmillsExpensify. Kindly end the contract too.
priyeshshah11 commentedon Jan 2, 2023
Thanks! 😄 @JmillsExpensify
puneetlath commentedon Jan 5, 2023
JmillsExpensify commentedon Jan 11, 2023
Are we good to close this one out?
puneetlath commentedon Jan 11, 2023
Yep!