You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
react-pdf Document is caching PDFs failure to load #13453
Open the pdf and verify that you see error message
Close the modal
Go back online
Open the pdf
Expected Result:
The PDF should open successfully now that you are online
Actual Result:
We keep getting the error after coming back online
Screen.Recording.2022-12-08.at.4.19.03.PM.mov
Workaround:
Refresh the page?
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
@muttmuure This issue was mentioned by @rushatgabhanehere when he was reviewing a PR. Just mentioning in case it makes him qualify for reporting compensation.
Hey @aldo-expensify I can't reproduce this - I can still load the PDF I uploaded even after I go offline, do you mind checking that the bug still happens for you?
I managed to reproduce, but I noticed that I can only do it using the Chrome dev tools to go offline/online and with Disable cache checked. I tried to reproduce without chrome dev tools by disconnecting the wifi and it works fine in that case (which is the normal use case).
Activity
melvin-bot commentedon Dec 9, 2022
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.aldo-expensify commentedon Dec 9, 2022
I think a next step is create a GH issue in the react-pdf repo: https://github.com/wojtekmaj/react-pdf/issues proving a reproducible example.
There is an existing issue about disabling cache, but it was opened for other reasons and then closed without activity.
aldo-expensify commentedon Dec 9, 2022
When we close and reopen the attachment, I confirmed that the component PDFView is getting destroyed/reconstructed.
aldo-expensify commentedon Dec 9, 2022
@muttmuure This issue was mentioned by @rushatgabhane here when he was reviewing a PR. Just mentioning in case it makes him qualify for reporting compensation.
melvin-bot commentedon Dec 12, 2022
@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!
muttmuure commentedon Dec 13, 2022
Not had chance to get to this yet
melvin-bot commentedon Dec 19, 2022
@muttmuure Huh... This is 4 days overdue. Who can take care of this?
muttmuure commentedon Dec 21, 2022
Testing now
muttmuure commentedon Dec 21, 2022
Hey @aldo-expensify I can't reproduce this - I can still load the PDF I uploaded even after I go offline, do you mind checking that the bug still happens for you?
aldo-expensify commentedon Dec 21, 2022
I managed to reproduce, but I noticed that I can only do it using the Chrome dev tools to go offline/online and with
Disable cachechecked. I tried to reproduce without chrome dev tools by disconnecting the wifi and it works fine in that case (which is the normal use case).I'm going to close it, thanks for trying!