Skip to content

[HOLD for regression test steps][$1000] Web - Changing room name offline doesn't reflect in LHN until another chat/room opened #13457

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #13189

Action Performed:

  1. Go to https://staging.new.expensify.com/
    and login
  2. Create a room
  3. Go offline
  4. Go to room settings
  5. Change room name
  6. Click Save

Expected Result:

Room name should be updated through out the app

Actual Result:

Room name is not updated in LHN until another chat/room opened

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.37.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5855586_video_21.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b4df137e42b2ccf6
  • Upwork Job ID: 1601251791178326016

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 9, 2022
  2. melvin-bot commented on Dec 9, 2022

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. tienifr commented on Dec 9, 2022

    @tienifr
    Contributor

    Proposal

    Problem

    In App/src/pages/home/sidebar/SidebarLinks.js
    Because the chatReportSelector function doesn't update reportName and then when a reportName of the report is updated the old data and the updated data is similar so the SidebarLinks component isn't rendered

    Solution

    In https://github.com/tienifr/App/blob/216bbe9ff3995264e08a542d618bcc1db12d946f/src/pages/home/sidebar/SidebarLinks.js#L205

    we will update the reportName and then when reportName is updated, this component will rendered again and updated the lastest information

    const chatReportSelector = (report) => {
        if (ReportUtils.isIOUReport(report)) {
            return null;
        }
        return report && ({
            reportID: report.reportID,
            participants: report.participants,
            hasDraft: report.hasDraft,
            isPinned: report.isPinned,
            errorFields: {
                addWorkspaceRoom: report.errorFields && report.errorFields.addWorkspaceRoom,
            },
            maxSequenceNumber: report.maxSequenceNumber,
            lastReadSequenceNumber: report.lastReadSequenceNumber,
            lastMessageText: report.lastMessageText,
            lastActionCreated: report.lastActionCreated,
            iouReportID: report.iouReportID,
            hasOutstandingIOU: report.hasOutstandingIOU,
            statusNum: report.statusNum,
            stateNum: report.stateNum,
            chatType: report.chatType,
            policyID: report.policyID,
    +        reportName: report.reportName,
        });
    };

    Result

    Screen.Recording.2022-12-09.at.15.07.30.mov
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 9, 2022
  5. melvin-bot commented on Dec 9, 2022

    @melvin-bot

    Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

  6. changed the title [-]Web - Changing room name offline doesn't reflect in LHN until another chat/room opened[/-] [+][$1000] Web - Changing room name offline doesn't reflect in LHN until another chat/room opened[/+] on Dec 9, 2022
  7. melvin-bot commented on Dec 9, 2022

    @melvin-bot
  8. melvin-bot commented on Dec 9, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 9, 2022
  10. melvin-bot commented on Dec 9, 2022

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. tgolen commented on Dec 9, 2022

    @tgolen
    Contributor

    🟢 on the proposal from @tienifr. Without the report name being returned there, the LHN will never get updated when the name changes.

  12. 36 remaining items

  13. mananjadhav commented on Jan 8, 2023

    @mananjadhav
    Collaborator

    @zanyrenney Did you get a chance to look at the above comments on pending regression steps?

  14. zanyrenney commented on Jan 10, 2023

    @zanyrenney
    Contributor

    The call for the regression steps came in whilst I was OOO for the holidays (26th December). Working on this now.

  15. zanyrenney commented on Jan 10, 2023

    @zanyrenney
    Contributor
  16. mananjadhav commented on Jan 12, 2023

    @mananjadhav
    Collaborator

    thanks for picking this up @zanyrenney.

  17. zanyrenney commented on Jan 20, 2023

    @zanyrenney
    Contributor

    Going to bump the QA channel for the regression test.

  18. zanyrenney commented on Jan 30, 2023

    @zanyrenney
    Contributor
  19. neil-marcellini commented on Feb 7, 2023

    @neil-marcellini
    Contributor

    Looks like the regression tests were added. Have we paid everyone? If so I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions