You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for regression test steps][$1000] Web - Changing room name offline doesn't reflect in LHN until another chat/room opened #13457
In App/src/pages/home/sidebar/SidebarLinks.js
Because the chatReportSelector function doesn't update reportName and then when a reportName of the report is updated the old data and the updated data is similar so the SidebarLinks component isn't rendered
changed the title [-]Web - Changing room name offline doesn't reflect in LHN until another chat/room opened[/-][+][$1000] Web - Changing room name offline doesn't reflect in LHN until another chat/room opened[/+]on Dec 9, 2022
Activity
melvin-bot commentedon Dec 9, 2022
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.tienifr commentedon Dec 9, 2022
Proposal
Problem
In App/src/pages/home/sidebar/SidebarLinks.js
Because the
chatReportSelectorfunction doesn't update reportName and then when a reportName of the report is updated the old data and the updated data is similar so the SidebarLinks component isn't renderedSolution
In https://github.com/tienifr/App/blob/216bbe9ff3995264e08a542d618bcc1db12d946f/src/pages/home/sidebar/SidebarLinks.js#L205
we will update the reportName and then when reportName is updated, this component will rendered again and updated the lastest information
const chatReportSelector = (report) => { if (ReportUtils.isIOUReport(report)) { return null; } return report && ({ reportID: report.reportID, participants: report.participants, hasDraft: report.hasDraft, isPinned: report.isPinned, errorFields: { addWorkspaceRoom: report.errorFields && report.errorFields.addWorkspaceRoom, }, maxSequenceNumber: report.maxSequenceNumber, lastReadSequenceNumber: report.lastReadSequenceNumber, lastMessageText: report.lastMessageText, lastActionCreated: report.lastActionCreated, iouReportID: report.iouReportID, hasOutstandingIOU: report.hasOutstandingIOU, statusNum: report.statusNum, stateNum: report.stateNum, chatType: report.chatType, policyID: report.policyID, + reportName: report.reportName, }); };Result
Screen.Recording.2022-12-09.at.15.07.30.mov
melvin-bot commentedon Dec 9, 2022
Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.
[-]Web - Changing room name offline doesn't reflect in LHN until another chat/room opened[/-][+][$1000] Web - Changing room name offline doesn't reflect in LHN until another chat/room opened[/+]melvin-bot commentedon Dec 9, 2022
Job added to Upwork: https://www.upwork.com/jobs/~01b4df137e42b2ccf6
melvin-bot commentedon Dec 9, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)melvin-bot commentedon Dec 9, 2022
Triggered auto assignment to @neil-marcellini (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.tgolen commentedon Dec 9, 2022
🟢 on the proposal from @tienifr. Without the report name being returned there, the LHN will never get updated when the name changes.
36 remaining items
mananjadhav commentedon Jan 8, 2023
@zanyrenney Did you get a chance to look at the above comments on pending regression steps?
zanyrenney commentedon Jan 10, 2023
The call for the regression steps came in whilst I was OOO for the holidays (26th December). Working on this now.
zanyrenney commentedon Jan 10, 2023
asking for a buddy check for the regression test here - https://expensify.slack.com/archives/C01SKUP7QR0/p1673376310955709?thread_ts=1673376258.732639&cid=C01SKUP7QR0
mananjadhav commentedon Jan 12, 2023
thanks for picking this up @zanyrenney.
zanyrenney commentedon Jan 20, 2023
Going to bump the QA channel for the regression test.
zanyrenney commentedon Jan 30, 2023
Bumped the issue again. https://github.com/Expensify/Expensify/issues/254153
neil-marcellini commentedon Feb 7, 2023
Looks like the regression tests were added. Have we paid everyone? If so I think we can close this.