You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-12-22] [HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown #13511
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@maddylewis] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
changed the title [-][HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown[/-][+][HOLD for payment 2022-12-22] [HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown[/+]on Dec 15, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.39-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Gonals] The PR that introduced the bug has been identified. Link to the PR:
[@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@maddylewis] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
Activity
melvin-bot commentedon Dec 11, 2022
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Gonals commentedon Dec 12, 2022
Taking a look!
youssef-lr commentedon Dec 12, 2022
@Gonals I got a fix for this in the linked issue by @robertjchen, see this Slack convo
Gonals commentedon Dec 12, 2022
@youssef-lr, Ah, this was a duplicate, I see!
I was actually going to create another one to fix the web side too, so let's just keep both! I think we should be doing both things anyways
7 remaining items
melvin-bot commentedon Dec 13, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown[/-][+][HOLD for payment 2022-12-22] [HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown[/+]melvin-bot commentedon Dec 15, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.39-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-22. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Dec 15, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
maddylewis commentedon Dec 27, 2022
buddy check if a regression test is needed here - https://expensify.slack.com/archives/C01SKUP7QR0/p1672152149673229
melvin-bot commentedon Jan 3, 2023
@Gonals, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Gonals commentedon Jan 4, 2023
This one got reverted, so checking out all boxes 🤷
maddylewis commentedon Jan 4, 2023
@Gonals does this mean we should close out the issue? or, should I still be adding a regression test to Test Rail?
Gonals commentedon Jan 5, 2023
Ah, we can close this one. It was kind of a duplicate and it got fixed elsewhere, basically
maddylewis commentedon Jan 5, 2023
okay, great! thanks for the clarification. ill go ahead and close this one out 👍