Skip to content

[HOLD for payment 2022-12-22] [HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown #13511

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-Condition: User A has requested money from User B

  1. Access staging.new.expensify.com
  2. Sign into a valid account (User B)
  3. Navigate to the conversation with User A
  4. Settle up
  5. After settling, request a payment from User A

Expected Result:

User expects the payment request to go through with no issues

Actual Result:

User receives an error message

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5858837_User_can_not_request_money_after_setttling.mp4

Expensify/Expensify Issue URL: 1.2.38-0
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 11, 2022
  2. melvin-bot commented on Dec 11, 2022

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Dec 12, 2022
  4. Gonals commented on Dec 12, 2022

    @Gonals
    Contributor

    Taking a look!

  5. self-assigned this
    on Dec 12, 2022
  6. youssef-lr commented on Dec 12, 2022

    @youssef-lr
    Contributor

    @Gonals I got a fix for this in the linked issue by @robertjchen, see this Slack convo

  7. Gonals commented on Dec 12, 2022

    @Gonals
    Contributor

    @youssef-lr, Ah, this was a duplicate, I see!

    I was actually going to create another one to fix the web side too, so let's just keep both! I think we should be doing both things anyways

  8. 7 remaining items

  9. melvin-bot commented on Dec 13, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  10. changed the title [-][HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown[/-] [+][HOLD for payment 2022-12-22] [HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown[/+] on Dec 15, 2022
  11. melvin-bot commented on Dec 15, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.39-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-22. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Dec 15, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Gonals] The PR that introduced the bug has been identified. Link to the PR:
    • [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@maddylewis] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
  13. maddylewis commented on Dec 27, 2022

    @maddylewis
    Contributor

    buddy check if a regression test is needed here - https://expensify.slack.com/archives/C01SKUP7QR0/p1672152149673229

  14. melvin-bot commented on Jan 3, 2023

    @melvin-bot

    @Gonals, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. Gonals commented on Jan 4, 2023

    @Gonals
    Contributor

    This one got reverted, so checking out all boxes 🤷

  16. maddylewis commented on Jan 4, 2023

    @maddylewis
    Contributor

    This one got reverted, so checking out all boxes 🤷

    @Gonals does this mean we should close out the issue? or, should I still be adding a regression test to Test Rail?

  17. Gonals commented on Jan 5, 2023

    @Gonals
    Contributor

    Ah, we can close this one. It was kind of a duplicate and it got fixed elsewhere, basically

  18. maddylewis commented on Jan 5, 2023

    @maddylewis
    Contributor

    okay, great! thanks for the clarification. ill go ahead and close this one out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions