Skip to content

[$500] [HOLD for payment 2023-12-06] Local testing of GitHub Actions #13604

Closed

Description

@roryabraham

Problem

There is no easy way to locally test our GitHub Actions.

Why this is important

When we make changes to GitHub Actions, it's difficult to generate confidence that a PR will work and do what it is intended. This creates headaches:

  • It's harder to review GitHub Actions PRs and they need to be reviewed more carefully
  • We need to live-test things which is often disruptive
  • The best approximation is testing using another repo. We often use https://github.com/Andrew-Test-Org/Public-Test-Repo), but still the workflows you're testing there are not the same as the one's you're testing in E/App, and there may be different constraints in place, etc...
  • There's a slower feedback loop with simple mistakes in Actions and Workflows, leading to development taking longer

Solution

Implement a local testing framework for GitHub Actions using https://github.com/nektos/act

Issue OwnerCurrent Issue Owner: @muttmuure
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016c26e8384c322e36
  • Upwork Job ID: 1734891845984043008
  • Last Price Increase: 2023-12-13

Activity

  1. locked and limited conversation to collaborators on Dec 15, 2022
  2. unlocked this conversation on Jan 26, 2023
  3. radoslawkrzemien commented on Jan 26, 2023

    @radoslawkrzemien
    Contributor

    I'd like to have a look at this

  4. changed the title [-][HOLD] Local testing of GitHub Actions[/-] [+]Local testing of GitHub Actions[/+] on Jan 26, 2023
  5. 306 remaining items

  6. melvin-bot commented on Nov 29, 2023

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  7. dangrous commented on Dec 8, 2023

    @dangrous
    Contributor

    @sobitneupane we need to get a BZ in here to handle your payment, right?

  8. sobitneupane commented on Dec 8, 2023

    @sobitneupane
    Contributor

    Yes, @dangrous. There were two PRs in this issue. One of them was reviewed by me and the other by @rushatgabhane

  9. melvin-bot commented on Dec 8, 2023

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. melvin-bot commented on Dec 8, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  11. dangrous commented on Dec 8, 2023

    @dangrous
    Contributor
  12. muttmuure commented on Dec 13, 2023

    @muttmuure
    Contributor
  13. melvin-bot commented on Dec 13, 2023

    @melvin-bot
  14. melvin-bot commented on Dec 13, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

  15. muttmuure commented on Dec 13, 2023

    @muttmuure
    Contributor

    both should request payment in NewDot - the summary is above here

  16. sobitneupane commented on Dec 15, 2023

    @sobitneupane
    Contributor

    #13604 (comment)

    Requested payment on newDot.

  17. JmillsExpensify commented on Dec 15, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @sobitneupane based on this comment.

  18. JmillsExpensify commented on Dec 26, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @rushatgabhane based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.Not a priority

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions