Skip to content

[$1000] Tooltip position changes after closing fab menu #13638

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Hover over Fab icon
  2. Click on it to open
  3. Click on it again to close

Expected Result:

The tooltip position stays the same (left of centre)

Actual Result :

The tooltip position changes (centre)

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.40-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1109.mp4
Screen.Recording.2022-12-15.at.9.50.09.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671121404845929

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017865baf3b71f832d
  • Upwork Job ID: 1603839332202037248
  • Last Price Increase: 2022-12-16

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 15, 2022
  2. melvin-bot commented on Dec 15, 2022

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Dec 15, 2022
  4. self-assigned this
    on Dec 15, 2022
  5. luacmartins commented on Dec 15, 2022

    @luacmartins
    Contributor

    Gonna work on this one!

  6. luacmartins commented on Dec 16, 2022

    @luacmartins
    Contributor

    Not sure if it's worth fixing this since it looks like an edge case and doesn't break any functionality (it only shifts the tooltip slightly, but resets the position if you hover the button again). I'll make this external.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 16, 2022
  8. unlocked this conversation on Dec 16, 2022
  9. melvin-bot commented on Dec 16, 2022

    @melvin-bot

    Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

  10. changed the title [-]Tooltip position changes after closing fab menu[/-] [+][$1000] Tooltip position changes after closing fab menu[/+] on Dec 16, 2022
  11. melvin-bot commented on Dec 16, 2022

    @melvin-bot
  12. melvin-bot commented on Dec 16, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  13. 13 remaining items

  14. laurenreidexpensify commented on Dec 28, 2022

    @laurenreidexpensify
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  15. laurenreidexpensify commented on Jan 3, 2023

    @laurenreidexpensify
    Contributor

    @thesahindia @luacmartins when you are back from holidays pls can you fill out remaining details. Thanks

  16. thesahindia commented on Jan 3, 2023

    @thesahindia
    Member

    Actually this bug was present from the starting so I think we can skip the checklist. Also it was an edge case. Let's just add a regression test?

  17. laurenreidexpensify commented on Jan 3, 2023

    @laurenreidexpensify
    Contributor

    SGTM

  18. daraksha-dk commented on Jan 3, 2023

    @daraksha-dk
    Contributor

    @laurenreidexpensify - I have applied to the job but have not received the reporting bonus, will you please check.

  19. michaelhaxhiu commented on Jan 9, 2023

    @michaelhaxhiu
    Contributor

    Re-opening this GH so @laurenreidexpensify can ensure it's finalized, and then go from there!

  20. laurenreidexpensify commented on Jan 10, 2023

    @laurenreidexpensify
    Contributor

    @daraksha-dk offer sent - will get this actioned ASAP for you

  21. laurenreidexpensify commented on Jan 10, 2023

    @laurenreidexpensify
    Contributor

    Paid! Sorry for the oversight here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions