You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Tooltip position changes after closing fab menu #13638
The tooltip position stays the same (left of centre)
Actual Result :
The tooltip position changes (centre)
Workaround:
unknown
Platform:
Where is this issue occurring?
Web
Version Number: 1.2.40-3 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Not sure if it's worth fixing this since it looks like an edge case and doesn't break any functionality (it only shifts the tooltip slightly, but resets the position if you hover the button again). I'll make this external.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Activity
melvin-bot commentedon Dec 15, 2022
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.luacmartins commentedon Dec 15, 2022
Gonna work on this one!
luacmartins commentedon Dec 16, 2022
Not sure if it's worth fixing this since it looks like an edge case and doesn't break any functionality (it only shifts the tooltip slightly, but resets the position if you hover the button again). I'll make this external.
melvin-bot commentedon Dec 16, 2022
Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.
[-]Tooltip position changes after closing fab menu[/-][+][$1000] Tooltip position changes after closing fab menu[/+]melvin-bot commentedon Dec 16, 2022
Job added to Upwork: https://www.upwork.com/jobs/~017865baf3b71f832d
melvin-bot commentedon Dec 16, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)13 remaining items
laurenreidexpensify commentedon Dec 28, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
laurenreidexpensify commentedon Jan 3, 2023
@thesahindia @luacmartins when you are back from holidays pls can you fill out remaining details. Thanks
thesahindia commentedon Jan 3, 2023
Actually this bug was present from the starting so I think we can skip the checklist. Also it was an edge case. Let's just add a regression test?
laurenreidexpensify commentedon Jan 3, 2023
SGTM
daraksha-dk commentedon Jan 3, 2023
@laurenreidexpensify - I have applied to the job but have not received the reporting bonus, will you please check.
michaelhaxhiu commentedon Jan 9, 2023
Re-opening this GH so @laurenreidexpensify can ensure it's finalized, and then go from there!
laurenreidexpensify commentedon Jan 10, 2023
@daraksha-dk offer sent - will get this actioned ASAP for you
laurenreidexpensify commentedon Jan 10, 2023
Paid! Sorry for the oversight here!