You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-01-30] [$1000] New Room - Capital letters is converted to lowercase when all caps is enable #13676
On the name field double tap on the shift ⬆️ so the all caps is enabled
Tap in different keys on the actual device keyboard
Expected Result:
Capital letters is visible until an area outside of the field is tapped. Capital letters is not visible and transaction is smooth when all caps is enabled
Actual Result:
Capital letter changes to lowercase. Capital letters is visible and transaction isn't smooth when all caps is enable
It's not related, but I'm not sure if we can do something about it, this is mobile iOS and Android, the other one was Android only.
Yes it's related to the other one.
The issue is that we take the input of the user, and change it on the fly, so what happens is that the user still sees the text before we change it, giving it this weird jagged behaviour. @madmax330 if you make changes on the other one it should in princible fix this one, but let us know if I'm wrong.
changed the title [-][$1000] New Room - Capital letters is converted to lowercase when all caps is enable[/-][+][HOLD for payment 2023-01-30] [$1000] New Room - Capital letters is converted to lowercase when all caps is enable[/+]on Jan 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.57-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia / @sketchydroide / @madmax330] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia / @sketchydroide / @madmax330] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Posted buddy check for regression test steps
Recommendation: Update Room - Create Room Conversation (Online/Offline) in Testrail to add
6. Enter capital letters in the room name and hit return
7 Verify you're allowed to enter capital letters and that after return is tapped this error message shows "Room names can only include lowercase letters, numbers and hyphens"
Activity
melvin-bot commentedon Dec 16, 2022
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Christinadobrzyn commentedon Dec 19, 2022
This might be related - #13463 @sketchydroide can I get your thoughts if this is the same issue (I see the PR merged so maybe it's not)?
It might also be related to this - #13042 - maybe capital letters are considered a special character right now? @madmax330 can I get your thoughts?
sketchydroide commentedon Dec 19, 2022
It's not related, but I'm not sure if we can do something about it, this is mobile iOS and Android, the other one was Android only.
Yes it's related to the other one.
The issue is that we take the input of the user, and change it on the fly, so what happens is that the user still sees the text before we change it, giving it this weird jagged behaviour.
@madmax330 if you make changes on the other one it should in princible fix this one, but let us know if I'm wrong.
Either way @Christinadobrzyn I think this GH will be closed.
Christinadobrzyn commentedon Dec 21, 2022
Thanks @sketchydroide! We'll wait to hear from @madmax330 to see if he might have more info on this issue being resolved with #13042
Christinadobrzyn commentedon Dec 22, 2022
I'm ooo so going to reassign
mallenexpensify commentedon Dec 23, 2022
Also waiting for feedback from @madmax330
95 remaining items
[-][$1000] New Room - Capital letters is converted to lowercase when all caps is enable[/-][+][HOLD for payment 2023-01-30] [$1000] New Room - Capital letters is converted to lowercase when all caps is enable[/+]melvin-bot commentedon Jan 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.57-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-01-30. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jan 23, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
thesahindia commentedon Jan 31, 2023
We can leave the first 3 checkboxes since it wasn't a regression. It was implemented this way.
thesahindia commentedon Jan 31, 2023
@mallenexpensify, this is ready for payment.
mallenexpensify commentedon Jan 31, 2023
@jatinsonijs assigned on Jan 18
PR merged on Jan 19th
Paid @jatinsonijs and @thesahindia $1500 each which includes the timeliness bonus.
Posted buddy check for regression test steps
Recommendation: Update Room - Create Room Conversation (Online/Offline) in Testrail to add
6. Enter capital letters in the room name and hit return
7 Verify you're allowed to enter capital letters and that after return is tapped this error message shows "Room names can only include lowercase letters, numbers and hyphens"
thesahindia commentedon Feb 2, 2023
No action is needed from me so unassigning.
P.S. The steps looks good to me
mallenexpensify commentedon Feb 2, 2023
Testrail GH created https://github.com/Expensify/Expensify/issues/260050
@thesahindia @sketchydroide @madmax330 can you review and take action on the top 3 in the checklist plz, then we can close #13676 (comment)
thesahindia commentedon Feb 3, 2023
As mentioned in #13676 (comment). I think we can leave those because it wasn't a regression.
mallenexpensify commentedon Feb 4, 2023
K, I checked them off then. @thesahindia are C+ able to check off boxes? Can't remember
thesahindia commentedon Feb 4, 2023
Nope, we can't edit.