Skip to content

[HOLD for payment 2023-01-30] [$1000] New Room - Capital letters is converted to lowercase when all caps is enable #13676

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #13621

Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Press the Green + button and select New Room
  4. On the name field double tap on the shift ⬆️ so the all caps is enabled
  5. Tap in different keys on the actual device keyboard

Expected Result:

Capital letters is visible until an area outside of the field is tapped.
Capital letters is not visible and transaction is smooth when all caps is enabled

Actual Result:

Capital letter changes to lowercase.
Capital letters is visible and transaction isn't smooth when all caps is enable

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.2.41.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5866671_Screen_Recording_20221216-122119_New_Expensify__1_.mp4
Bug5866671_RPReplay_Final1671212576.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01773a5a2201587c50
  • Upwork Job ID: 1612436167049437184
  • Last Price Increase: 2023-01-09

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 16, 2022
  2. melvin-bot commented on Dec 16, 2022

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Dec 16, 2022
  4. Christinadobrzyn commented on Dec 19, 2022

    @Christinadobrzyn
    Contributor

    This might be related - #13463 @sketchydroide can I get your thoughts if this is the same issue (I see the PR merged so maybe it's not)?

    It might also be related to this - #13042 - maybe capital letters are considered a special character right now? @madmax330 can I get your thoughts?

  5. sketchydroide commented on Dec 19, 2022

    @sketchydroide
    Contributor

    It's not related, but I'm not sure if we can do something about it, this is mobile iOS and Android, the other one was Android only.
    Yes it's related to the other one.
    The issue is that we take the input of the user, and change it on the fly, so what happens is that the user still sees the text before we change it, giving it this weird jagged behaviour.
    @madmax330 if you make changes on the other one it should in princible fix this one, but let us know if I'm wrong.

    Either way @Christinadobrzyn I think this GH will be closed.

  6. Christinadobrzyn commented on Dec 21, 2022

    @Christinadobrzyn
    Contributor

    Thanks @sketchydroide! We'll wait to hear from @madmax330 to see if he might have more info on this issue being resolved with #13042

  7. Christinadobrzyn commented on Dec 22, 2022

    @Christinadobrzyn
    Contributor

    I'm ooo so going to reassign

  8. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 22, 2022
  9. removed their assignment
    on Dec 22, 2022
  10. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 22, 2022
  11. mallenexpensify commented on Dec 23, 2022

    @mallenexpensify
    Contributor

    Also waiting for feedback from @madmax330

  12. 95 remaining items

  13. changed the title [-][$1000] New Room - Capital letters is converted to lowercase when all caps is enable[/-] [+][HOLD for payment 2023-01-30] [$1000] New Room - Capital letters is converted to lowercase when all caps is enable[/+] on Jan 23, 2023
  14. melvin-bot commented on Jan 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.57-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-01-30. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Jan 23, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  16. thesahindia commented on Jan 31, 2023

    @thesahindia
    Member

    We can leave the first 3 checkboxes since it wasn't a regression. It was implemented this way.

  17. thesahindia commented on Jan 31, 2023

    @thesahindia
    Member

    @mallenexpensify, this is ready for payment.

  18. mallenexpensify commented on Jan 31, 2023

    @mallenexpensify
    Contributor

    @jatinsonijs assigned on Jan 18
    PR merged on Jan 19th

    Paid @jatinsonijs and @thesahindia $1500 each which includes the timeliness bonus.

    Posted buddy check for regression test steps
    Recommendation: Update Room - Create Room Conversation (Online/Offline) in Testrail to add
    6. Enter capital letters in the room name and hit return
    7 Verify you're allowed to enter capital letters and that after return is tapped this error message shows "Room names can only include lowercase letters, numbers and hyphens"

  19. thesahindia commented on Feb 2, 2023

    @thesahindia
    Member

    No action is needed from me so unassigning.

    P.S. The steps looks good to me

  20. removed their assignment
    on Feb 2, 2023
  21. mallenexpensify commented on Feb 2, 2023

    @mallenexpensify
    Contributor

    Testrail GH created https://github.com/Expensify/Expensify/issues/260050

    @thesahindia @sketchydroide @madmax330 can you review and take action on the top 3 in the checklist plz, then we can close #13676 (comment)

  22. thesahindia commented on Feb 3, 2023

    @thesahindia
    Member

    As mentioned in #13676 (comment). I think we can leave those because it wasn't a regression.

  23. mallenexpensify commented on Feb 4, 2023

    @mallenexpensify
    Contributor

    K, I checked them off then. @thesahindia are C+ able to check off boxes? Can't remember

  24. thesahindia commented on Feb 4, 2023

    @thesahindia
    Member

    Nope, we can't edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions