Skip to content

[HOLD for payment 2023-01-25] Date inputs allow 5 to 6 digits as year in Manual journey of Connect Bank Account #13837

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Go to any workspace
  3. Choose Connect Bank Account
  4. Choose Connect manually
  5. Go to step 2 of the Form
  6. Enter random values of "Incorporation date" and you'll notice the year part of the value can go upto 6 digits

Expected Result:

Year value should only allow 4 digits

Actual Result:

User can enter upto 6 digits

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • MacOS / Chrome / Safari

Version Number: 1.2.43-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
image

Untitled

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672076005803659

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a092ee76a867ed09
  • Upwork Job ID: 1613242559970676736
  • Last Price Increase: 2023-01-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 27, 2022
  2. locked and limited conversation to collaborators on Dec 27, 2022
  3. yuwenmemon commented on Jan 11, 2023

    @yuwenmemon
    Contributor

    Oh yes, I've seen this one! Will take a look.

  4. self-assigned this
    on Jan 11, 2023
  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 11, 2023
  6. unlocked this conversation on Jan 11, 2023
  7. melvin-bot commented on Jan 11, 2023

    @melvin-bot
  8. melvin-bot commented on Jan 11, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

  9. yuwenmemon commented on Jan 12, 2023

    @yuwenmemon
    Contributor

    Hmmm... I'm not sure what's happening here but it seems like we'd need a maxLength on our DatePicker component somewhere. Although I could be wrong.

    Anyway, it's consistently reproducible and is purely front-end so will flip this External.

  10. removed
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 12, 2023
  11. 50 remaining items

  12. arielgreen commented on Jan 23, 2023

    @arielgreen
    Contributor

    @mollfpr @yuwenmemon please be sure to complete the checklist here.

  13. mollfpr commented on Jan 23, 2023

    @mollfpr
    Contributor

    @arielgreen Thanks for the ping! Will finish the checklist today.

  14. yuwenmemon commented on Jan 24, 2023

    @yuwenmemon
    Contributor

    Thanks @mollfpr - let me know if I can be of assistance.

  15. mollfpr commented on Jan 25, 2023

    @mollfpr
    Contributor

    Previously we have maximumDate props to DatePicker where it's set to new Date() on the CompanyStep form. But before this PR, the props are removed to allow users to input any future dates and the Form will validate the value.

    Here's the PR #13702 that removes the maximumDate.

    cc @yuwenmemon

  16. yuwenmemon commented on Jan 25, 2023

    @yuwenmemon
    Contributor

    @arielgreen last item in the checklist is all yours!

  17. mollfpr commented on Jan 26, 2023

    @mollfpr
    Contributor
  18. arielgreen commented on Jan 31, 2023

    @arielgreen
    Contributor

    All payments have been issued. Discussing a test here, then we can close this one out.

  19. arielgreen commented on Feb 3, 2023

    @arielgreen
    Contributor

    Bumped thread for consensus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions