You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-01-25] Date inputs allow 5 to 6 digits as year in Manual journey of Connect Bank Account #13837
Enter random values of "Incorporation date" and you'll notice the year part of the value can go upto 6 digits
Expected Result:
Year value should only allow 4 digits
Actual Result:
User can enter upto 6 digits
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
MacOS / Chrome / Safari
Version Number: 1.2.43-1 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Previously we have maximumDate props to DatePicker where it's set to new Date() on the CompanyStep form. But before this PR, the props are removed to allow users to input any future dates and the Form will validate the value.
Here's the PR #13702 that removes the maximumDate.
Activity
yuwenmemon commentedon Jan 11, 2023
Oh yes, I've seen this one! Will take a look.
melvin-bot commentedon Jan 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01a092ee76a867ed09
melvin-bot commentedon Jan 11, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (
Internal)yuwenmemon commentedon Jan 12, 2023
Hmmm... I'm not sure what's happening here but it seems like we'd need a
maxLengthon ourDatePickercomponent somewhere. Although I could be wrong.Anyway, it's consistently reproducible and is purely front-end so will flip this External.
50 remaining items
arielgreen commentedon Jan 23, 2023
@mollfpr @yuwenmemon please be sure to complete the checklist here.
mollfpr commentedon Jan 23, 2023
@arielgreen Thanks for the ping! Will finish the checklist today.
yuwenmemon commentedon Jan 24, 2023
Thanks @mollfpr - let me know if I can be of assistance.
mollfpr commentedon Jan 25, 2023
Previously we have
maximumDateprops toDatePickerwhere it's set tonew Date()on theCompanyStepform. But before this PR, the props are removed to allow users to input any future dates and the Form will validate the value.Here's the PR #13702 that removes the
maximumDate.cc @yuwenmemon
yuwenmemon commentedon Jan 25, 2023
@arielgreen last item in the checklist is all yours!
mollfpr commentedon Jan 26, 2023
Bump @arielgreen
arielgreen commentedon Jan 31, 2023
All payments have been issued. Discussing a test here, then we can close this one out.
arielgreen commentedon Feb 3, 2023
Bumped thread for consensus