You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
IOS - Deep link doesn't direct to the IOS app when creating a new account #13882
This is actually expected, if we want to deeplink to the native app then the URL needs to have a different format, it's actually correct that we redirect to the web browser for any links that look like https://staging.new.expensify.com...
I don't think this is a bug per se. I think in other apps when you try to deeplink it will also bring you to the web app to do validation. I'm electing to close this out
changed the title [-]IOS - Dip link doesn't direct to the IOS app when creating a new account[/-][+]IOS - Deep link doesn't direct to the IOS app when creating a new account[/+]on Feb 15, 2023
@jasperhuangg I'm not sure if I understood the decision. Why would a link with staging.new.expensify.com not be an acceptable deep link? We have the acceptable schemes listed here:
Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
@marcaaron good shout, didn't realize that we also handled links with the format staging.new.expensify.com to the iOS app. This issue was correctly reported.
I'm gonna keep this closed since there's a dupe issue already: #15158
Activity
jasperhuangg commentedon Jan 4, 2023
This is actually expected, if we want to deeplink to the native app then the URL needs to have a different format, it's actually correct that we redirect to the web browser for any links that look like https://staging.new.expensify.com...
I don't think this is a bug per se. I think in other apps when you try to deeplink it will also bring you to the web app to do validation. I'm electing to close this out
[-]IOS - Dip link doesn't direct to the IOS app when creating a new account[/-][+]IOS - Deep link doesn't direct to the IOS app when creating a new account[/+]marcaaron commentedon Feb 15, 2023
@jasperhuangg I'm not sure if I understood the decision. Why would a link with
staging.new.expensify.comnot be an acceptable deep link? We have the acceptable schemes listed here:App/src/libs/Navigation/linkingConfig.js
Lines 6 to 13 in 1c45763
MelvinBot commentedon Feb 15, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
jasperhuangg commentedon Feb 15, 2023
@marcaaron good shout, didn't realize that we also handled links with the format staging.new.expensify.com to the iOS app. This issue was correctly reported.
I'm gonna keep this closed since there's a dupe issue already: #15158