Skip to content

[HOLD for payment 2023-01-17] The text on the edit photo profile modal is not selectable #14121

Closed

Description

@mollfpr

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Regression from #14048 and soon will be deploy blocker

Action Performed:

  • Login to an account
  • Open the settings page
  • Go to the profile page by clicking on the profile picture or the account email
  • Click on the profile picture and click on the upload photo button
  • Select an image from your computer and the upload photo modal will open
  • Select the text on the modal Drag, zoom, and rotate your image to your preferred specifications by double click the text

Expected Result:

The text will be highlighted

Actual Result:

The text is not will be highlighted

Workaround:

NA

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.2.50-13
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @jatinsonijs
Slack conversation:

View all open jobs on GitHub

Screen.Recording.2023-01-08.at.19.57.21.mov

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 8, 2023
  2. melvin-bot commented on Jan 8, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Jan 8, 2023
  4. francoisl commented on Jan 9, 2023

    @francoisl
    Contributor

    Marking this a deploy blocker as discussed in the fix PR. There is already a staging checklist open so we'll need to CP the fix to staging.

    cc @s77rt

  5. self-assigned this
    on Jan 9, 2023
  6. OSBotify commented on Jan 9, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. Julesssss commented on Jan 10, 2023

    @Julesssss
    Contributor

    I'm glad we have a PR open to resolve this unwanted change, but it hardly seems worthy of the deploy blocker label in my opinion. If the other blocker is resolved, I might remove the label here.

  8. 5 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 10, 2023
  10. changed the title [-]The text on the edit photo profile modal is not selectable[/-] [+][HOLD for payment 2023-01-17] The text on the edit photo profile modal is not selectable[/+] on Jan 10, 2023
  11. mallenexpensify commented on Jan 17, 2023

    @mallenexpensify
    Contributor

    @mollfpr , @jatinsonijs should be added to OP for reporting this regression bug, correct? And they're due $250 for the report
    #13146 (comment)

  12. mallenexpensify commented on Jan 19, 2023

    @mallenexpensify
    Contributor

    @sophiepintoraetz I added
    Issue reported by: @jatinsonijs
    Can you please hire and pay @jatinsonijs ? Thx

  13. sophiepintoraetz commented on Jan 19, 2023

    @sophiepintoraetz
    Contributor
  14. sophiepintoraetz commented on Jan 19, 2023

    @sophiepintoraetz
    Contributor

    Payment is done so is there anything else keeping this issue open?

  15. francoisl commented on Jan 19, 2023

    @francoisl
    Contributor

    I don't think so, let's close!

  16. unlocked this conversation on Jan 19, 2023
  17. mallenexpensify commented on Jan 19, 2023

    @mallenexpensify
    Contributor

    @jatinsonijs I unlocked this issue, did you have a question about payment or is everything set?

  18. jatinsonijs commented on Jan 20, 2023

    @jatinsonijs
    Contributor

    @mallenexpensify I have received reporting bonus, Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions