Skip to content

[$1000] Remove 'require cycles' developer warning message  #14816

Closed

Description

@Julesssss

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


As pointed out here, a new developer warning message was introduced by this PR. It is not a regression, but should be fixed. I attempted to resolve this myself here, but it appeared to break notifications 😕

We need to correctly import the Push Notification library, making sure that notifications work in all cases:

  • App open
  • App backgrounded
  • App backgrounded with sign out and sign in with different account
  • App killed

Action Performed:

  1. As a developer, launch the app to an iOS or Android device/simulator
  2. Notice the following warning

Expected Result:

The warning should not show

Actual Result:

The warning shows

Workaround:

This is a developer-only issue, and it isn't a blocker

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • iOS / native

Issue reported by: @dhairyasenjaliya

Simulator Screen Shot - iPhone 14 Pro Max - 2023-01-31 at 23 00 57
Simulator Screen Shot - iPhone 14 Pro Max - 2023-01-31 at 23 00 45

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019a3456a58e369fbd
  • Upwork Job ID: 1624093100668227584
  • Last Price Increase: 2023-02-10

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 3, 2023
  2. self-assigned this
    on Feb 3, 2023
  3. locked and limited conversation to collaborators on Feb 3, 2023
  4. unlocked this conversation on Feb 3, 2023
  5. melvin-bot commented on Feb 3, 2023

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. locked and limited conversation to collaborators on Feb 3, 2023
  7. melvin-bot commented on Feb 3, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. unlocked this conversation on Feb 3, 2023
  9. locked and limited conversation to collaborators on Feb 3, 2023
  10. kevinksullivan commented on Feb 3, 2023

    @kevinksullivan
    Contributor

    @Julesssss looks like this is iOS specific, yes? Also, I'm not sure what reproduction steps to take to complete the checklist. Can you help me understand the problem a bit more so I can reproduce? Thanks!

  11. Julesssss commented on Feb 6, 2023

    @Julesssss
    ContributorAuthor

    Ah right, sorry I should have used the default template.

    You're not going to be able to reproduce this as it's a developer environment issue only. It's occurring on Android and iOS and I'll update the description to make that clearer.

  12. 34 remaining items

  13. kevinksullivan commented on Feb 24, 2023

    @kevinksullivan
    Contributor

    Offer sent @abdulrahuman5196 . Let me know when you accept!

  14. dhairyasenjaliya commented on Feb 24, 2023

    @dhairyasenjaliya
    Contributor

    @kevinksullivan also can you invite me for reporting bug

  15. abdulrahuman5196 commented on Feb 24, 2023

    @abdulrahuman5196
    Contributor

    Offer sent @abdulrahuman5196 . Let me know when you accept!

    Accepted the offer. @kevinksullivan

  16. kevinksullivan commented on Feb 25, 2023

    @kevinksullivan
    Contributor

    Paid @abdulrahuman5196 . Offer sent @dhairyasenjaliya , let me know when you accept

  17. situchan commented on Feb 25, 2023

    @situchan
    Contributor

    I am the first one who reported this regression here

  18. Julesssss commented on Mar 3, 2023

    @Julesssss
    ContributorAuthor

    Sorry @situchan, I missed this. Lets make sure to report bugs in the Slack channel so that QA make the issue and correctly tag you next time.

    @kevinksullivan would you mind adding the report payment for @situchan?

  19. dhairyasenjaliya commented on Mar 3, 2023

    @dhairyasenjaliya
    Contributor

    Hm if that's valid bug reporting before my posted on slack I would be happy to revert this milestone @Julesssss

  20. Julesssss commented on Mar 3, 2023

    @Julesssss
    ContributorAuthor

    Honestly I'm struggling to see who posted if first. @dhairyasenjaliya I remember you posting in slack, that's why I created the issue, but I can't find the post and date anymore.

  21. dhairyasenjaliya commented on Mar 3, 2023

    @dhairyasenjaliya
    Contributor
  22. Julesssss commented on Mar 3, 2023

    @Julesssss
    ContributorAuthor

    Ah, I think it was reported first in that linked Github issue. I kinda think that the Slack report is the first official report, as that's where QA will be looking. Though there was only about an hour or two in between.

    What do you think @kevinksullivan

  23. dhairyasenjaliya commented on Mar 3, 2023

    @dhairyasenjaliya
    Contributor

    Hm yeah I see that but if that bug report posted like that on github no external dev or internal dev can see if bug reported or not @Julesssss

  24. situchan commented on Mar 3, 2023

    @situchan
    Contributor

    I thought it was quicker to report on GH which caused regression so that PR author and reviewers know and quickly fix it before going to production. Slack bug reports usually take time for GH to be created, BZ assigned and engineer assigned and find offending PR.
    From next time, I will officially report to slack channel and tag assignees with linked GH.
    I am happy with team's decision.

  25. Julesssss commented on Mar 3, 2023

    @Julesssss
    ContributorAuthor

    Thanks for understanding @situchan. I appreciate the idea behind commenting on the issue, but we'd definitely prefer it to be raised additionally in Slack.

    I re-read our contribution guidelines and I'll try to make this clearer so we don't run into the same problem again.

  26. kevinksullivan commented on Mar 7, 2023

    @kevinksullivan
    Contributor

    Just catching up from OOO, I agree with the approach you proposed @Julesssss . Thanks for updating the documentation as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions