You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out here, a new developer warning message was introduced by this PR. It is not a regression, but should be fixed. I attempted to resolve this myself here, but it appeared to break notifications 😕
We need to correctly import the Push Notification library, making sure that notifications work in all cases:
App open
App backgrounded
App backgrounded with sign out and sign in with different account
App killed
Action Performed:
As a developer, launch the app to an iOS or Android device/simulator
Notice the following warning
Expected Result:
The warning should not show
Actual Result:
The warning shows
Workaround:
This is a developer-only issue, and it isn't a blocker
Platforms:
Which of our officially supported platforms is this issue occurring on?
@Julesssss looks like this is iOS specific, yes? Also, I'm not sure what reproduction steps to take to complete the checklist. Can you help me understand the problem a bit more so I can reproduce? Thanks!
Ah right, sorry I should have used the default template.
You're not going to be able to reproduce this as it's a developer environment issue only. It's occurring on Android and iOS and I'll update the description to make that clearer.
Honestly I'm struggling to see who posted if first. @dhairyasenjaliya I remember you posting in slack, that's why I created the issue, but I can't find the post and date anymore.
Ah, I think it was reported first in that linked Github issue. I kinda think that the Slack report is the first official report, as that's where QA will be looking. Though there was only about an hour or two in between.
I thought it was quicker to report on GH which caused regression so that PR author and reviewers know and quickly fix it before going to production. Slack bug reports usually take time for GH to be created, BZ assigned and engineer assigned and find offending PR.
From next time, I will officially report to slack channel and tag assignees with linked GH.
I am happy with team's decision.
Thanks for understanding @situchan. I appreciate the idea behind commenting on the issue, but we'd definitely prefer it to be raised additionally in Slack.
I re-read our contribution guidelines and I'll try to make this clearer so we don't run into the same problem again.
Activity
melvin-bot commentedon Feb 3, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Feb 3, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kevinksullivan commentedon Feb 3, 2023
@Julesssss looks like this is iOS specific, yes? Also, I'm not sure what reproduction steps to take to complete the checklist. Can you help me understand the problem a bit more so I can reproduce? Thanks!
Julesssss commentedon Feb 6, 2023
Ah right, sorry I should have used the default template.
You're not going to be able to reproduce this as it's a developer environment issue only. It's occurring on Android and iOS and I'll update the description to make that clearer.
34 remaining items
kevinksullivan commentedon Feb 24, 2023
Offer sent @abdulrahuman5196 . Let me know when you accept!
dhairyasenjaliya commentedon Feb 24, 2023
@kevinksullivan also can you invite me for reporting bug
abdulrahuman5196 commentedon Feb 24, 2023
Accepted the offer. @kevinksullivan
kevinksullivan commentedon Feb 25, 2023
Paid @abdulrahuman5196 . Offer sent @dhairyasenjaliya , let me know when you accept
situchan commentedon Feb 25, 2023
I am the first one who reported this regression here
Julesssss commentedon Mar 3, 2023
Sorry @situchan, I missed this. Lets make sure to report bugs in the Slack channel so that QA make the issue and correctly tag you next time.
@kevinksullivan would you mind adding the report payment for @situchan?
dhairyasenjaliya commentedon Mar 3, 2023
Hm if that's valid bug reporting before my posted on slack I would be happy to revert this milestone @Julesssss
Julesssss commentedon Mar 3, 2023
Honestly I'm struggling to see who posted if first. @dhairyasenjaliya I remember you posting in slack, that's why I created the issue, but I can't find the post and date anymore.
dhairyasenjaliya commentedon Mar 3, 2023
@Julesssss i think here i reported on slack https://expensify.slack.com/archives/C01GTK53T8Q/p1675186823689109?thread_ts=1675186823.689109&cid=C01GTK53T8Q
@situchan can you post your slack bug reporting link
Julesssss commentedon Mar 3, 2023
Ah, I think it was reported first in that linked Github issue. I kinda think that the Slack report is the first official report, as that's where QA will be looking. Though there was only about an hour or two in between.
What do you think @kevinksullivan
dhairyasenjaliya commentedon Mar 3, 2023
Hm yeah I see that but if that bug report posted like that on github no external dev or internal dev can see if bug reported or not @Julesssss
situchan commentedon Mar 3, 2023
I thought it was quicker to report on GH which caused regression so that PR author and reviewers know and quickly fix it before going to production. Slack bug reports usually take time for GH to be created, BZ assigned and engineer assigned and find offending PR.
From next time, I will officially report to slack channel and tag assignees with linked GH.
I am happy with team's decision.
Julesssss commentedon Mar 3, 2023
Thanks for understanding @situchan. I appreciate the idea behind commenting on the issue, but we'd definitely prefer it to be raised additionally in Slack.
I re-read our contribution guidelines and I'll try to make this clearer so we don't run into the same problem again.
kevinksullivan commentedon Mar 7, 2023
Just catching up from OOO, I agree with the approach you proposed @Julesssss . Thanks for updating the documentation as well!