Skip to content

[HOLD for payment 2023-03-14] Mac Safari - Chat - clicking arrow up in composer box does not edit the last sent message #14893

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Sign in
  3. Go to any chat (Last message in the chat must be text or write it)
  4. Focus on the compose box
  5. Press up arrow

Expected Result:

The last message sent should be editable.

Actual Result:

The message activated to edit is not the last one sent

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.66.0

Reproducible in staging?: yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5927405_Recording__283.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018e014c78eca67ab9
  • Upwork Job ID: 1637867588777328640
  • Last Price Increase: 2023-03-20

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 7, 2023
  2. locked and limited conversation to collaborators on Feb 7, 2023
  3. MelvinBot commented on Feb 7, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Feb 7, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. self-assigned this
    on Feb 10, 2023
  6. changed the title [-]Web - Chat - "Edit message" function can be activated with the up arrow[/-] [+]Mac Safari - Chat - clicking arrow up in composer box does not edit the last sent message[/+] on Feb 10, 2023
  7. mountiny commented on Feb 10, 2023

    @mountiny
    Contributor

    I can reporduce this only on mac safari, not in chrome

    @kbecciv Please not that clicking arrow up and edit last the message is expected behaviour that itself is not a bug. The issue here is that its not the last message sent which is being edited.

  8. unlocked this conversation on Feb 10, 2023
  9. gedu commented on Feb 10, 2023

    @gedu
    Contributor

    Hey, I'm Eduardo from Callstack, can I take this one?

  10. 31 remaining items

  11. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 20, 2023
  12. MelvinBot commented on Mar 20, 2023

    @MelvinBot
    Contributor
  13. MelvinBot commented on Mar 20, 2023

    @MelvinBot
    Contributor

    Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

  14. mallenexpensify commented on Mar 20, 2023

    @mallenexpensify
    Contributor

    @0xmiroslav , can you please accept the job and reply here once you have?
    Will you also let me know if this link doesn't work, ie. show you the job? Thx
    https://www.upwork.com/jobs/~018e014c78eca67ab9

  15. 0xmiroslav commented on Mar 20, 2023

    @0xmiroslav
    Contributor

    @mallenexpensify accepted!
    That job link opens but it says "This job is no longer available.". Maybe because I already accepted offer before checking.

  16. mallenexpensify commented on Mar 20, 2023

    @mallenexpensify
    Contributor

    Paid! @0xmiroslav can you confirm the feedback I left was positive? There's a weird glitch in Upwork now where it's auto-filling not-positive selections. I doubled checked on our end and it looks good, I've raised the issue with Upwork too.

  17. 0xmiroslav commented on Mar 20, 2023

    @0xmiroslav
    Contributor

    @mallenexpensify thanks. I have no permission to private feedback but public feedback looks great!

  18. mallenexpensify commented on Mar 20, 2023

    @mallenexpensify
    Contributor

    Thanks, I'm double checking with Upwork to ensure nothing negative is left, I know how important that is for contributors in Upwork

  19. mountiny commented on Mar 21, 2023

    @mountiny
    Contributor

    @0xmiroslav is this paid?

  20. 0xmiroslav commented on Mar 21, 2023

    @0xmiroslav
    Contributor

    @0xmiroslav is this paid?

    yes, yesterday thanks to @mallenexpensify

  21. mountiny commented on Mar 21, 2023

    @mountiny
    Contributor

    So I am going to close this, it was not strictly a regression from some PR, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions