Skip to content

[HOLD for payment 2023-02-28] Navigating directly to the /details, /settings, or /participants URL for a chat doesn't open that corresponding page in the RHN #14994

Closed

Description

@marcochavezf

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. In a group chat (i.e. #admins), click on the group chat avatar at the top of the page to open /details in the RHN
  2. Refresh the browser with the same /details URL
  3. Dismiss the system message asking to open the desktop app and click the link to open in browser

Expected Result:

The chat should load with /details open in the RHN. If /settings or /participants is in the URL instead of details, then that corresponding page should show in the RHN.

Actual Result:

The main chat screen loads without the RHN.

Workaround:

Navigate manually to the sub-report page.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.2.68-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675965524563069

View all open jobs on GitHub

NewDot Details Page

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 9, 2023
  2. self-assigned this
    on Feb 9, 2023
  3. locked and limited conversation to collaborators on Feb 9, 2023
  4. MelvinBot commented on Feb 9, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. MelvinBot commented on Feb 9, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. marcochavezf commented on Feb 9, 2023

    @marcochavezf
    ContributorAuthor

    PR to fix the sub-report route issue

  7. changed the title [-]Fix deep link for sub-report pages[/-] [+]Navigating directly to the /details, /settings, or /participants URL for a chat doesn't open that corresponding page in the RHN[/+] on Feb 9, 2023
  8. marcochavezf commented on Feb 9, 2023

    @marcochavezf
    ContributorAuthor

    Updated the title and steps to match with the steps reported in the attached slack thread.

  9. MelvinBot commented on Feb 16, 2023

    @MelvinBot
    Contributor

    @davidcardoza, @marcochavezf Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. marcochavezf commented on Feb 17, 2023

    @marcochavezf
    ContributorAuthor

    #14995 was merged yesterday.

  11. mallenexpensify commented on Feb 17, 2023

    @mallenexpensify
    Contributor

    @marcochavezf is @mollfpr due compensation on THIS issue for the C+ PR review you linked above?

  12. marcochavezf commented on Feb 20, 2023

    @marcochavezf
    ContributorAuthor

    @marcochavezf is @mollfpr due compensation on THIS issue for the C+ PR review you linked above?

    Yup, that's correct, @mollfpr reviewed the PR I created that fixes this issue.

  13. 11 remaining items

  14. MelvinBot commented on Mar 2, 2023

    @MelvinBot
    Contributor

    @davidcardoza, @marcochavezf Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. mollfpr commented on Mar 3, 2023

    @mollfpr
    Contributor

    Bump @davidcardoza for issuing the payment.

  16. davidcardoza commented on Mar 3, 2023

    @davidcardoza
    Contributor

    Offer sent.

  17. mollfpr commented on Mar 4, 2023

    @mollfpr
    Contributor

    @davidcardoza accepted, thank you!

  18. 0xmiroslav commented on Mar 7, 2023

    @0xmiroslav
    Contributor

    I think I am eligible for reporting compensation here.
    cc: @marcochavezf

  19. davidcardoza commented on Mar 7, 2023

    @davidcardoza
    Contributor
  20. 0xmiroslav commented on Mar 8, 2023

    @0xmiroslav
    Contributor

    @0xmiroslav Sent

    @davidcardoza Accepted, thanks!

  21. 0xmiroslav commented on Mar 20, 2023

    @0xmiroslav
    Contributor

    @davidcardoza friendly bump!

  22. davidcardoza commented on Mar 21, 2023

    @davidcardoza
    Contributor

    Payment sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions