Skip to content

[$1000] [HOLD for payment 2023-04-07] Show all Expensify logins in "Contact methods" page, add "Contact details" page, allow "Resend validation" logic #15203

Closed

Description

@Beamanator

Part of the bigger "Account Settings" project - https://github.com/Expensify/Expensify/issues/182122

This is part 2 of our plan, where we're breaking the process into 4 steps (see tracking issue ^)

Goals for this issue:

  • Show entire list of user's contact methods (secondary logins) for Expensify in the "Contact methods" page.
  • When user clicks on any contact method, open a new page for contact method details
    • For now, show "Send validation" button on that page when contact method isn't validated
    • Show "Remove" button as well, if the contact method isn't the user's "Default" / "Primary" contact method
    • Hook up API commands for both of the above
  • If user doesn't have a phone number login, render LoginField only for phone number type (and vice versa) so user has the ability to add at least 1 login of both types.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012fce8a7330e675e7
  • Upwork Job ID: 1626161188767211520
  • Last Price Increase: 2023-04-10

Activity

  1. self-assigned this
    on Feb 16, 2023
  2. locked and limited conversation to collaborators on Feb 16, 2023
  3. MelvinBot commented on Feb 16, 2023

    @MelvinBot
    Contributor
  4. MelvinBot commented on Feb 16, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

  5. unlocked this conversation on Feb 16, 2023
  6. MelvinBot commented on Feb 16, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

  7. Beamanator commented on Feb 16, 2023

    @Beamanator
    ContributorAuthor

    @shawnborton tagging you because I'd love if you could check this design once it's closer to being merged - also are you able to provide a SVG asset of the mail-icon icon from https://www.expensify.com/styleguide/components.php#icons?

    I need this icon for the 'Resend Verification" button, and I don't believe we have it in App yet - and in Olddot we use some kind of glyph thing for that icon

  8. shawnborton commented on Feb 16, 2023

    @shawnborton
    Contributor

    Just wanted to check - is it the icon here from your Slack post that you need?

    image

  9. 51 remaining items

  10. parasharrajat commented on Apr 11, 2023

    @parasharrajat
    Member

    I think 2K-3K whatever you think is aligned with my argument.

  11. MitchExpensify commented on Apr 11, 2023

    @MitchExpensify
    Contributor

    Cool I think given you reviewed two PRs that 2k seems fair. Seeing as @mollfpr reviewed one PR, 1K seems fair.

  12. MelvinBot commented on Apr 17, 2023

    @MelvinBot
    Contributor

    @shawnborton, @Beamanator, @mollfpr, @MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

  13. Beamanator commented on Apr 17, 2023

    @Beamanator
    ContributorAuthor

    Bump @MitchExpensify , mind paying this out soon? 🙏 👍

  14. MitchExpensify commented on Apr 17, 2023

    @MitchExpensify
    Contributor

    Sorry about that! Not sure how it slipped by me and thanks for the bump @Beamanator

    I had to create a new Upwork job which I've invited you both for payment to @parasharrajat & @mollfpr

    Will issue payment based on this once you both accept the offer on the new job :)

  15. parasharrajat commented on Apr 17, 2023

    @parasharrajat
    Member

    @MitchExpensify can you please update the offer for me? it is supposed to be 2K.

  16. MitchExpensify commented on Apr 17, 2023

    @MitchExpensify
    Contributor

    I'm aware @parasharrajat, just planned on including it as a bonus

  17. MitchExpensify commented on Apr 17, 2023

    @MitchExpensify
    Contributor

    Paid @mollfpr and contract ended 👍

  18. MitchExpensify commented on Apr 17, 2023

    @MitchExpensify
    Contributor

    Paid @parasharrajat and contract ended

    We good to close @Beamanator ?

  19. MitchExpensify commented on Apr 20, 2023

    @MitchExpensify
    Contributor

    Closing, we can reopen if @Beamanator disagrees :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignEngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions