You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] [HOLD for payment 2023-04-07] Show all Expensify logins in "Contact methods" page, add "Contact details" page, allow "Resend validation" logic #15203
This is part 2 of our plan, where we're breaking the process into 4 steps (see tracking issue ^)
Goals for this issue:
Show entire list of user's contact methods (secondary logins) for Expensify in the "Contact methods" page.
When user clicks on any contact method, open a new page for contact method details
For now, show "Send validation" button on that page when contact method isn't validated
Show "Remove" button as well, if the contact method isn't the user's "Default" / "Primary" contact method
Hook up API commands for both of the above
If user doesn't have a phone number login, render LoginField only for phone number type (and vice versa) so user has the ability to add at least 1 login of both types.
I need this icon for the 'Resend Verification" button, and I don't believe we have it in App yet - and in Olddot we use some kind of glyph thing for that icon
Activity
MelvinBot commentedon Feb 16, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012fce8a7330e675e7
MelvinBot commentedon Feb 16, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (
Internal)MelvinBot commentedon Feb 16, 2023
Triggered auto assignment to @shawnborton (
Design), see these Stack Overflow questions for more details.Beamanator commentedon Feb 16, 2023
@shawnborton tagging you because I'd love if you could check this design once it's closer to being merged - also are you able to provide a SVG asset of the
mail-iconicon from https://www.expensify.com/styleguide/components.php#icons?I need this icon for the 'Resend Verification" button, and I don't believe we have it in App yet - and in Olddot we use some kind of
glyphthing for that iconshawnborton commentedon Feb 16, 2023
Just wanted to check - is it the icon here from your Slack post that you need?
51 remaining items
parasharrajat commentedon Apr 11, 2023
I think 2K-3K whatever you think is aligned with my argument.
MitchExpensify commentedon Apr 11, 2023
Cool I think given you reviewed two PRs that 2k seems fair. Seeing as @mollfpr reviewed one PR, 1K seems fair.
MelvinBot commentedon Apr 17, 2023
@shawnborton, @Beamanator, @mollfpr, @MitchExpensify Huh... This is 4 days overdue. Who can take care of this?
Beamanator commentedon Apr 17, 2023
Bump @MitchExpensify , mind paying this out soon? 🙏 👍
MitchExpensify commentedon Apr 17, 2023
Sorry about that! Not sure how it slipped by me and thanks for the bump @Beamanator
I had to create a new Upwork job which I've invited you both for payment to @parasharrajat & @mollfpr
Will issue payment based on this once you both accept the offer on the new job :)
parasharrajat commentedon Apr 17, 2023
@MitchExpensify can you please update the offer for me? it is supposed to be 2K.
MitchExpensify commentedon Apr 17, 2023
I'm aware @parasharrajat, just planned on including it as a bonus
MitchExpensify commentedon Apr 17, 2023
Paid @mollfpr and contract ended 👍
MitchExpensify commentedon Apr 17, 2023
Paid @parasharrajat and contract ended
We good to close @Beamanator ?
MitchExpensify commentedon Apr 20, 2023
Closing, we can reopen if @Beamanator disagrees :)