You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-14] Background illustration covers avatars and texts in chat room #15237
Hi 👋
I got assigned the below which I think might be related to this. @madmax330 can you take a look and let me know if you agree? If not I'll move forward with the other independently. Thx
changed the title [-]Background illustration covers avatars and texts in chat room[/-][+][HOLD for payment 2023-03-14] Background illustration covers avatars and texts in chat room[/+]on Mar 7, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.79-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-14. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif / @hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif / @hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Christinadobrzyn] Determine if we should create a regression test for the bug.
Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Activity
MelvinBot commentedon Feb 17, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Feb 17, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Christinadobrzyn commentedon Feb 17, 2023
MelvinBot commentedon Feb 17, 2023
Triggered auto assignment to @madmax330 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mallenexpensify commentedon Feb 17, 2023
Hi 👋
I got assigned the below which I think might be related to this. @madmax330 can you take a look and let me know if you agree? If not I'll move forward with the other independently. Thx
madmax330 commentedon Feb 20, 2023
Yeah I think it's the same issue
JmillsExpensify commentedon Feb 20, 2023
Looks like we can close this one as a duplicate then.
22 remaining items
dhanashree-sawant commentedon Mar 3, 2023
Hi @MariaHCD, @Christinadobrzyn if the issue is solved and deployed, can you approve the milestone on upwork?
MariaHCD commentedon Mar 3, 2023
Re-opening the issue since it looks like we still need to issue the payments for this. Leaving to @Christinadobrzyn to handle the next steps! 🙌🏼
Christinadobrzyn commentedon Mar 7, 2023
paid @aimane-chnaif & @dhanashree-sawant in Upwork and closed the job in Upwork. Closing this GH!
[-]Background illustration covers avatars and texts in chat room[/-][+][HOLD for payment 2023-03-14] Background illustration covers avatars and texts in chat room[/+]MelvinBot commentedon Mar 7, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 7, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.79-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-14. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Mar 7, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
MelvinBot commentedon Mar 7, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.