Skip to content

[HOLD for payment 2023-03-14] Background illustration covers avatars and texts in chat room #15237

Closed

Description

@hayata-suenaga

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Mobile:

  1. Open https://new.expensify.com on iOS Safari/Android Chrome Safari
  2. Plus button -> New chat -> choose a person you haven't chatted yet to create a new chat room
  3. Zoom in and zoom out
  4. Check the avatar is covered by an illustration when the chat room is zoomed out
RPReplay_Final1676603875.MOV

Desktop:

  1. Open https://new.expensify.com on Safari MacOS
  2. Plus button -> New chat -> choose a person you haven't chatted yet to create a new chat room
  3. Check the avatars and some texts are covered by background illustration

Screenshot 2023-02-16 at 6 36 50 PM

Expected Result:

Background illustration should be behind the avatars and tests

Actual Result:

Avatars and some texts are covered by background illustration

Workaround:

Users can still user Expensify, but the issue is quite noticeable

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari ONLY ON Safari
  • MacOS / Desktop

Version Number: v1.2.72-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @hayata-suenaga and @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675330177865839

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013f02c6225cbf7e63
  • Upwork Job ID: 1628072754773405696
  • Last Price Increase: 2023-02-21

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 17, 2023
  2. locked and limited conversation to collaborators on Feb 17, 2023
  3. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. Christinadobrzyn commented on Feb 17, 2023

    @Christinadobrzyn
    Contributor
  6. MelvinBot commented on Feb 17, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. mallenexpensify commented on Feb 17, 2023

    @mallenexpensify
    Contributor

    Hi 👋
    I got assigned the below which I think might be related to this. @madmax330 can you take a look and let me know if you agree? If not I'll move forward with the other independently. Thx

  8. madmax330 commented on Feb 20, 2023

    @madmax330
    Contributor

    Yeah I think it's the same issue

  9. JmillsExpensify commented on Feb 20, 2023

    @JmillsExpensify
    Contributor

    Looks like we can close this one as a duplicate then.

  10. 22 remaining items

  11. dhanashree-sawant commented on Mar 3, 2023

    @dhanashree-sawant

    Hi @MariaHCD, @Christinadobrzyn if the issue is solved and deployed, can you approve the milestone on upwork?

  12. MariaHCD commented on Mar 3, 2023

    @MariaHCD
    Contributor

    Re-opening the issue since it looks like we still need to issue the payments for this. Leaving to @Christinadobrzyn to handle the next steps! 🙌🏼

  13. Christinadobrzyn commented on Mar 7, 2023

    @Christinadobrzyn
    Contributor

    paid @aimane-chnaif & @dhanashree-sawant in Upwork and closed the job in Upwork. Closing this GH!

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 7, 2023
  15. changed the title [-]Background illustration covers avatars and texts in chat room[/-] [+][HOLD for payment 2023-03-14] Background illustration covers avatars and texts in chat room[/+] on Mar 7, 2023
  16. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.79-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-03-14. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  18. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif / @hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif / @hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif / @hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Christinadobrzyn] Determine if we should create a regression test for the bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Review the proposed regression test steps and location.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    Looks like something related to react-navigation may have been mentioned in this issue discussion.

    As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

    Feel free to drop a note in #expensify-open-source with any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions