Skip to content

Investigate the cause of the Performance Regression for 'Open Search Page TTI' #15622

Closed

Description

@yuwenmemon

Recently, we've seen a slew of Performance Regressions getting red-flagged for the 'Open Search Page TTI' flow.

We first saw the uptick in time occur somewhere around the merging of these PRs:

We tried reverting Fix miss-matched SMS email suffix on sign in page #15351 (PR) to no avail. And we DID revert replace onModalHide with onDismiss for the web #15298. Again no help.

So now we're very confused about where this regression is coming from. @roryabraham has graciously created the ability to run the E2E tests on a specific branch a la carte. So we're going to try and use that to simulate git bisect essentially to figure out the offending PR / commit.

In the meantime we've decided to not block the deploy on this. However, to close this issue we should be getting the Open Search Page TTI back to around ~600ms. Currently it's regressed to ~660-700ms

cc @Expensify/mobile-deployers

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 2, 2023
  2. self-assigned this
    on Mar 2, 2023
  3. locked and limited conversation to collaborators on Mar 2, 2023
  4. MelvinBot commented on Mar 2, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. MelvinBot commented on Mar 2, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 2, 2023
  7. johncschuster commented on Mar 2, 2023

    @johncschuster
    Contributor

    Hehe, I was just going to ask about the Bug label in relation to Bug0. I'll go ahead and triage this out.

  8. MelvinBot commented on Mar 2, 2023

    @MelvinBot
    Contributor

    Current assignee @yuwenmemon is eligible for the Engineering assigner, not assigning anyone new.

  9. mountiny commented on Mar 2, 2023

    @mountiny
    Contributor

    Margelo will try to help here as they initially helped to set this feature up https://expensify.slack.com/archives/C035J5C9FAP/p1677746998910309

  10. johncschuster commented on Mar 2, 2023

    @johncschuster
    Contributor

    👍

  11. removed their assignment
    on Mar 2, 2023
  12. 48 remaining items

  13. melvin-bot commented on May 16, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 16, 2023

    @melvin-bot
  15. luacmartins commented on May 25, 2023

    @luacmartins
    Contributor

    What's the next step here @hannojg?

  16. changed the title [-][HOLD for payment 2023-05-23] Investigate the cause of the Performance Regression for 'Open Search Page TTI'[/-] [+]Investigate the cause of the Performance Regression for 'Open Search Page TTI'[/+] on May 25, 2023
  17. luacmartins commented on May 29, 2023

    @luacmartins
    Contributor

    Still waiting for an update from @hannojg

  18. hannojg commented on May 31, 2023

    @hannojg
    Contributor

    @luacmartins The GitHub action is fixed and working again. I'd say the next step is to see if another false-positive would happen again, and then in that case to investigate it properly.
    However, so far, all the tests seem to run smoothly.

  19. luacmartins commented on May 31, 2023

    @luacmartins
    Contributor

    Sounds good. I'll close this issue then and reopen if we come across another false positive. Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions