You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Have the Performance Regression Test Reopen the Associated Issue for a PR #15628
Currently, when the Performance Regression Test catches a performance regression, it applies the DeployBlockerCash label to the PR itself, which has already been merged. This causes it to not really get much attention from the reviewer, and even worse, allows this deploy blocker to go unnoticed by whoever is deploying the app.
Solution
Instead of having the regression apply the DeployBlockerCash label to an already closed PR, let's have it do two things:
Reopen the issue that is linked to the PR
Apply the DeployBlockerCash label to that
This will cause the issue to immediately be detected by the deploy checklist as well as trigger other notifications to make everyone aware of the performance regression right away.
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
MelvinBot commentedon Mar 3, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 3, 2023
thienlnam commentedon Mar 6, 2023
I was originally thinking it would be easy to add this as part of our internal webhook (open the linked PR and add a label to it) but since this is a GH action maybe we should just do it all within that? https://github.com/Expensify/App/blob/main/.github/workflows/e2ePerformanceTests.yml
luacmartins commentedon Mar 6, 2023
Yea, I think that we should do that as part of the action so we don't split the logic.
MelvinBot commentedon Mar 29, 2023
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Jun 12, 2023
@yuwenmemon, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.