Skip to content

Have the Performance Regression Test Reopen the Associated Issue for a PR #15628

Closed

Description

@yuwenmemon

Problem

Currently, when the Performance Regression Test catches a performance regression, it applies the DeployBlockerCash label to the PR itself, which has already been merged. This causes it to not really get much attention from the reviewer, and even worse, allows this deploy blocker to go unnoticed by whoever is deploying the app.

Screenshot 2023-03-02 at 4 17 33 PM

Solution

Instead of having the regression apply the DeployBlockerCash label to an already closed PR, let's have it do two things:

  1. Reopen the issue that is linked to the PR
  2. Apply the DeployBlockerCash label to that

This will cause the issue to immediately be detected by the deploy checklist as well as trigger other notifications to make everyone aware of the performance regression right away.

cc @AndrewGable @hannojg @Expensify/mobile-deployers

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 3, 2023
  2. MelvinBot commented on Mar 3, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Mar 3, 2023
  4. MelvinBot commented on Mar 3, 2023

    @MelvinBot
  5. added and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 3, 2023
  6. unlocked this conversation on Mar 3, 2023
  7. self-assigned this
    on Mar 3, 2023
  8. thienlnam commented on Mar 6, 2023

    @thienlnam
    Contributor

    I was originally thinking it would be easy to add this as part of our internal webhook (open the linked PR and add a label to it) but since this is a GH action maybe we should just do it all within that? https://github.com/Expensify/App/blob/main/.github/workflows/e2ePerformanceTests.yml

  9. removed their assignment
    on Mar 6, 2023
  10. luacmartins commented on Mar 6, 2023

    @luacmartins
    Contributor

    Yea, I think that we should do that as part of the action so we don't split the logic.

  11. MelvinBot commented on Mar 29, 2023

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. melvin-bot commented on Jun 12, 2023

    @melvin-bot

    @yuwenmemon, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions