Skip to content

[HOLD for payment 2023-03-16] Locale Picker Background is incorrect on windows (DEV) #15676

Closed

Description

@grgia

The Locale Picker Background should match app background on windows. This is occurring on DEV only awaiting staging release.

https://expensify.slack.com/archives/C049HHMV9SM/p1678032527107149

Reported by @situchan

image

This is ONLY on windows web.
Not MacOS/Android/IOS

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01806153de5b609fd1
  • Upwork Job ID: 1632693916961329152
  • Last Price Increase: 2023-03-06

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 6, 2023
  2. self-assigned this
    on Mar 6, 2023
  3. locked and limited conversation to collaborators on Mar 6, 2023
  4. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor
  5. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

  8. unlocked this conversation on Mar 6, 2023
  9. situchan commented on Mar 6, 2023

    @situchan
    Contributor

    In this issue, I also suggest to remove border radius in order to fix #15653, which was added very long time ago. cc: @tjferriss

    borderRadius: variables.componentBorderRadius,

    borderRadius: variables.componentBorderRadius,

    borderRadius: variables.componentBorderRadius,

  10. 31 remaining items

  11. joekaufmanexpensify commented on Mar 17, 2023

    @joekaufmanexpensify
    Contributor

    Thanks! Okay, all that's left here before we can issue payment and close this out is for @grgia to complete the BZ steps related to the PR that introduced the regression.

  12. joekaufmanexpensify commented on Mar 20, 2023

    @joekaufmanexpensify
    Contributor

    Not overdue.

  13. joekaufmanexpensify commented on Mar 21, 2023

    @joekaufmanexpensify
    Contributor

    @grgia bump for whenever you have a chance to complete the engineering BZ steps here! That's the last step before we can pay the reporting bonus here and close this out.

  14. grgia commented on Mar 22, 2023

    @grgia
    ContributorAuthor

    @joekaufmanexpensify thanks for the bump, I'll get this closed today

  15. joekaufmanexpensify commented on Mar 22, 2023

    @joekaufmanexpensify
    Contributor

    Of course, and great, ty!

  16. reopened this on Mar 23, 2023
  17. grgia commented on Mar 23, 2023

    @grgia
    ContributorAuthor
  18. joekaufmanexpensify commented on Mar 23, 2023

    @joekaufmanexpensify
    Contributor

    Great, thanks Georgia!

  19. joekaufmanexpensify commented on Mar 23, 2023

    @joekaufmanexpensify
    Contributor

    @situchan $250 sent and job closed!

  20. joekaufmanexpensify commented on Mar 23, 2023

    @joekaufmanexpensify
    Contributor

    Closed upwork job.

  21. joekaufmanexpensify commented on Mar 23, 2023

    @joekaufmanexpensify
    Contributor

    Okay, bug is fixed, BZ checklist is complete, and payment is issued. Closing as this is all set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions