Skip to content

[HOLD for payment 2023-03-31] Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging #15694

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #15022

Action Performed:

  1. Open the App
  2. Click on Get Started links

Expected Result:

Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging

Actual Result:

Unknown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.79.0

Reproducible in staging?: Yes

Reproducible in production?: a new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5966541_RPReplay_Final1678127715__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause 0 Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 6, 2023
  2. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Mar 6, 2023
  4. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. self-assigned this
    on Mar 7, 2023
  6. JmillsExpensify commented on Mar 8, 2023

    @JmillsExpensify
    Contributor

    @luacmartins I don't totally understand this issue as written but it sounds like you're on it?

  7. luacmartins commented on Mar 8, 2023

    @luacmartins
    Contributor

    Yep, I have a PR in review here

  8. luacmartins commented on Mar 8, 2023

    @luacmartins
    Contributor

    The issue is that the footer links are always directing the user to production no matter which environment the user is in. However, we'd expect the user to be navigated to staging if they are on staging.

  9. MelvinBot commented on Mar 15, 2023

    @MelvinBot
    Contributor

    @JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. MelvinBot commented on Mar 17, 2023

    @MelvinBot
    Contributor

    @JmillsExpensify, @luacmartins Huh... This is 4 days overdue. Who can take care of this?

  11. luacmartins commented on Mar 21, 2023

    @luacmartins
    Contributor

    PR was merged and deployed to staging today!

  12. unlocked this conversation on Mar 21, 2023
  13. 2 remaining items

  14. changed the title [-]Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging[/-] [+][HOLD for payment 2023-03-31] Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging[/+] on Mar 24, 2023
  15. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-03-31. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  17. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: N/A this is a new feature
    • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A this is a new feature
    • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this is a new feature
    • [@JmillsExpensify] Determine if we should create a regression test for this bug.
    • [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. JmillsExpensify commented on Mar 27, 2023

    @JmillsExpensify
    Contributor

    Looks like @Santhosh-Sellavel reviewed the linked PR. Assigning him to this issue as well for payment.

  19. JmillsExpensify commented on Mar 27, 2023

    @JmillsExpensify
    Contributor

    @luacmartins Anything else on the checklist relevant?

  20. luacmartins commented on Mar 27, 2023

    @luacmartins
    Contributor

    @JmillsExpensify no, this is a new feature and seemed to be intentionally directing to the web staging App. We changed the behavior to always open the platform and environment that you are currently on.

  21. luacmartins commented on Mar 27, 2023

    @luacmartins
    Contributor

    I completed the checklist

  22. JmillsExpensify commented on Mar 27, 2023

    @JmillsExpensify
    Contributor

    Upwork job is here: https://www.upwork.com/jobs/~01369309ec4dba5a84. Extended a contract to @Santhosh-Sellavel for the job.

  23. Santhosh-Sellavel commented on Mar 27, 2023

    @Santhosh-Sellavel
    Collaborator

    Accepted, thanks @JmillsExpensify

  24. JmillsExpensify commented on Mar 28, 2023

    @JmillsExpensify
    Contributor

    Great, you're all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions