You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-31] Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging #15694
The issue is that the footer links are always directing the user to production no matter which environment the user is in. However, we'd expect the user to be navigated to staging if they are on staging.
changed the title [-]Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging[/-][+][HOLD for payment 2023-03-31] Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging[/+]on Mar 24, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-31. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins] The PR that introduced the bug has been identified. Link to the PR: N/A this is a new feature
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A this is a new feature
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this is a new feature
[@JmillsExpensify] Determine if we should create a regression test for this bug.
[@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@JmillsExpensify no, this is a new feature and seemed to be intentionally directing to the web staging App. We changed the behavior to always open the platform and environment that you are currently on.
Activity
MelvinBot commentedon Mar 6, 2023
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)JmillsExpensify commentedon Mar 8, 2023
@luacmartins I don't totally understand this issue as written but it sounds like you're on it?
luacmartins commentedon Mar 8, 2023
Yep, I have a PR in review here
luacmartins commentedon Mar 8, 2023
The issue is that the footer links are always directing the user to production no matter which environment the user is in. However, we'd expect the user to be navigated to staging if they are on staging.
MelvinBot commentedon Mar 15, 2023
@JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
MelvinBot commentedon Mar 17, 2023
@JmillsExpensify, @luacmartins Huh... This is 4 days overdue. Who can take care of this?
luacmartins commentedon Mar 21, 2023
PR was merged and deployed to staging today!
2 remaining items
[-]Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging[/-][+][HOLD for payment 2023-03-31] Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging[/+]MelvinBot commentedon Mar 24, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 24, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-31. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Mar 24, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
JmillsExpensify commentedon Mar 27, 2023
Looks like @Santhosh-Sellavel reviewed the linked PR. Assigning him to this issue as well for payment.
JmillsExpensify commentedon Mar 27, 2023
@luacmartins Anything else on the checklist relevant?
luacmartins commentedon Mar 27, 2023
@JmillsExpensify no, this is a new feature and seemed to be intentionally directing to the web staging App. We changed the behavior to always open the platform and environment that you are currently on.
luacmartins commentedon Mar 27, 2023
I completed the checklist
JmillsExpensify commentedon Mar 27, 2023
Upwork job is here: https://www.upwork.com/jobs/~01369309ec4dba5a84. Extended a contract to @Santhosh-Sellavel for the job.
Santhosh-Sellavel commentedon Mar 27, 2023
Accepted, thanks @JmillsExpensify
JmillsExpensify commentedon Mar 28, 2023
Great, you're all set!