You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Sign-In Page - No link to the ‘Terms of Service’ in the new footer of the Sign-In page #15703
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Activity
kbecciv commentedon Mar 7, 2023
Related PR #15022
OSBotify commentedon Mar 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Mar 7, 2023
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.robertjchen commentedon Mar 7, 2023
Looking into this 👀
robertjchen commentedon Mar 7, 2023
hrm, I might have to defer to @grgia on this one.
I think we might need to re-create a dedicated component for the footer of the sign-in page since the old one got removed: https://github.com/Expensify/App/pull/15420/files#diff-dd48053a4b4ca8a948af29c248e8fee97c8d962017338228d8bec523842df230L69-L71
and adding back
<Terms />doesn't seem to yield a visually consistent result 😭roryabraham commentedon Mar 7, 2023
Since this is a deploy blocker, we should consider reverting the PR and trying again if the fix isn't going to be a quick one.
MonilBhavsar commentedon Mar 7, 2023
I can take a look, since I was a reviewer. Sorry for this
MonilBhavsar commentedon Mar 7, 2023
Looks like we missed this text during the PR. I have pushed a fix #15706
grgia commentedon Mar 7, 2023
This change was intentional cc @coleaeason @shawnborton
The login terms will be visible on the next login page
And then the remaining licenses are in the footer:
grgia commentedon Mar 7, 2023
See this comment for a breakdown on the login terms visibility on mobile: #15022 (comment)
grgia commentedon Mar 7, 2023
This change was approved when it was made, so I'll close this as NAB and close @MonilBhavsar's fix since it's not necessary.
shawnborton commentedon Mar 7, 2023
Yup, and there should be a link for privacy policy in the footer already too:
