Skip to content

Sign-In Page - No link to the ‘Terms of Service’ in the new footer of the Sign-In page #15703

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to the sign-in page
  2. Tap or click on the email input on the sign-in form to give it focus
  3. Verify the keyboard comes up
  4. mWeb - Verify the page can be scrolled to view the Terms of Service link

Expected Result:

There is a link to the ‘Terms of Service’ in the footer of the sign-in page

Actual Result:

No link to the ‘Terms of Service’ in the new footer of the Sign-In page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.79.0

Reproducible in staging?: Yes

Reproducible in production?: NO

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5966738_new-page-footer.mp4

terms

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. locked and limited conversation to collaborators on Mar 7, 2023
  2. kbecciv commented on Mar 7, 2023

    @kbecciv
    Author

    Related PR #15022

  3. OSBotify commented on Mar 7, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. robertjchen commented on Mar 7, 2023

    @robertjchen
    Contributor

    Looking into this 👀

  6. robertjchen commented on Mar 7, 2023

    @robertjchen
    Contributor

    hrm, I might have to defer to @grgia on this one.

    I think we might need to re-create a dedicated component for the footer of the sign-in page since the old one got removed: https://github.com/Expensify/App/pull/15420/files#diff-dd48053a4b4ca8a948af29c248e8fee97c8d962017338228d8bec523842df230L69-L71

    and adding back <Terms /> doesn't seem to yield a visually consistent result 😭

    Screenshot 2023-03-07 at 3 16 10 PM

  7. roryabraham commented on Mar 7, 2023

    @roryabraham
    Contributor

    Since this is a deploy blocker, we should consider reverting the PR and trying again if the fix isn't going to be a quick one.

  8. self-assigned this
    on Mar 7, 2023
  9. MonilBhavsar commented on Mar 7, 2023

    @MonilBhavsar
    Contributor

    I can take a look, since I was a reviewer. Sorry for this

  10. MonilBhavsar commented on Mar 7, 2023

    @MonilBhavsar
    Contributor

    Looks like we missed this text during the PR. I have pushed a fix #15706

  11. grgia commented on Mar 7, 2023

    @grgia
    Contributor

    This change was intentional cc @coleaeason @shawnborton

    The login terms will be visible on the next login page

    image

    And then the remaining licenses are in the footer:

    image

  12. grgia commented on Mar 7, 2023

    @grgia
    Contributor

    See this comment for a breakdown on the login terms visibility on mobile: #15022 (comment)

  13. grgia commented on Mar 7, 2023

    @grgia
    Contributor

    This change was approved when it was made, so I'll close this as NAB and close @MonilBhavsar's fix since it's not necessary.

  14. shawnborton commented on Mar 7, 2023

    @shawnborton
    Contributor

    Yup, and there should be a link for privacy policy in the footer already too:
    image

  15. unlocked this conversation on Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions