You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-03] WEB - Chat - Draft text is not cleared but the compose box is still focused #15724
I see. This is related to the PR linked in the OP. Seems like the debounce we have on the composer box is putting the text back in it. I can take a look at this.
changed the title [-]WEB - Chat - Draft text is not cleared but the compose box is still focused[/-][+][HOLD for payment 2023-04-03] WEB - Chat - Draft text is not cleared but the compose box is still focused[/+]on Mar 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR @mollfpr
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: this is a new feature
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a new feature
[@tjferriss] Determine if we should create a regression test for this bug.
[@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
MelvinBot commentedon Mar 7, 2023
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)tjferriss commentedon Mar 8, 2023
@luacmartins this issue appears like it could be the same as #15597. What do you think?
I was able to reproduce the issue:
Screen.Recording.2023-03-08.at.9.42.54.AM.mov
luacmartins commentedon Mar 8, 2023
I see. This is related to the PR linked in the OP. Seems like the debounce we have on the composer box is putting the text back in it. I can take a look at this.
MelvinBot commentedon Mar 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012df6b447b406c99c
MelvinBot commentedon Mar 8, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (
Internal)21 remaining items
[-]WEB - Chat - Draft text is not cleared but the compose box is still focused[/-][+][HOLD for payment 2023-04-03] WEB - Chat - Draft text is not cleared but the compose box is still focused[/+]MelvinBot commentedon Mar 27, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 27, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-03. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Mar 27, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
luacmartins commentedon Mar 27, 2023
We should add the test steps in this PR to the compose box tests.
mollfpr commentedon Mar 27, 2023
Test step from the PR.
On Web/Desktop only:
Not applicable to mobile devices.
@luacmartins @tjferriss Could you assign me to the issue? Thank you!
tjferriss commentedon Mar 27, 2023
Issue for regression test created https://github.com/Expensify/Expensify/issues/271457
tjferriss commentedon Apr 5, 2023
@mollfpr sorry for the delay, I just invited you to the Upworks job to process payment for the PR review: https://www.upwork.com/jobs/~01b2c83c7fb1bd9dd7
mollfpr commentedon Apr 5, 2023
@tjferriss Applied!
mollfpr commentedon Apr 12, 2023
@tjferriss bump for the payment
tjferriss commentedon Apr 13, 2023
Done