Skip to content

[HOLD for payment 2023-04-03] WEB - Chat - Draft text is not cleared but the compose box is still focused #15724

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #15650

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to any chat
  4. Write some text in the compose box
  5. Press Esc
  6. Verify that the draft text is cleared but the compose box is still focused
  7. Repeat Steps 3,4,5

Expected Result:

Draft text is cleared but the compose box is still focused

Actual Result:

If you repeat the steps 3,4,5 several times, then the comment does not disappear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Web / Chrome
  • MacOS / Desktop

Version Number: 1.2.80.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5967861_Recording__346.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012df6b447b406c99c
  • Upwork Job ID: 1633544219615494144
  • Last Price Increase: 2023-03-08

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 7, 2023
  2. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Mar 7, 2023
  4. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. tjferriss commented on Mar 8, 2023

    @tjferriss
    Contributor

    @luacmartins this issue appears like it could be the same as #15597. What do you think?

    I was able to reproduce the issue:

    Screen.Recording.2023-03-08.at.9.42.54.AM.mov
  6. luacmartins commented on Mar 8, 2023

    @luacmartins
    Contributor

    I see. This is related to the PR linked in the OP. Seems like the debounce we have on the composer box is putting the text back in it. I can take a look at this.

  7. self-assigned this
    on Mar 8, 2023
  8. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 8, 2023
  9. unlocked this conversation on Mar 8, 2023
  10. MelvinBot commented on Mar 8, 2023

    @MelvinBot
    Contributor
  11. MelvinBot commented on Mar 8, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

  12. 21 remaining items

  13. changed the title [-]WEB - Chat - Draft text is not cleared but the compose box is still focused[/-] [+][HOLD for payment 2023-04-03] WEB - Chat - Draft text is not cleared but the compose box is still focused[/+] on Mar 27, 2023
  14. MelvinBot commented on Mar 27, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. MelvinBot commented on Mar 27, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-04-03. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR @mollfpr

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. MelvinBot commented on Mar 27, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Clear compose on Esc key #15650
    • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: this is a new feature
    • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a new feature
    • [@tjferriss] Determine if we should create a regression test for this bug.
    • [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/271457
  17. luacmartins commented on Mar 27, 2023

    @luacmartins
    Contributor

    We should add the test steps in this PR to the compose box tests.

  18. mollfpr commented on Mar 27, 2023

    @mollfpr
    Contributor

    Test step from the PR.


    On Web/Desktop only:

    1. Open a chat with a user
    2. Type quickly in the compose box and immediately press Esc
    3. Verify that the compose box is cleared and the old text doesn't show up again
    4. Repeat 2-3 several times

    Not applicable to mobile devices.


    @luacmartins @tjferriss Could you assign me to the issue? Thank you!

  19. removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Mar 27, 2023
  20. tjferriss commented on Mar 27, 2023

    @tjferriss
    Contributor
  21. tjferriss commented on Apr 5, 2023

    @tjferriss
    Contributor

    @mollfpr sorry for the delay, I just invited you to the Upworks job to process payment for the PR review: https://www.upwork.com/jobs/~01b2c83c7fb1bd9dd7

  22. mollfpr commented on Apr 5, 2023

    @mollfpr
    Contributor

    @tjferriss Applied!

  23. mollfpr commented on Apr 12, 2023

    @mollfpr
    Contributor

    @tjferriss bump for the payment

  24. tjferriss commented on Apr 13, 2023

    @tjferriss
    Contributor

    Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions