You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-07] [HOLD for payment 2023-03-17] Web - Profile - If user deletes the number without validating, page becomes unresponsive #15725
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Clicking the menu items call the onPress={() => Navigation.navigate(ROUTES.getEditContactMethodRoute(partnerUserID))} just fine, but Navigation.navigate seems to be decided not to do anything:
Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
I'm not familiarized at all with these transitions and how are the expected to work, so I'll ask. An easy fix would be to set Navigation.isNavigating back to false when we are unsubscribing, but I have no idea if that is a terrible solution.
changed the title [-]Web - Profile - If user deletes the number without validating, page becomes unresponsive[/-][+][HOLD for payment 2023-03-17] Web - Profile - If user deletes the number without validating, page becomes unresponsive[/+]on Mar 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.81-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
changed the title [-][HOLD for payment 2023-03-17] Web - Profile - If user deletes the number without validating, page becomes unresponsive[/-][+][HOLD for payment 2023-04-07] [HOLD for payment 2023-03-17] Web - Profile - If user deletes the number without validating, page becomes unresponsive[/+]on Mar 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
kbecciv commentedon Mar 7, 2023
On PROD this has not been implemented yet
Bug5967864_PROD.mp4
OSBotify commentedon Mar 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Mar 7, 2023
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.aldo-expensify commentedon Mar 8, 2023
Reproduced in staging with my main account
aldo-expensify commentedon Mar 8, 2023
Clicking the menu items call the
onPress={() => Navigation.navigate(ROUTES.getEditContactMethodRoute(partnerUserID))}just fine, but Navigation.navigate seems to be decided not to do anything:Screen.Recording.2023-03-08.at.10.55.04.AM.mov
MelvinBot commentedon Mar 8, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
aldo-expensify commentedon Mar 8, 2023
We are entering here:

and returning early instead of really navigating.
aldo-expensify commentedon Mar 8, 2023
Navigation.canNavigate is returning
falsebecause isNavigating is stuck withtruealdo-expensify commentedon Mar 8, 2023
The
Navigation.isNavigateis being set totruehere:App/src/components/ScreenWrapper/index.js
Lines 41 to 43 in fb20144
but then the component
ScreenWrappergets unmounted and we unsubscribe to the transition events before processing the 'transitionEnd' event, which would have setNavigation.isNavigatingback tofalse.I'm not familiarized at all with these transitions and how are the expected to work, so I'll ask. An easy fix would be to set
Navigation.isNavigatingback tofalsewhen we are unsubscribing, but I have no idea if that is a terrible solution.11 remaining items
[-]Web - Profile - If user deletes the number without validating, page becomes unresponsive[/-][+][HOLD for payment 2023-03-17] Web - Profile - If user deletes the number without validating, page becomes unresponsive[/+]MelvinBot commentedon Mar 10, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.81-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
[-][HOLD for payment 2023-03-17] Web - Profile - If user deletes the number without validating, page becomes unresponsive[/-][+][HOLD for payment 2023-04-07] [HOLD for payment 2023-03-17] Web - Profile - If user deletes the number without validating, page becomes unresponsive[/+]MelvinBot commentedon Mar 31, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue: