Skip to content

[HOLD for payment 2023-03-31] [$1000] Upload photo visible area is displayed as circle even though workspace image is square #15845

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open settings
  3. Open Workspaces
  4. Open any workspace
  5. Click workspace profile
  6. Again click on profile and click upload photo
  7. Select any image and click okay, observe profile visible area shape

Expected Result:

Shape of upload photo visible area should square like the workspace image

Actual Result:

Shape of upload photo visible area is circular even though workspace image is square

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.82-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

workspace.image.visible.area.mp4
Recording.1673.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678377109201399

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014be76ba771d0f991
  • Upwork Job ID: 1634279692537335808
  • Last Price Increase: 2023-03-10

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 10, 2023
  2. locked and limited conversation to collaborators on Mar 10, 2023
  3. MelvinBot commented on Mar 10, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Mar 10, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 10, 2023
  6. unlocked this conversation on Mar 10, 2023
  7. changed the title [-]Upload photo visible area is displayed as circle even though workspace image is square[/-] [+][$1000] Upload photo visible area is displayed as circle even though workspace image is square[/+] on Mar 10, 2023
  8. MelvinBot commented on Mar 10, 2023

    @MelvinBot
    Contributor
  9. MelvinBot commented on Mar 10, 2023

    @MelvinBot
    Contributor

    Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

  10. MelvinBot commented on Mar 10, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 10, 2023
  12. 55 remaining items

  13. abekkala commented on Apr 4, 2023

    @abekkala
    Contributor

    @dhanashree-sawant - invited to Upwork Job
    @PrashantMangukiya - hired/sent contract in Upwork
    @parasharrajat - invited to Upwork Job

    Once those are accepted I can process payments

  14. PrashantMangukiya commented on Apr 4, 2023

    @PrashantMangukiya
    Contributor

    @abekkala Offer accepted on Upwork. Thank you.

  15. abekkala commented on Apr 4, 2023

    @abekkala
    Contributor

    @PrashantMangukiya Paid and contract ended - thank you!

  16. dhanashree-sawant commented on Apr 4, 2023

    @dhanashree-sawant

    @abekkala Thanks, I have accepted the invite

  17. abekkala commented on Apr 4, 2023

    @abekkala
    Contributor

    @dhanashree-sawant paid and contract ended - thank you!

  18. abekkala commented on Apr 5, 2023

    @abekkala
    Contributor

    @parasharrajat paid and contract ended - thank you!

  19. abekkala commented on Apr 5, 2023

    @abekkala
    Contributor

    We're all set here - closing.
    Thank you everyone! 🎉

  20. abekkala commented on Apr 5, 2023

    @abekkala
    Contributor

    @parasharrajat and @PrashantMangukiya I was actually just reviewing this and you do get the 50% bonus.
    I'll send along a $500 contract for this to each of you for pay out.

    (I'm sorry I was counting assignment to production days vs. assignment to merge)

  21. abekkala commented on Apr 5, 2023

    @abekkala
    Contributor

    @parasharrajat and @PrashantMangukiya I've just created another job listing just for this bonus pay out [$500] Merge bonus for #15845 - Expensify and hired you both, once you accept I'll process payout today!

  22. parasharrajat commented on Apr 5, 2023

    @parasharrajat
    Member

    Thanks @abekkala Accepted.

  23. PrashantMangukiya commented on Apr 5, 2023

    @PrashantMangukiya
    Contributor

    Thanks @abekkala Accepted offer.

  24. abekkala commented on Apr 5, 2023

    @abekkala
    Contributor

    @parasharrajat and @PrashantMangukiya bonus payouts sent!

    Sorry about that! 😅
    All set now - Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions