Skip to content

Changing the width of the browser clears the email input value on the login page #15953

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Enter email address
  3. change browser size from large screen to small screen or small to large

Expected Result:

Email value should not be clear on changing the browser size

Actual Result:

Email value is beings cleared on changing browser size

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.83-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1703.mp4
email-clear-on-width-change.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678805557980369

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0102764c1cf38d1dc8
  • Upwork Job ID: 1635737230660661248
  • Last Price Increase: 2023-03-14

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 14, 2023
  2. locked and limited conversation to collaborators on Mar 14, 2023
  3. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. hayata-suenaga commented on Mar 14, 2023

    @hayata-suenaga
    Contributor

    @kadiealexander I did a checklist as I was looking for an issue to work on. I was able to reproduce the issue on the production site:

    email_input_issue.mov

    As discussed in this slack thread, the same problem has been reported before in a GH issue. This issue seems to be a regression caused by this PR.

    @kadiealexander if you agree that this issue should be fixed, I'm happy to take this one.

  6. kadiealexander commented on Mar 14, 2023

    @kadiealexander
    Contributor

    Thank you for doing the checklist, sounds great @hayata-suenaga!! Take it away.

  7. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 14, 2023
  8. unlocked this conversation on Mar 14, 2023
  9. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    Contributor
  10. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

  11. hayata-suenaga commented on Mar 15, 2023

    @hayata-suenaga
    Contributor

    The same issue happens with magic code input

    Screen.Recording.2023-03-15.at.2.33.17.PM.mov
  12. hayata-suenaga commented on Mar 15, 2023

    @hayata-suenaga
    Contributor

    This is caused because SignInPageLayout component ( which wraps LoginForm, ValidateCodeForm, and PasswordForm) conditionally renders different components.

    The component for smaller screens renders a form and footer inside same ScrollView, whereas the view for the screens other than small ones renders the graphics and footer in a same component next to a form.

    Because the instance for the form component will change after a screen size change, the state inside the form will be destroyed, resulting in the loss of input value.

    There is two option:

    Bring state up or create a context that saves value for input forms. However, as the bug is rather an edge case (user usually doesn't change their screen size when trying to sign in) and also the loss of input value is not significant (user can just retype the value), I believe we don't have to fix this.

    @kadiealexander what do you think?

  13. kadiealexander commented on Mar 15, 2023

    @kadiealexander
    Contributor

    I agree, it's definitely a very niche bug. I tend to lean towards "fix everything we can", but since it's not blocking users from the product and the likelihood of someone messing with their screen size during login is small, I'm happy to close this without fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions