You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Changing the width of the browser clears the email input value on the login page #15953
change browser size from large screen to small screen or small to large
Expected Result:
Email value should not be clear on changing the browser size
Actual Result:
Email value is beings cleared on changing browser size
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.83-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
This is caused because SignInPageLayout component ( which wraps LoginForm, ValidateCodeForm, and PasswordForm) conditionally renders different components.
The component for smaller screens renders a form and footer inside same ScrollView, whereas the view for the screens other than small ones renders the graphics and footer in a same component next to a form.
Because the instance for the form component will change after a screen size change, the state inside the form will be destroyed, resulting in the loss of input value.
There is two option:
Bring state up or create a context that saves value for input forms. However, as the bug is rather an edge case (user usually doesn't change their screen size when trying to sign in) and also the loss of input value is not significant (user can just retype the value), I believe we don't have to fix this.
I agree, it's definitely a very niche bug. I tend to lean towards "fix everything we can", but since it's not blocking users from the product and the likelihood of someone messing with their screen size during login is small, I'm happy to close this without fixing it.
Activity
MelvinBot commentedon Mar 14, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 14, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hayata-suenaga commentedon Mar 14, 2023
@kadiealexander I did a checklist as I was looking for an issue to work on. I was able to reproduce the issue on the production site:
email_input_issue.mov
As discussed in this slack thread, the same problem has been reported before in a GH issue. This issue seems to be a regression caused by this PR.
@kadiealexander if you agree that this issue should be fixed, I'm happy to take this one.
kadiealexander commentedon Mar 14, 2023
Thank you for doing the checklist, sounds great @hayata-suenaga!! Take it away.
MelvinBot commentedon Mar 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0102764c1cf38d1dc8
MelvinBot commentedon Mar 14, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (
Internal)hayata-suenaga commentedon Mar 15, 2023
The same issue happens with magic code input
Screen.Recording.2023-03-15.at.2.33.17.PM.mov
hayata-suenaga commentedon Mar 15, 2023
This is caused because
SignInPageLayoutcomponent ( which wrapsLoginForm,ValidateCodeForm, andPasswordForm) conditionally renders different components.The component for smaller screens renders a form and footer inside same
ScrollView, whereas the view for the screens other than small ones renders the graphics and footer in a same component next to a form.Because the instance for the form component will change after a screen size change, the state inside the form will be destroyed, resulting in the loss of input value.
There is two option:
Bring state up or create a context that saves value for input forms. However, as the bug is rather an edge case (user usually doesn't change their screen size when trying to sign in) and also the loss of input value is not significant (user can just retype the value), I believe we don't have to fix this.
@kadiealexander what do you think?
kadiealexander commentedon Mar 15, 2023
I agree, it's definitely a very niche bug. I tend to lean towards "fix everything we can", but since it's not blocking users from the product and the likelihood of someone messing with their screen size during login is small, I'm happy to close this without fixing it.