Skip to content

[HOLD #33434][$250] Migrate index.js to function component #16186

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c18f5687e5c548bf
  • Upwork Job ID: 1759601059714211840
  • Last Price Increase: 2024-02-19
  • Automatic offers:
    • s-alves10 | Contributor | 0
    • ishpaul777 | Contributor | 0

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate index.js to function component[/-] [+][HOLD][$250] Migrate index.js to function component[/+] on Apr 13, 2023
  4. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  5. dummy-1111 commented on Jun 6, 2023

    @dummy-1111
    Contributor

    I'd love to work on this.

  6. melvin-bot commented on Jun 9, 2023

    @melvin-bot

    Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. melvin-bot commented on Jun 13, 2023

    @melvin-bot

    6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  8. melvin-bot commented on Jun 15, 2023

    @melvin-bot

    Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  9. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    12 days overdue now... This issue's end is nigh!

  10. 89 remaining items

  11. puneetlath commented on Mar 13, 2024

    @puneetlath
    Contributor

    Unfortunately @s-alves10 isn't going to be able to finish this issue. I'm assigning to @mkhutornyi to take over

  12. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    ❌ There was an error making the offer to @mkhutornyi for the Contributor role. The BZ member will need to manually hire the contributor.

  13. mkhutornyi commented on Mar 14, 2024

    @mkhutornyi
    Contributor

    We need to put this on hold for #33434
    Reason:

    • some work here before that PR is merged will mostly get removed
    • the removing code part was already migrated into functional component / TS in upstream
    • PR is active and will be merged soon

    Discussion: https://expensify.slack.com/archives/C02NK2DQWUX/p1710425733927159?thread_ts=1710365206.608239&cid=C02NK2DQWUX

  14. changed the title [-][$250] Migrate index.js to function component[/-] [+][HOLD #33434][$250] Migrate index.js to function component[/+] on Mar 21, 2024
  15. pac-guerreiro commented on Mar 26, 2024

    @pac-guerreiro
    Contributor

    @mkhutornyi @puneetlath

    I'm currently migrating this file to typescript (#25151) and I already converted this component into a functional component.

    If you want I can push my version along with the migration, otherwise I can wait for you @mkhutornyi if you already worked on it! 😄

  16. mkhutornyi commented on Mar 26, 2024

    @mkhutornyi
    Contributor

    @pac-guerreiro please go ahead. @ishpaul777 can do C+ review on your PR.
    Btw, are you already aware that this migration is on hold for #33434?

    Looks like I am not needed anymore so unassigning, and also I haven't started yet.

  17. removed their assignment
    on Mar 26, 2024
  18. pac-guerreiro commented on Mar 26, 2024

    @pac-guerreiro
    Contributor

    @mkhutornyi Thanks! Seems like that #33434 was merged yesterday 😄

  19. pac-guerreiro commented on Mar 26, 2024

    @pac-guerreiro
    Contributor

    @ishpaul777 This is my PR - #39011 - have fun! 😄

  20. puneetlath commented on Mar 27, 2024

    @puneetlath
    Contributor

    Ok I'm going to just go ahead and close this issue out since it'll be handled as part of the TS migration for the component. Let me know if I've misunderstood!

  21. pac-guerreiro commented on Mar 27, 2024

    @pac-guerreiro
    Contributor

    @puneetlath you understood it correctly! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions