You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-14] Footer link "About Expensify" opening jobs page #16430
By clicking on About Expensify this page should be open
Actual Result:
Clicking on About Expensify link jobs page is opening
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.88-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
@MonilBhavsar thinking about the regression test a bit more, do we often make changes to the code base that have the potential to impact the links in the footer? I would think that this is more of a set once and forget kind of thing, unless we change the branding down the line.
If we don't often change the footer, will there be a lot of value in a regression test to click through all of the links?
@MonilBhavsar thinking about the regression test a bit more, do we often make changes to the code base that have the potential to impact the links in the footer? I would think that this is more of a set once and forget kind of thing, unless we change the branding down the line.
If we don't often change the footer, will there be a lot of value in a regression test to click through all of the links?
I agree, we won't be changing footer much often. We can skip the regression testing. Instead I think we can add an automated test.
Activity
MelvinBot commentedon Mar 22, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)joekaufmanexpensify commentedon Mar 23, 2023
Reproducible on my end, and see that the About Expensify hyperlink on the other footers links to https://we.are.expensify.com/how-we-got-here instead of https://we.are.expensify.com/ so this makes sense to me.
joekaufmanexpensify commentedon Mar 23, 2023
Passing to engineering for confirmation about whether this can be external!
MelvinBot commentedon Mar 23, 2023
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MonilBhavsar commentedon Mar 24, 2023
Good catch!
Pushed a quick minor fix
joekaufmanexpensify commentedon Mar 24, 2023
Great, thanks @MonilBhavsar !
25 remaining items
joekaufmanexpensify commentedon Apr 14, 2023
@MonilBhavsar thinking about the regression test a bit more, do we often make changes to the code base that have the potential to impact the links in the footer? I would think that this is more of a set once and forget kind of thing, unless we change the branding down the line.
If we don't often change the footer, will there be a lot of value in a regression test to click through all of the links?
joekaufmanexpensify commentedon Apr 14, 2023
@ayazhussain79 thanks for confirming! We'll issue the reporting payment as soon as we finalize the regression test details.
joekaufmanexpensify commentedon Apr 17, 2023
Not overdue, still resolving regression test
MonilBhavsar commentedon Apr 17, 2023
I agree, we won't be changing footer much often. We can skip the regression testing. Instead I think we can add an automated test.
joekaufmanexpensify commentedon Apr 17, 2023
Sounds good! Is the process to create an automated test documented somewhere?
MonilBhavsar commentedon Apr 17, 2023
Not a process I know of.
We can add automated tests to code itself. But in this case, we have defined a constant for footer text and it's link.
App/src/pages/signin/SignInPageLayout/Footer.js
Line 53 in 3f408cc
So I think it doesn't make sense to add test for verifying constant.
joekaufmanexpensify commentedon Apr 17, 2023
Got it. So you're thinking we just add no tests here? If the code that affects the footer is rarely/never going to be touched, that makes sense to me.
MonilBhavsar commentedon Apr 17, 2023
Yes 👍
Looks like issue reporter is paid. So we can close this issue
joekaufmanexpensify commentedon Apr 17, 2023
Awesome! Just closed out the last piece of the BZ checklist. I haven't paid the reporter yet. Will do that now!
joekaufmanexpensify commentedon Apr 17, 2023
@ayazhussain79 $250 sent and contract ended!
joekaufmanexpensify commentedon Apr 17, 2023
Upwork job closed.
joekaufmanexpensify commentedon Apr 17, 2023
Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!