Skip to content

[HOLD for payment 2023-04-14] Footer link "About Expensify" opening jobs page #16430

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to the NewDot Login page
  2. Click on About Expensify link on footer, and notice you are navigated to https://we.are.expensify.com/
  3. Go expensify.com and click on About Expensify link on footer, and notice you are navigated to https://we.are.expensify.com/how-we-got-here .
  4. Go to help.expensify.com and click on About Expensify link on footer, and notice you are navigated to https://we.are.expensify.com/how-we-got-here .

Expected Result:

By clicking on About Expensify this page should be open

Actual Result:

Clicking on About Expensify link jobs page is opening

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.88-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

20230323020142.mp4
Recording.26.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679520224035689

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0144e8958596b89ad0
  • Upwork Job ID: 1639277306344259584
  • Last Price Increase: 2023-03-24

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 22, 2023
  2. MelvinBot commented on Mar 22, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Mar 22, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. joekaufmanexpensify commented on Mar 23, 2023

    @joekaufmanexpensify
    Contributor

    Reproducible on my end, and see that the About Expensify hyperlink on the other footers links to https://we.are.expensify.com/how-we-got-here instead of https://we.are.expensify.com/ so this makes sense to me.

    2023-03-23_14-51-06 (1)

  5. joekaufmanexpensify commented on Mar 23, 2023

    @joekaufmanexpensify
    Contributor

    Passing to engineering for confirmation about whether this can be external!

  6. MelvinBot commented on Mar 23, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. MonilBhavsar commented on Mar 24, 2023

    @MonilBhavsar
    Contributor

    Good catch!
    Pushed a quick minor fix

  8. joekaufmanexpensify commented on Mar 24, 2023

    @joekaufmanexpensify
    Contributor

    Great, thanks @MonilBhavsar !

  9. 25 remaining items

  10. joekaufmanexpensify commented on Apr 14, 2023

    @joekaufmanexpensify
    Contributor

    @MonilBhavsar thinking about the regression test a bit more, do we often make changes to the code base that have the potential to impact the links in the footer? I would think that this is more of a set once and forget kind of thing, unless we change the branding down the line.

    If we don't often change the footer, will there be a lot of value in a regression test to click through all of the links?

  11. joekaufmanexpensify commented on Apr 14, 2023

    @joekaufmanexpensify
    Contributor

    @ayazhussain79 thanks for confirming! We'll issue the reporting payment as soon as we finalize the regression test details.

  12. joekaufmanexpensify commented on Apr 17, 2023

    @joekaufmanexpensify
    Contributor

    Not overdue, still resolving regression test

  13. MonilBhavsar commented on Apr 17, 2023

    @MonilBhavsar
    Contributor

    @MonilBhavsar thinking about the regression test a bit more, do we often make changes to the code base that have the potential to impact the links in the footer? I would think that this is more of a set once and forget kind of thing, unless we change the branding down the line.

    If we don't often change the footer, will there be a lot of value in a regression test to click through all of the links?

    I agree, we won't be changing footer much often. We can skip the regression testing. Instead I think we can add an automated test.

  14. joekaufmanexpensify commented on Apr 17, 2023

    @joekaufmanexpensify
    Contributor

    Sounds good! Is the process to create an automated test documented somewhere?

  15. MonilBhavsar commented on Apr 17, 2023

    @MonilBhavsar
    Contributor

    Not a process I know of.
    We can add automated tests to code itself. But in this case, we have defined a constant for footer text and it's link.

    So I think it doesn't make sense to add test for verifying constant.

  16. joekaufmanexpensify commented on Apr 17, 2023

    @joekaufmanexpensify
    Contributor

    Got it. So you're thinking we just add no tests here? If the code that affects the footer is rarely/never going to be touched, that makes sense to me.

  17. MonilBhavsar commented on Apr 17, 2023

    @MonilBhavsar
    Contributor

    Yes 👍
    Looks like issue reporter is paid. So we can close this issue

  18. joekaufmanexpensify commented on Apr 17, 2023

    @joekaufmanexpensify
    Contributor

    Awesome! Just closed out the last piece of the BZ checklist. I haven't paid the reporter yet. Will do that now!

  19. joekaufmanexpensify commented on Apr 17, 2023

    @joekaufmanexpensify
    Contributor

    @ayazhussain79 $250 sent and contract ended!

  20. joekaufmanexpensify commented on Apr 17, 2023

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  21. joekaufmanexpensify commented on Apr 17, 2023

    @joekaufmanexpensify
    Contributor

    Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions