Skip to content

[HOLD for payment 2023-05-16] [$1000] Web - On logout from the app weird url parameter shows on login page #16452

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app -> Login in account
  2. Logout from the app
  3. Notice web url it contains https://new.expensify.com/?openOnAdminRoom=false

Expected Result:

No parameter should be added after logout should be pointed to https://new.expensify.com/

Actual Result:

Parameter is added at end of URL

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.88-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-03-23.at.5.25.54.PM.mov

Untitled

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679573323219989

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01498ddcb81526ba53
  • Upwork Job ID: 1645750765863743488
  • Last Price Increase: 2023-04-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 23, 2023
  2. MelvinBot commented on Mar 23, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Mar 23, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. removed their assignment
    on Mar 24, 2023
  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 24, 2023
  6. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. alexpensify commented on Mar 24, 2023

    @alexpensify
    Contributor

    I'm reassigning the Bug label. I couldn't get to this one today and will be OOO until April 3.

  9. kevinksullivan commented on Mar 27, 2023

    @kevinksullivan
    Contributor

    I'm OOO / sick so I'm going to pass this along as well.

  10. 74 remaining items

  11. thesahindia commented on May 18, 2023

    @thesahindia
    Member

    I have invited everyone to the payment issue here

    Applied, thanks!

  12. muttmuure commented on May 23, 2023

    @muttmuure
    Contributor

    Will bump and process payments when I'm back from out of office

  13. melvin-bot commented on May 26, 2023

    @melvin-bot

    @amyevans, @muttmuure, @thesahindia, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. amyevans commented on May 30, 2023

    @amyevans
    Contributor

    Just waiting on payment processing which @muttmuure will handle; looks like he'll be back Th

  15. muttmuure commented on Jun 1, 2023

    @muttmuure
    Contributor

    Hiring offers sent

  16. muttmuure commented on Jun 6, 2023

    @muttmuure
    Contributor

    paid @dhairyasenjaliya and @tienifr.

    Just @thesahindia to accept the offer, I think wires are crossed and maybe you're looking at the wrong Upwork job

  17. thesahindia commented on Jun 6, 2023

    @thesahindia
    Member

    Accepted the offer, thanks!

  18. muttmuure commented on Jun 6, 2023

    @muttmuure
    Contributor

    Everyone is paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions