You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-07] [HOLD] The "Delete Comment" context tab has been moved to the left #16639
The Delete Comment tab has been moved to the left.
Deleting Ws the same issue and Ctrl+I
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.91-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]The "Delete Comment" context tab has been moved to the left[/-][+][HOLD] The "Delete Comment" context tab has been moved to the left[/+]on Mar 29, 2023
changed the title [-][HOLD] The "Delete Comment" context tab has been moved to the left[/-][+][HOLD for payment 2023-04-07] [HOLD] The "Delete Comment" context tab has been moved to the left[/+]on Mar 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@luacmartins / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@strepanier03] Determine if we should create a regression test for this bug.
[@luacmartins / @stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
MelvinBot commentedon Mar 28, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Mar 28, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Mar 28, 2023
Auto-assign attempt failed, all eligible assignees are OOO.
varshamb commentedon Mar 28, 2023
I have reported this bug on slack.
https://expensify.slack.com/archives/C049HHMV9SM/p1680023847655009
situchan commentedon Mar 28, 2023
This is duplicated with #16636 since they have the same root cause
strepanier03 commentedon Mar 29, 2023
Putting this one on HOLD until the linked GH is resolved. Then I'll test and make sure.
[-]The "Delete Comment" context tab has been moved to the left[/-][+][HOLD] The "Delete Comment" context tab has been moved to the left[/+]5 remaining items
luacmartins commentedon Mar 30, 2023
We shipped the fix and this is solved. Closing.
[-][HOLD] The "Delete Comment" context tab has been moved to the left[/-][+][HOLD for payment 2023-04-07] [HOLD] The "Delete Comment" context tab has been moved to the left[/+]MelvinBot commentedon Mar 31, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Mar 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: