Skip to content

[HOLD for payment 2023-05-22] [HOLD #14490] [$1000] Crash on IOURequestPage #16739

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go onto a slow network
  2. Login to New Expensify
  3. While the LHN is still loading and showing the skeleton UI, click on the global create menu
  4. Click on Send Money
  5. Enter an amount
  6. Press Enter

Expected Result:

You should be taken to the next screen to choose recipients. There should be a skeleton UI on that search page.

Actual Result:

The app crashes.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Issue reported by: n/a (@aimane-chnaif reported this in a PR review here when the bug was introduced and considered edgy/out-of-scope)
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680147029222199

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016871515dc2088e09
  • Upwork Job ID: 1643851935839272960
  • Last Price Increase: 2023-04-06

Activity

  1. MelvinBot commented on Mar 30, 2023

    @MelvinBot
    Contributor

    @roryabraham the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Mar 30, 2023
  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 30, 2023
  4. MelvinBot commented on Mar 30, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. MelvinBot commented on Mar 30, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. lschurr commented on Mar 30, 2023

    @lschurr
    Contributor

    Is this all platforms @roryabraham?

  7. aimane-chnaif commented on Mar 30, 2023

    @aimane-chnaif
    Contributor

    Is this all platforms @roryabraham?

    yes all platforms.
    You need to do actions quickly to go to IOURequestPage before loading personal details.
    More high traffic and slower network, easier to reproduce.

  8. lschurr commented on Mar 31, 2023

    @lschurr
    Contributor

    I'm not able to reproduce, but maybe I just don't have a slow enough high traffic network to try. Adding Eng for more eyes.

  9. MelvinBot commented on Mar 31, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  10. 22 remaining items

  11. changed the title [-][HOLD #14490] [$1000] Crash on IOURequestPage[/-] [+][HOLD for payment 2023-05-22] [HOLD #14490] [$1000] Crash on IOURequestPage[/+] on May 15, 2023
  12. melvin-bot commented on May 15, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 15, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-05-22. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on May 15, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
    • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@thesahindia] Determine if we should create a regression test for this bug.
    • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. lschurr commented on May 16, 2023

    @lschurr
    Contributor

    This one was put on hold and fixed elsewhere, is that right @youssef-lr @thesahindia? Are there payments needed for this one?

  16. aimane-chnaif commented on May 16, 2023

    @aimane-chnaif
    Contributor

    This was fixed in #17349
    I think I am only the one for reporting bonus

  17. lschurr commented on May 16, 2023

    @lschurr
    Contributor

    Great, could you apply to the job here @aimane-chnaif - https://www.upwork.com/jobs/~01dfce6726bdf40e71

  18. aimane-chnaif commented on May 16, 2023

    @aimane-chnaif
    Contributor

    @lschurr applied, thanks

  19. lschurr commented on May 16, 2023

    @lschurr
    Contributor

    Once payment is made, can we close this one @youssef-lr @thesahindia @aimane-chnaif?

  20. youssef-lr commented on May 16, 2023

    @youssef-lr
    Contributor

    Once payment is made, can we close this one @youssef-lr @thesahindia @aimane-chnaif?

    Yup!

  21. lschurr commented on May 16, 2023

    @lschurr
    Contributor

    Great! Reporting bonus is paid. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions