You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-05-22] [HOLD #14490] [$1000] Crash on IOURequestPage #16739
yes all platforms.
You need to do actions quickly to go to IOURequestPage before loading personal details.
More high traffic and slower network, easier to reproduce.
changed the title [-][HOLD #14490] [$1000] Crash on IOURequestPage[/-][+][HOLD for payment 2023-05-22] [HOLD #14490] [$1000] Crash on IOURequestPage[/+]on May 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
MelvinBot commentedon Mar 30, 2023
@roryabraham the
AutoAssignerTriagelabel has been deprecated. Please useBugfor issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 30, 2023
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)lschurr commentedon Mar 30, 2023
Is this all platforms @roryabraham?
aimane-chnaif commentedon Mar 30, 2023
yes all platforms.
You need to do actions quickly to go to IOURequestPage before loading personal details.
More high traffic and slower network, easier to reproduce.
lschurr commentedon Mar 31, 2023
I'm not able to reproduce, but maybe I just don't have a slow enough high traffic network to try. Adding Eng for more eyes.
MelvinBot commentedon Mar 31, 2023
Triggered auto assignment to @youssef-lr (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.22 remaining items
[-][HOLD #14490] [$1000] Crash on IOURequestPage[/-][+][HOLD for payment 2023-05-22] [HOLD #14490] [$1000] Crash on IOURequestPage[/+]melvin-bot commentedon May 15, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
lschurr commentedon May 16, 2023
This one was put on hold and fixed elsewhere, is that right @youssef-lr @thesahindia? Are there payments needed for this one?
aimane-chnaif commentedon May 16, 2023
This was fixed in #17349
I think I am only the one for reporting bonus
lschurr commentedon May 16, 2023
Great, could you apply to the job here @aimane-chnaif - https://www.upwork.com/jobs/~01dfce6726bdf40e71
aimane-chnaif commentedon May 16, 2023
@lschurr applied, thanks
lschurr commentedon May 16, 2023
Once payment is made, can we close this one @youssef-lr @thesahindia @aimane-chnaif?
youssef-lr commentedon May 16, 2023
Yup!
lschurr commentedon May 16, 2023
Great! Reporting bonus is paid. Closing this one.