Skip to content

[HOLD for payment 2023-05-03] [$1000] Screen is shaking when scrolling while user edit a comment between 2 tabs. #16931

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a new report, try to send few message (Make sure the content of the message has over 15 lines), open that report in another tab.
  2. From the first tab, try to edit a multiple lines message, make sure the content is scrollable.
  3. From the second tab, delete all the content of that message, return the first tab try to scroll to bottom few times.
  4. Notice that screen is shaking while scrolling.

Expected Result:

User should scroll to bottom without any issue.

Actual Result:

Screen is shaking while scrolling.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.94-0
Reproducible in staging?: needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-04.at.18.21.16.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680608255498089

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c4cdb2f5c5e79041
  • Upwork Job ID: 1645761324986847232
  • Last Price Increase: 2023-04-18

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 4, 2023
  2. MelvinBot commented on Apr 4, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 4, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. laurenreidexpensify commented on Apr 7, 2023

    @laurenreidexpensify
    Contributor

    I''m finding this one pretty hard to reproduce based on the instructions above - @kavimuru @hungvu193 can you break this down a bit further? Thanks

  5. hungvu193 commented on Apr 9, 2023

    @hungvu193
    Contributor

    @laurenreidexpensify I think I can give you more information here.

    • Try to create a new conversation
    • Make sure the content of the edit message has over 15 lines after that try to scroll to the bottom, you will see
    Screen.Recording.2023-04-09.at.22.09.59.mov
  6. MelvinBot commented on Apr 11, 2023

    @MelvinBot
    Contributor

    @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Apr 11, 2023
  8. changed the title [-]Screen is shaking when scrolling while user edit a comment between 2 tabs.[/-] [+][$1000] Screen is shaking when scrolling while user edit a comment between 2 tabs.[/+] on Apr 11, 2023
  9. 48 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 26, 2023
  11. changed the title [-][$1000] Screen is shaking when scrolling while user edit a comment between 2 tabs.[/-] [+][HOLD for payment 2023-05-03] [$1000] Screen is shaking when scrolling while user edit a comment between 2 tabs.[/+] on Apr 26, 2023
  12. MelvinBot commented on Apr 26, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. MelvinBot commented on Apr 26, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-05-03. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. MelvinBot commented on Apr 26, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/280594
  15. s77rt commented on Apr 26, 2023

    @s77rt
    Member

    Regression Test Proposal (Web Only)

    1. Login to NewDot in 2 tabs
    2. Open same chat in both tabs (chat must be scrollable i.e. have previous messages)
    3. Tab 1: Send a long multiline message e.g. 25 lines
    4. Tab 1: Edit the message: delete the content but do not press the 'Save' button
    5. Tab 2: Verify the message is in edit mode
    6. Tab 2: Verify the message content is not cleared
    7. Tab 2: Scroll inside the edit message
    8. Tab 2: Scroll outside the edit message
    9. Tab 2: Verify that you were able to scroll smoothly
  16. laurenreidexpensify commented on May 3, 2023

    @laurenreidexpensify
    Contributor

    great work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions