Skip to content

[$1000] Extra horizontal spacing (extra 13px on left and right side) on the resend link password page #17177

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Action Performed:
  2. Open App
  3. Go to the login page and create a new account
  4. It will navigate to resend link page

Expected Result:

Horizontal spacing should match with login and password page

Actual Result:

There is some Horizontal extra spacing on resend link page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.97-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.168.mp4
horizotal-padding.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680877783483729

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014b51493b1fd78e8a
  • Upwork Job ID: 1645439153607278592
  • Last Price Increase: 2023-04-17

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 8, 2023
  2. MelvinBot commented on Apr 8, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 8, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. CortneyOfstad commented on Apr 10, 2023

    @CortneyOfstad
    Contributor

    Was able to recreate this, so getting eyes on it 👍

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 10, 2023
  6. changed the title [-]Extra horizontal spacing (extra 13px on left and right side) on the resend link password page[/-] [+][$1000] Extra horizontal spacing (extra 13px on left and right side) on the resend link password page[/+] on Apr 10, 2023
  7. MelvinBot commented on Apr 10, 2023

    @MelvinBot
    Contributor
  8. MelvinBot commented on Apr 10, 2023

    @MelvinBot
    Contributor

    Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

  9. MelvinBot commented on Apr 10, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 10, 2023
  11. 28 remaining items

  12. cead22 commented on Apr 14, 2023

    @cead22
    Contributor

    Requirement is keep the login page width intact and follow that for all pages.

    To clarify, where did this come from?

    This is a small issue and anything will work which doesn't break anything.

    I disagree with this as well. If we believe there's a bug with the CSS/layout we have, a solution that fixes that bug should be preferred over one that masks it, in my opinion

  13. parasharrajat commented on Apr 15, 2023

    @parasharrajat
    Member

    If we believe there's a bug with the CSS/layout we have, a solution that fixes that bug should be preferred over one that masks it, in my opinion

    Couldn't agree more.

    To clarify, where did this come from?

    From this comment #17177 (comment) from Shawn where he mentioned that everything should match the initial login page.

    If we remove the 300px to which is applied to the login page content. It will reduce the content width on the login page thus resulting in a design change on the initial login page.

    From this comment, I understood(sorry if I was wrong about it) that we should also set the content width on the Resend Link page equal to the initial login page.

    Why can't it be a multiple of 4?

    Our Design Philosophy follows around a multiple of 4 to keep the app UI consistent.

    /**
    * Spacing utility styles with Bootstrap inspired naming.
    * All styles should be incremented by units of 4.
    *
    * https://getbootstrap.com/docs/5.0/utilities/spacing
    */
    export default {
    m0: {

    This is how I come up that we should change the padding?

    Intially the SignIn form was build to use fluid width on the parent container excluding the padding. #12848 changed this design and added a fixed width to the login form content increasing it from the previous possible values. It didn't change the Resend Link Page thus this regression. It set the padding to 40px. But at that time too content was overlapping with the padding as

    Image showing overlapping

    image

    whole sidebar width = 360. 
    Main content width = 300. 
    Availalble space for padding = 360 -300 = 60 px. 
    But the padding applied (left : 40px; right 40px) = 40 + 40 = 80px. 
    Overlapped gap = 20px.
    

    Thus I anticipated see that design bug is with incorrect padding.

    Now the Resend Link page is still using fluid width for the content which will respect the padding of parent thus

    whole sidebar width = 360. 
    Padding applied to container ( left : 40px; right 40px) = 40 + 40 = 80px. 
    Availalble main content width = 360 - 80 = 280px
    

    the Content width of Resend Link page is less than the login page.


    I am happy both ways. I don't think either of the solutions is a workaround. CSS is very lenient. Either setting the content to 300px or adjusting the padding will work.

    If we decide to set the width to 300px then we should still adjust the padding so that it does not overlap although it is not visually affecting anything.

    Now as setting padding to 30px does not fit into our design language, we can adjust the login page content width from 300 to a close number like 304px so that padding (28px) fits well with the system. This can be cleaned up in the PR review so I didn't think to explain this during the proposal review.

  14. MelvinBot commented on Apr 17, 2023

    @MelvinBot
    Contributor

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. cead22 commented on Apr 17, 2023

    @cead22
    Contributor

    From this comment #17177 (comment) from Shawn where he mentioned that everything should match the initial login page.
    If we remove the 300px to which is applied to the login page content. It will reduce the content width on the login page thus resulting in a design change on the initial login page.

    Thanks for clarifying, I think we agree, but maybe we interpreted @shawnborton 's comment differently. To confirm we're on the same page, let me know if you agree, but I think we should:

    • Make the login page and the resend password link page equally wide
    • Make them both as wide as the widest one which is the login page
    • Update the CSS so this happens by design, and not by unintentionally having some content overflow from its container
  16. parasharrajat commented on Apr 17, 2023

    @parasharrajat
    Member

    I agree with this.

  17. alitoshmatov commented on Apr 18, 2023

    @alitoshmatov
    Contributor

    @cead22 Still reproducible:
    Screenshot 2023-04-18 at 11 33 18 PM
    Screenshot 2023-04-18 at 11 33 42 PM
    Screenshot 2023-04-18 at 11 36 53 PM

    New discovery: If email is too long the content will outgrow the parent and overflow, but it also has max-width: 300px and will stop at 300px looking like, acting the same as other two pages(signin, password)

    Screenshot 2023-04-18 at 11 37 27 PM

  18. cead22 commented on Apr 18, 2023

    @cead22
    Contributor

    We discussed further on slack and it turns out we can't reproduce on dev or staging anymore, even though we can repro in production -- so we're closing this issue
    image

  19. michaelhaxhiu commented on Apr 19, 2023

    @michaelhaxhiu
    Contributor

    The assigned C+ (Rajat) reviewed quite a few proposals here before we came to learn this was fixed elsewhere. For that reason let's offer a partial compensation of 25% - discussed in the #c+ internal slack channel here.

  20. michaelhaxhiu commented on Apr 19, 2023

    @michaelhaxhiu
    Contributor
  21. michaelhaxhiu commented on Apr 20, 2023

    @michaelhaxhiu
    Contributor

    paid, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions