Skip to content

[HOLD for payment 2023-06-07] [$1000] The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode) #17181

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to web chrome (online mode)
  2. Go to any chat
  3. Send a text message
  4. Edit the message
  5. Click on save
  6. Now turn off your wifi or click on force offline from the preference page
  7. Now delete the message
  8. Notice that the horizontal line for the text 'edited' is not at the center unlike other chat messages
  9. But if you follow the same steps on android , you'll see the horizontal line for the text 'edited' at the center only

Expected Result:
The horizontal line for the edited text should be at the center for the word 'edited' in a similar how android shows it

Actual Result:

The horizontal line for the word 'edited' is not at the center unlike android

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.97-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
android

error-2023-04-07_15.48.05.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680862318324249

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0118d19fc456de16df
  • Upwork Job ID: 1645467006413078528
  • Last Price Increase: 2023-04-17

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 8, 2023
  2. MelvinBot commented on Apr 8, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 8, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. JmillsExpensify commented on Apr 10, 2023

    @JmillsExpensify
    Contributor

    Assigning myself since I was also pulled into the linked Slack convo.

  5. JmillsExpensify commented on Apr 10, 2023

    @JmillsExpensify
    Contributor

    I'm able to reproduce the issue, and while a small visual issue, let's see if the community has ideas on how we can fix this. If we find a great root cause that's fixable we should do something.

    Screenshot 2023-04-10 at 11 40 12

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 10, 2023
  7. changed the title [-]The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode)[/-] [+][$1000] The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode)[/+] on Apr 10, 2023
  8. MelvinBot commented on Apr 10, 2023

    @MelvinBot
    Contributor
  9. MelvinBot commented on Apr 10, 2023

    @MelvinBot
    Contributor

    Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

  10. 40 remaining items

  11. trjExpensify commented on Jun 7, 2023

    @trjExpensify
    Contributor

    👋 @sobitneupane can you run through the checklist please so we can move on with processing payments? Thanks!

  12. sobitneupane commented on Jun 9, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    I tried to go back to few commits to find the exact PR which introduced the issue. But could not point to the exact PR Looks like it was present from the very beginning when edited label was introduced in this PR.

  13. sobitneupane commented on Jun 9, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Open any chat
    2. Send few messages like normal text, emoji, and markdown
    3. Edit the messages
    4. Disable your network or force offline from preferences
    5. Delete the edited messages
    6. Verify that the line through in edited label is aligned properly for all message types

    Do we agree 👍 or 👎

  14. trjExpensify commented on Jun 9, 2023

    @trjExpensify
    Contributor

    I tried to go back to few commits to find the exact PR which introduced the issue. But could not point to the exact PR Looks like it was present from the very beginning when edited label was introduced in #2320.

    Cool, fair enough. We comment there then! :)

    As for the regression test, we have this one for editing a comment. We could pop it in the offline section. That said, I'd love to offer more direction than just "aligned properly", because who knows if the tester knows what's proper or not. Center aligned? What do you think?

    Online

    1. Navigate a conversation (with another user you have access to) in the main testing device
    2. Hover over an owned message (Web/Desktop) / Tap and hold (Mobile) to view the action menu
    3. Click/Tap on the Pencil icon to activate the edit message box
    4. Edit the message to "0" and save the changes
    5. Verify the edited message is still displayed in the conversation viewport (it should not scroll out of view)
    6. Verify the message is displaying the new text, has a "(edited)" status in the conversation history and that the text is not grayed out
    7. Send a message that includes a hyperlink i.e google.com
    8. Edit the message with the hyperlink (do not modify the link) and save the changes
    9. Verify the link is still hyperlinked in the modified message
    10. Now edit the domain part of the link, while keeping the text the same but changing the capitalization of the domain letters i.e google.com
    11. Verify the link is still hyperlinked in the modified message and the domain part maintains its original capitalization
    12. Log in as the other user in the conversation
    13. Verify the edited message is displaying the new text and has a "(edited)" status in the conversation history

    Offline

    1. Disable the internet connection in the main testing device
    2. Hover over an owned message (Web/Desktop) / Tap and hold (Mobile) to view the action menu
    3. Click/Tap on the Pencil icon to activate the edit message box
    4. Verify you're able to edit the message while there's no internet connection
    5. Edit the message to "0" and save the changes
    6. Verify the comment text is updated it's greyed out indicating it's pending
      7. Verify that the line through in edited label is aligned properly
    7. Click/tap the pencil icon again
    8. Edit the message to something new
    9. Verify the “save changes” button is enabled, hit the button
    10. Verify the comment text is updated it's greyed out indicating it's pending
    11. Refresh the page or force-kill and relaunch the app
    12. Enable the internet connection in the device - in web you might need to refresh the page after going back online
    13. Verify the comment is not be grayed out anymore indicating it was updated successfully
  15. trjExpensify commented on Jun 12, 2023

    @trjExpensify
    Contributor

    Bump on this @sobitneupane:

    That said, I'd love to offer more direction than just "aligned properly", because who knows if the tester knows what's proper or not. Center aligned? What do you think?

  16. sobitneupane commented on Jun 12, 2023

    @sobitneupane
    Contributor

    Yup. Center aligned will make it clear.

    As for the regression test, we have this one for editing a comment. We could pop it in the offline section.

    I don't think we can add it in the section you mentioned above. We need to delete the message after editing in offline.

  17. trjExpensify commented on Jun 13, 2023

    @trjExpensify
    Contributor

    Ah yeah fair, okay.. I'll run it by applause. It could go in the delete offline tests perhaps. Issue created here.

    Okay, let's proceed with the payments. I've sent offers for:

    $1,000 to @sobitneupane for C+
    $1,000 to @pubudu-ranasinghe for the fix
    $250 to @priya-zha for the bug report

  18. trjExpensify commented on Jun 13, 2023

    @trjExpensify
    Contributor
  19. trjExpensify commented on Jun 13, 2023

    @trjExpensify
    Contributor
  20. trjExpensify commented on Jun 13, 2023

    @trjExpensify
    Contributor

    @pubudu-ranasinghe paid! Closing, thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions