You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-07] [$1000] The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode) #17181
Now turn off your wifi or click on force offline from the preference page
Now delete the message
Notice that the horizontal line for the text 'edited' is not at the center unlike other chat messages
But if you follow the same steps on android , you'll see the horizontal line for the text 'edited' at the center only
Expected Result:
The horizontal line for the edited text should be at the center for the word 'edited' in a similar how android shows it
Actual Result:
The horizontal line for the word 'edited' is not at the center unlike android
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.97-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
I'm able to reproduce the issue, and while a small visual issue, let's see if the community has ideas on how we can fix this. If we find a great root cause that's fixable we should do something.
changed the title [-]The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode)[/-][+][$1000] The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode)[/+]on Apr 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
I tried to go back to few commits to find the exact PR which introduced the issue. But could not point to the exact PR Looks like it was present from the very beginning when edited label was introduced in this PR.
I tried to go back to few commits to find the exact PR which introduced the issue. But could not point to the exact PR Looks like it was present from the very beginning when edited label was introduced in #2320.
Cool, fair enough. We comment there then! :)
As for the regression test, we have this one for editing a comment. We could pop it in the offline section. That said, I'd love to offer more direction than just "aligned properly", because who knows if the tester knows what's proper or not. Center aligned? What do you think?
Online
Navigate a conversation (with another user you have access to) in the main testing device
Hover over an owned message (Web/Desktop) / Tap and hold (Mobile) to view the action menu
Click/Tap on the Pencil icon to activate the edit message box
Edit the message to "0" and save the changes
Verify the edited message is still displayed in the conversation viewport (it should not scroll out of view)
Verify the message is displaying the new text, has a "(edited)" status in the conversation history and that the text is not grayed out
Send a message that includes a hyperlink i.e google.com
Edit the message with the hyperlink (do not modify the link) and save the changes
Verify the link is still hyperlinked in the modified message
Now edit the domain part of the link, while keeping the text the same but changing the capitalization of the domain letters i.e google.com
Verify the link is still hyperlinked in the modified message and the domain part maintains its original capitalization
Log in as the other user in the conversation
Verify the edited message is displaying the new text and has a "(edited)" status in the conversation history
Offline
Disable the internet connection in the main testing device
Hover over an owned message (Web/Desktop) / Tap and hold (Mobile) to view the action menu
Click/Tap on the Pencil icon to activate the edit message box
Verify you're able to edit the message while there's no internet connection
Edit the message to "0" and save the changes
Verify the comment text is updated it's greyed out indicating it's pending 7. Verify that the line through in edited label is aligned properly
Click/tap the pencil icon again
Edit the message to something new
Verify the “save changes” button is enabled, hit the button
Verify the comment text is updated it's greyed out indicating it's pending
Refresh the page or force-kill and relaunch the app
Enable the internet connection in the device - in web you might need to refresh the page after going back online
Verify the comment is not be grayed out anymore indicating it was updated successfully
That said, I'd love to offer more direction than just "aligned properly", because who knows if the tester knows what's proper or not. Center aligned? What do you think?
Activity
MelvinBot commentedon Apr 8, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)JmillsExpensify commentedon Apr 10, 2023
Assigning myself since I was also pulled into the linked Slack convo.
JmillsExpensify commentedon Apr 10, 2023
I'm able to reproduce the issue, and while a small visual issue, let's see if the community has ideas on how we can fix this. If we find a great root cause that's fixable we should do something.
[-]The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode)[/-][+][$1000] The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode)[/+]MelvinBot commentedon Apr 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0118d19fc456de16df
MelvinBot commentedon Apr 10, 2023
Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.
40 remaining items
trjExpensify commentedon Jun 7, 2023
👋 @sobitneupane can you run through the checklist please so we can move on with processing payments? Thanks!
sobitneupane commentedon Jun 9, 2023
I tried to go back to few commits to find the exact PR which introduced the issue. But could not point to the exact PR Looks like it was present from the very beginning when edited label was introduced in this PR.
sobitneupane commentedon Jun 9, 2023
Regression Test Proposal
Do we agree 👍 or 👎
trjExpensify commentedon Jun 9, 2023
Cool, fair enough. We comment there then! :)
As for the regression test, we have this one for editing a comment. We could pop it in the offline section. That said, I'd love to offer more direction than just "aligned properly", because who knows if the tester knows what's proper or not. Center aligned? What do you think?
Online
Offline
7. Verify that the line through in edited label is aligned properly
trjExpensify commentedon Jun 12, 2023
Bump on this @sobitneupane:
sobitneupane commentedon Jun 12, 2023
Yup. Center aligned will make it clear.
I don't think we can add it in the section you mentioned above. We need to delete the message after editing in offline.
trjExpensify commentedon Jun 13, 2023
Ah yeah fair, okay.. I'll run it by applause. It could go in the delete offline tests perhaps. Issue created here.
Okay, let's proceed with the payments. I've sent offers for:
$1,000 to @sobitneupane for C+
$1,000 to @pubudu-ranasinghe for the fix
$250 to @priya-zha for the bug report
trjExpensify commentedon Jun 13, 2023
@sobitneupane paid!
trjExpensify commentedon Jun 13, 2023
@priya-zha paid!
trjExpensify commentedon Jun 13, 2023
@pubudu-ranasinghe paid! Closing, thanks everyone.