Skip to content

[HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] FAB - There is no "New workspace" button in FAB menu #17684

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid account that is ready for Error tests (In this case: applausetester+disabledpolicy@applause.expensifail.com
    )
  3. Click on the FAB menu

Expected Result:

User expects to see an option of "Add workspace"

Actual Result:

The Add workspace option is completely gone, seems to have been replaced by "Assign task". Both options should be shown to the user. Now the user has to go to Profile > Workspace > New workspace to be able to create a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.2.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6024396_No_workspace_button.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Apr 19, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Apr 19, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. kbecciv commented on Apr 19, 2023

    @kbecciv
    Author

    Production
    Screenshot 2023-04-19 at 17 27 14

  4. changed the title [-]Web - FAB - There is no "New workspace" button in FAB menu[/-] [+]FAB - There is no "New workspace" button in FAB menu[/+] on Apr 19, 2023
  5. mountiny commented on Apr 19, 2023

    @mountiny
    Contributor

    Asking in slack here https://expensify.slack.com/archives/C01GTK53T8Q/p1681937327369879

    Seems like that the button only shows now if you dont have any Workspace created

  6. assigned and unassigned on Apr 19, 2023
  7. mountiny commented on Apr 19, 2023

    @mountiny
    Contributor

    @kbecciv this is intentional, the accounts you have tested with already had an active workspace in which case we dont show this option in the global create

    its only visible when the user has no workspace yet

    Can you please create the test which triggered this issue? Thank you!

  8. 5 remaining items

  9. mountiny commented on Apr 19, 2023

    @mountiny
    Contributor

    Lets consolidate it to the deploy blocker linked above.

  10. kbecciv commented on Apr 20, 2023

    @kbecciv
    Author

    @mountiny Re-uploaded

  11. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 20, 2023
  12. changed the title [-]FAB - There is no "New workspace" button in FAB menu[/-] [+][HOLD for payment 2023-04-27] FAB - There is no "New workspace" button in FAB menu[/+] on Apr 20, 2023
  13. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.2-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-04-27. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. changed the title [-][HOLD for payment 2023-04-27] FAB - There is no "New workspace" button in FAB menu[/-] [+][HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] FAB - There is no "New workspace" button in FAB menu[/+] on Apr 21, 2023
  16. MelvinBot commented on Apr 21, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.3-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-04-28. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions