You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-05] [$1000] Desktop - Sign in - User can not validate an account #17724
I personally think this is a regression, would appreciate if you could share your thoughts on this. : )
Disagree on it. Because I started my PR before this PR is merged. I mean 2 PR is working independently, it's hard to detect they would break each other.
In addition, because PR #19819 also fixed this issue, so I plan to remove the redirection component in my PR #17452, this can also allow us to get rid of the setTimeout.
Thanks @ntdiary . If we all agree that we don't need to use redirection page anymore, then I think it's okay to remove it.
@bondydaa because I'm the one who assigned to this issue so my suggestion might be not totally correct.
The PR #19819 had a better idea to also fix this issue. We might remove what we done here (to reduce double redirection page) but we already put effort to implement redirection page here so I hope I can get paid.
The PR #19819 had a better idea to also fix this issue. We might remove what we done here (to reduce double redirection page) but we already put effort to implement redirection page here so I hope I can get paid.
Personally, I think it's good to get the payment done and then close this issue. And I would appreciate if @hoangzinh can also help confirm that this issue does go away in my PR #17452 (without redirection page) : )
Great, I think we're all in agreement. We're going to process the payment and close this issue. @rushatgabhane@hoangzinh I've sent both of you an offer in Upworks.
Activity
MelvinBot commentedon Apr 20, 2023
Triggered auto assignment to @arielgreen (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 20, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mountiny commentedon Apr 20, 2023
@mvtglobally @kbecciv In the video, you are clicking the link which goes to production, is that not part of the problem? I am not sure
MelvinBot commentedon Apr 24, 2023
@arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
MelvinBot commentedon Apr 24, 2023
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.81 remaining items
hoangzinh commentedon Jun 6, 2023
Disagree on it. Because I started my PR before this PR is merged. I mean 2 PR is working independently, it's hard to detect they would break each other.
Thanks @ntdiary . If we all agree that we don't need to use redirection page anymore, then I think it's okay to remove it.
hoangzinh commentedon Jun 6, 2023
@bondydaa because I'm the one who assigned to this issue so my suggestion might be not totally correct.
The PR #19819 had a better idea to also fix this issue. We might remove what we done here (to reduce double redirection page) but we already put effort to implement redirection page here so I hope I can get paid.
ntdiary commentedon Jun 7, 2023
Personally, I think it's good to get the payment done and then close this issue. And I would appreciate if @hoangzinh can also help confirm that this issue does go away in my PR #17452 (without redirection page) : )
cc @tjferriss @bondydaa
tjferriss commentedon Jun 8, 2023
Great, I think we're all in agreement. We're going to process the payment and close this issue. @rushatgabhane @hoangzinh I've sent both of you an offer in Upworks.
hoangzinh commentedon Jun 9, 2023
Accepted offer. Thanks @tjferriss
rushatgabhane commentedon Jun 11, 2023
@tjferriss Applied using account "Satish Gabhane", thanks! - https://www.upwork.com/freelancers/~01212e8255b02ae924
context - https://expensify.slack.com/archives/C02NK2DQWUX/p1683614947522329
tjferriss commentedon Jun 12, 2023
@rushatgabhane @hoangzinh I've sent you both offers in Upworks.
hoangzinh commentedon Jun 13, 2023
Accepted offer. Thanks @tjferriss
tjferriss commentedon Jun 13, 2023
The payments have been made in Upworks.
hoangzinh commentedon Jun 20, 2023
@tjferriss it seems you haven't end my contract/offer in Upwork yet. Could you help to check it? Thanks
tjferriss commentedon Jun 22, 2023
@hoangzinh it now looks like the contract has ended.
hoangzinh commentedon Jun 22, 2023
it's weird. I just send you a message in Upwork so you can check the contract easily.
tjferriss commentedon Jun 23, 2023
I think I found it now and ended the contract.
hoangzinh commentedon Jun 23, 2023
Yay, thanks @tjferriss