Skip to content

[HOLD for payment 2023-06-05] [$1000] Desktop - Sign in - User can not validate an account #17724

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #17697

Action Performed:

  1. Access the Expensify Desktop app
  2. Input an email that does not exist
  3. Access the email account and tap on the link (Redirect it to the Desktop app)
  4. Input a New password

Expected Result:

User expects the password to be saved and the new account to be open

Actual Result:

The user keeps receiving an error message saying that the link has expired, making it impossible to validate an account via Desktop app.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.2.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6025598_Cant_validate_on_desktop.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016ce9697b87884431
  • Upwork Job ID: 1650976104948047872
  • Last Price Increase: 2023-05-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 20, 2023
  2. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. mountiny commented on Apr 20, 2023

    @mountiny
    Contributor

    @mvtglobally @kbecciv In the video, you are clicking the link which goes to production, is that not part of the problem? I am not sure

  5. MelvinBot commented on Apr 24, 2023

    @MelvinBot
    Contributor

    @arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 24, 2023
  7. removed their assignment
    on Apr 24, 2023
  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 24, 2023
  9. MelvinBot commented on Apr 24, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. 81 remaining items

  11. hoangzinh commented on Jun 6, 2023

    @hoangzinh
    Contributor

    I personally think this is a regression, would appreciate if you could share your thoughts on this. : )

    Disagree on it. Because I started my PR before this PR is merged. I mean 2 PR is working independently, it's hard to detect they would break each other.

    In addition, because PR #19819 also fixed this issue, so I plan to remove the redirection component in my PR #17452, this can also allow us to get rid of the setTimeout.

    Thanks @ntdiary . If we all agree that we don't need to use redirection page anymore, then I think it's okay to remove it.

  12. hoangzinh commented on Jun 6, 2023

    @hoangzinh
    Contributor

    @bondydaa because I'm the one who assigned to this issue so my suggestion might be not totally correct.

    The PR #19819 had a better idea to also fix this issue. We might remove what we done here (to reduce double redirection page) but we already put effort to implement redirection page here so I hope I can get paid.

  13. ntdiary commented on Jun 7, 2023

    @ntdiary
    Contributor

    The PR #19819 had a better idea to also fix this issue. We might remove what we done here (to reduce double redirection page) but we already put effort to implement redirection page here so I hope I can get paid.

    Personally, I think it's good to get the payment done and then close this issue. And I would appreciate if @hoangzinh can also help confirm that this issue does go away in my PR #17452 (without redirection page) : )

    cc @tjferriss @bondydaa

  14. tjferriss commented on Jun 8, 2023

    @tjferriss
    Contributor

    Great, I think we're all in agreement. We're going to process the payment and close this issue. @rushatgabhane @hoangzinh I've sent both of you an offer in Upworks.

  15. hoangzinh commented on Jun 9, 2023

    @hoangzinh
    Contributor

    Accepted offer. Thanks @tjferriss

  16. rushatgabhane commented on Jun 11, 2023

    @rushatgabhane
    Member
  17. tjferriss commented on Jun 12, 2023

    @tjferriss
    Contributor

    @rushatgabhane @hoangzinh I've sent you both offers in Upworks.

  18. hoangzinh commented on Jun 13, 2023

    @hoangzinh
    Contributor

    Accepted offer. Thanks @tjferriss

  19. tjferriss commented on Jun 13, 2023

    @tjferriss
    Contributor

    The payments have been made in Upworks.

  20. hoangzinh commented on Jun 20, 2023

    @hoangzinh
    Contributor

    @tjferriss it seems you haven't end my contract/offer in Upwork yet. Could you help to check it? Thanks

  21. tjferriss commented on Jun 22, 2023

    @tjferriss
    Contributor

    @hoangzinh it now looks like the contract has ended.

  22. hoangzinh commented on Jun 22, 2023

    @hoangzinh
    Contributor

    it's weird. I just send you a message in Upwork so you can check the contract easily.

  23. tjferriss commented on Jun 23, 2023

    @tjferriss
    Contributor

    I think I found it now and ended the contract.

  24. hoangzinh commented on Jun 23, 2023

    @hoangzinh
    Contributor

    Yay, thanks @tjferriss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions