You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-08] [$4000] mWeb - IOU - IOU details displayed cropped at the top if login via IOU link #17824
Precondition - There is an IOU present between users A & B (to create an IOU, request money from another user). Open Details Pane of the IOU and grab the URL. Make sure you are logged out on mWeb (use an incognito window).
Open IOU link in mWeb.
Login with account of user A or B
Expected Result:
IOU details are completely displayed and fit the screen
Actual Result:
IOU details are displayed cropped at the top of the screen
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.4.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1686250778229249
Determine if we should create a regression test for this bug.
I think we should, smart banners are tricky. It's going to be a small regression test, but I think it's worth having it in this case.
Activity
MelvinBot commentedon Apr 22, 2023
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)muttmuure commentedon Apr 25, 2023
Not sure how to get an IOU
muttmuure commentedon Apr 25, 2023
Moving to other issues first
muttmuure commentedon Apr 28, 2023
I'm not sure what it means to get an IOU URL, but the staging URL just doesn't open the report for me
muttmuure commentedon Apr 28, 2023
https://staging.new.expensify.com/r/1194631444748019/6533242881188324000 is the URL
muttmuure commentedon Apr 28, 2023
I asked about this here: https://expensify.slack.com/archives/C01GTK53T8Q/p1682684866137469
muttmuure commentedon Apr 28, 2023
OK there we go:

muttmuure commentedon Apr 28, 2023
I updated the OP to be more detailed about the steps as there were some assumptions that were hard to understand
96 remaining items
muttmuure commentedon Jun 8, 2023
Ready for @cubuspl42 @eVoloshchak to apply here: https://www.upwork.com/jobs/~012d0446ac84411fe0
eVoloshchak commentedon Jun 8, 2023
The PR that introduced the bug has been identified. Link to the PR: Fix/12005: Settings navigation modal leaves empty space at the bottom #12509
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/12509/files#r1223429958
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1686250778229249
Determine if we should create a regression test for this bug.
I think we should, smart banners are tricky. It's going to be a small regression test, but I think it's worth having it in this case.
eVoloshchak commentedon Jun 8, 2023
Regression Test Proposal
Safari mobile only, that's the only platform with smart banners
Do we agree 👍 or 👎
jakub-trzebiatowski commentedon Jun 9, 2023
@muttmuure Applied!
The PR was merged within 3 business days, so it should also be eligible for a bonus.
melvin-bot commentedon Jun 12, 2023
@cubuspl42, @eVoloshchak, @alex-mechler, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
muttmuure commentedon Jun 12, 2023
Offers inc. bonus sent
muttmuure commentedon Jun 15, 2023
All paid up