You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Web - Profile - Error message disappears if user refresh the page a couple times #17827
changed the title [-]Web - Error message disappears if user refresh the page a couple times[/-][+]Web - Profile - Error message disappears if user refresh the page a couple times[/+]on Apr 22, 2023
I think it is not a bug, bcoz that invalid contact method isn't added to the server yet. So on refresh we receive the fresh response from the server where that method is not available in the list and onyx updated accordingly.
Oh really? I would have thought that it's more helpful to the user to know that adding their contact method never actually worked, and they need to resolve the problem.
As @Pujan92 said, an invalid contact method won't be added to the server, which mean it only exists on the local device. When we refresh the page, we receive the list of the contact methods from server and it will override the list that exists on local device because we use SET operation of Onyx instead of MERGE.
So, if we want to keep the invalid contact method, we should change it from SET to MERGE, which should be done internally.
changed the title [-][Hold] Web - Profile - Error message disappears if user refresh the page a couple times[/-][+]Web - Profile - Error message disappears if user refresh the page a couple times[/+]on Jul 10, 2023
Activity
MelvinBot commentedon Apr 22, 2023
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 22, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Web - Error message disappears if user refresh the page a couple times[/-][+]Web - Profile - Error message disappears if user refresh the page a couple times[/+]muttmuure commentedon Apr 25, 2023
Yes this seems like a bug we would need to fix, but I need to reproduce it
Pujan92 commentedon Apr 26, 2023
I think it is not a bug, bcoz that invalid contact method isn't added to the server yet. So on refresh we receive the fresh response from the server where that method is not available in the list and onyx updated accordingly.
muttmuure commentedon Apr 28, 2023
Oh really? I would have thought that it's more helpful to the user to know that adding their contact method never actually worked, and they need to resolve the problem.
bernhardoj commentedon Apr 28, 2023
As @Pujan92 said, an invalid contact method won't be added to the server, which mean it only exists on the local device. When we refresh the page, we receive the list of the contact methods from server and it will override the list that exists on local device because we use SET operation of Onyx instead of MERGE.
So, if we want to keep the invalid contact method, we should change it from SET to MERGE, which should be done internally.
MelvinBot commentedon May 2, 2023
Job added to Upwork: https://www.upwork.com/jobs/~016de59d5ef9345e8b
26 remaining items
muttmuure commentedon Jun 19, 2023
I will put it back on hold
muttmuure commentedon Jun 28, 2023
Not overdue
muttmuure commentedon Jul 10, 2023
Not deployed yet
[-][Hold] Web - Profile - Error message disappears if user refresh the page a couple times[/-][+]Web - Profile - Error message disappears if user refresh the page a couple times[/+]muttmuure commentedon Jul 19, 2023
Will check this tomorrow
muttmuure commentedon Aug 1, 2023
Looks like this got merged!