Skip to content

Web - Profile - Error message disappears if user refresh the page a couple times #17827

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings > Profile > Contact Method
  2. Press/click New contact method
  3. Fill the email with any email that is not the current login email
  4. Press/click Add
  5. Verify there is a red dot error at the Settings avatar icon (next to Search Icon)
  6. Refresh the Page a couple times

Expected Result:

Error message does not disappear if user refresh the page a couple times

Actual Result:

Error message disappears if user refresh the page a couple times

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.4.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2564.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016de59d5ef9345e8b
  • Upwork Job ID: 1653403419329634304
  • Last Price Increase: 2023-05-02

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 22, 2023
  2. MelvinBot commented on Apr 22, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 22, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. changed the title [-]Web - Error message disappears if user refresh the page a couple times[/-] [+]Web - Profile - Error message disappears if user refresh the page a couple times[/+] on Apr 22, 2023
  5. muttmuure commented on Apr 25, 2023

    @muttmuure
    Contributor

    Yes this seems like a bug we would need to fix, but I need to reproduce it

  6. Pujan92 commented on Apr 26, 2023

    @Pujan92
    Contributor

    I think it is not a bug, bcoz that invalid contact method isn't added to the server yet. So on refresh we receive the fresh response from the server where that method is not available in the list and onyx updated accordingly.

  7. muttmuure commented on Apr 28, 2023

    @muttmuure
    Contributor

    Oh really? I would have thought that it's more helpful to the user to know that adding their contact method never actually worked, and they need to resolve the problem.

  8. bernhardoj commented on Apr 28, 2023

    @bernhardoj
    Contributor

    As @Pujan92 said, an invalid contact method won't be added to the server, which mean it only exists on the local device. When we refresh the page, we receive the list of the contact methods from server and it will override the list that exists on local device because we use SET operation of Onyx instead of MERGE.

    image

    So, if we want to keep the invalid contact method, we should change it from SET to MERGE, which should be done internally.

  9. added
    InternalRequires API changes or must be handled by Expensify staff
    on May 2, 2023
  10. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor
  11. 26 remaining items

  12. muttmuure commented on Jun 19, 2023

    @muttmuure
    Contributor

    I will put it back on hold

  13. muttmuure commented on Jun 28, 2023

    @muttmuure
    Contributor

    Not overdue

  14. muttmuure commented on Jul 10, 2023

    @muttmuure
    Contributor

    Not deployed yet

  15. changed the title [-][Hold] Web - Profile - Error message disappears if user refresh the page a couple times[/-] [+]Web - Profile - Error message disappears if user refresh the page a couple times[/+] on Jul 10, 2023
  16. muttmuure commented on Jul 19, 2023

    @muttmuure
    Contributor

    Will check this tomorrow

  17. muttmuure commented on Aug 1, 2023

    @muttmuure
    Contributor

    Looks like this got merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions