Skip to content

[HOLD for payment 2023-08-24] [$1000] IOS - Chat - Focus is lost if user inserts emoji in edit mode using emoji picker #18001

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App and open any chat
  2. Post message in chat
  3. Long tap on message and select 'Edit message'
  4. Insert emoji in message using emoji picker

Expected Result:

Emoji inserted and focus is in composer

Actual Result:

Emoji inserted and focus is lost

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.5.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6032214_iPad-emoji-insert-focus-lost.mp4
Bug6032214_iOS-emoji-insert-focus-lost.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01186303df75f9ce05
  • Upwork Job ID: 1681682595455336448
  • Last Price Increase: 2023-07-19

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 26, 2023
  2. MelvinBot commented on Apr 26, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 26, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. sophiepintoraetz commented on Apr 27, 2023

    @sophiepintoraetz
    Contributor

    Closing and adding to the tracking issue.

  5. sophiepintoraetz commented on Apr 27, 2023

    @sophiepintoraetz
    Contributor

    This might also be solved by this #15992

  6. lanitochka17 commented on Jul 15, 2023

    @lanitochka17

    Issue is reproducible in mWeb/Safari. Build 1.3.41.2

    22542.mWeb.Lost.Focus.mp4
  7. mountiny commented on Jul 17, 2023

    @mountiny
    Contributor

    @perunt Could this PR #18001 reintroduce this issue?

  8. perunt commented on Jul 17, 2023

    @perunt
    Contributor

    @mountiny, you referred to the same issue. Is it the correct link?

  9. mountiny commented on Jul 17, 2023

    @mountiny
    Contributor

    @perunt Sorry, QA linked to this issue #18001

  10. melvin-bot commented on Jul 18, 2023

    @melvin-bot

    @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. 39 remaining items

  12. melvin-bot commented on Aug 17, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Aug 17, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-24. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Aug 17, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. sophiepintoraetz commented on Aug 27, 2023

    @sophiepintoraetz
    Contributor

    Payouts due:

    Issue Reporter: $250 NA
    Contributor: $1000 @kosmydel
    Contributor+: $1000 @situchan (offer sent - I'll release payment once the checklist is done!)

    Eligible for 50% #urgency bonus? @mountiny - I don't think this one is eligible for a bonus, right? @kosmydel was assigned 20 Jul and the PR was merged on 11 Aug

  16. situchan commented on Aug 28, 2023

    @situchan
    Contributor

    No PR caused regression. This was default iOS behavior in RN modal.
    The solution applied here was actually workaround which inherits main composer's setTimeout solution.
    This workaround was completely removed in #13922 by fixing iOS native code in RN modal and I will add full regression test step in that issue.
    So we can simply skip checklist here.

  17. mountiny commented on Aug 28, 2023

    @mountiny
    Contributor

    Yeah no bonus here I imagine

  18. sophiepintoraetz commented on Aug 29, 2023

    @sophiepintoraetz
    Contributor

    Payments done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions