Skip to content

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-12] [$1000] Attachment Carousel closes on its own when a specific image is deleted #18451

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Have a chat with 2 users (User A, User B)
  2. Have a few attachments posted by User B (Attachment 1, 2, 3)
  3. Make User A press and open the latest attachment (Attachment 3)
  4. Make User B delete Attachment 3

Expected result:

Nothing disruptive should happen to User A’s experience. They continue to see that attachment until they close the window

Actual result:

The whole attachment modal/carousel abruptly closes (even if they scrolled to another image)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.10
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/236339219-067cdc95-1b40-4b29-9d3b-4da0cbbf4650.mov

Recording.492.mp4

Expensify/Expensify Issue URL:
Issue reported by: @kidroca
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683212386358629

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01afedd756887cbd8d
  • Upwork Job ID: 1655921750675152896
  • Last Price Increase: 2023-05-09

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 4, 2023
  2. melvin-bot commented on May 4, 2023

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 4, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on May 8, 2023

    @melvin-bot

    @flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 9, 2023
  6. changed the title [-]Attachment Carousel closes on it’s own when a specific image is deleted[/-] [+][$1000] Attachment Carousel closes on it’s own when a specific image is deleted[/+] on May 9, 2023
  7. melvin-bot commented on May 9, 2023

    @melvin-bot
  8. melvin-bot commented on May 9, 2023

    @melvin-bot

    Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on May 9, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 9, 2023
  11. 73 remaining items

  12. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@chiragsalian / @NikkiWines] The PR that introduced the bug has been identified. Link to the PR:
      • In this case the AttachmentModal has always lived within the ImageRenderer.js since we added it here - there isn't really anything we could've done to prevent this as it's been the case since this functionality was added.
    • [@chiragsalian / @NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A see above
    • [@chiragsalian / @NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A see above
    • [@kidroca] Determine if we should create a regression test for this bug.
    • [@kidroca] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. flaviadefaria commented on Jul 14, 2023

    @flaviadefaria
    Contributor

    @kidroca please fill out the checklist above so that i can process the payment - thanks!

  14. kidroca commented on Jul 14, 2023

    @kidroca
    Contributor

    Thanks for the bump @flaviadefaria

    I don't think we need a regression test, because the component structure and usage changed in a way that prevents this kind of bug from happening again, furthermore it's rare, it's not super easy to test and it does not affect important functionality

  15. flaviadefaria commented on Jul 17, 2023

    @flaviadefaria
    Contributor

    Ok this is what I think needs to be issued as payment:

    Merged PR more than 9 business days after assignment - 50% penalty

    @kidroca = $1000 - 50% penalty = $500
    @allroundexperts = $1000 - 50% penalty = $500

    It seems fair to me to remove the penalty due to the initial C+ getting sick so will issue payment for the full $1000 for each of you.

    @allroundexperts do you request payment via Expensify or should I pay you via UpWork?

  16. flaviadefaria commented on Jul 17, 2023

    @flaviadefaria
    Contributor

    @kidroca I just sent you an offer. I also just realized you reported this bug so will issue a bonus of $250 to account for that once you accept the offer.

  17. allroundexperts commented on Jul 17, 2023

    @allroundexperts
    Contributor

    @allroundexperts do you request payment via Expensify or should I pay you via UpWork?

    Expensify works for me. Thanks @flaviadefaria!

  18. anmurali commented on Jul 17, 2023

    @anmurali
  19. flaviadefaria commented on Jul 18, 2023

    @flaviadefaria
    Contributor

    @kidroca you've also been paid. Closing this as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions