You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-12] [$1000] Attachment Carousel closes on its own when a specific image is deleted #18451
changed the title [-]Attachment Carousel closes on it’s own when a specific image is deleted[/-][+][$1000] Attachment Carousel closes on it’s own when a specific image is deleted[/+]on May 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@chiragsalian / @NikkiWines] The PR that introduced the bug has been identified. Link to the PR:
In this case the AttachmentModal has always lived within the ImageRenderer.js since we added it here - there isn't really anything we could've done to prevent this as it's been the case since this functionality was added.
[@chiragsalian / @NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A see above
[@chiragsalian / @NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A see above
[@kidroca] Determine if we should create a regression test for this bug.
[@kidroca] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
I don't think we need a regression test, because the component structure and usage changed in a way that prevents this kind of bug from happening again, furthermore it's rare, it's not super easy to test and it does not affect important functionality
@kidroca I just sent you an offer. I also just realized you reported this bug so will issue a bonus of $250 to account for that once you accept the offer.
Activity
melvin-bot commentedon May 4, 2023
Triggered auto assignment to @flaviadefaria (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 4, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon May 8, 2023
@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Attachment Carousel closes on it’s own when a specific image is deleted[/-][+][$1000] Attachment Carousel closes on it’s own when a specific image is deleted[/+]melvin-bot commentedon May 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01afedd756887cbd8d
melvin-bot commentedon May 9, 2023
Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)73 remaining items
melvin-bot commentedon Jul 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
flaviadefaria commentedon Jul 14, 2023
@kidroca please fill out the checklist above so that i can process the payment - thanks!
kidroca commentedon Jul 14, 2023
Thanks for the bump @flaviadefaria
I don't think we need a regression test, because the component structure and usage changed in a way that prevents this kind of bug from happening again, furthermore it's rare, it's not super easy to test and it does not affect important functionality
flaviadefaria commentedon Jul 17, 2023
Ok this is what I think needs to be issued as payment:
@kidroca = $1000 - 50% penalty = $500
@allroundexperts = $1000 - 50% penalty = $500
It seems fair to me to remove the penalty due to the initial C+ getting sick so will issue payment for the full $1000 for each of you.
@allroundexperts do you request payment via Expensify or should I pay you via UpWork?
flaviadefaria commentedon Jul 17, 2023
@kidroca I just sent you an offer. I also just realized you reported this bug so will issue a bonus of $250 to account for that once you accept the offer.
allroundexperts commentedon Jul 17, 2023
Expensify works for me. Thanks @flaviadefaria!
anmurali commentedon Jul 17, 2023
@allroundexperts is paid
flaviadefaria commentedon Jul 18, 2023
@kidroca you've also been paid. Closing this as complete.