Skip to content

[HOLD for payment 2024-02-20] [$1000] [Polish] Add limit on length of task names, room names, etc.  #18647

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any Expensifail account
  3. Go to FAB -> Assign task
  4. Start typing the title and note that there is no symbol limit

Expected Result:

After discussion in Slack, we want to make the following field limit updates:

Titles (100 characters):

  • Workspace name
  • Task name
  • Room name

Supporting messages (500 characters):

  • Request description
  • Room welcome message
  • Task description

Actual Result:

There is no limit on the length of the title.
Same behavior for Description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6048269_Recording__4480.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018a42c5fcacc50150
  • Upwork Job ID: 1686014963280871424
  • Last Price Increase: 2023-07-31
  • Automatic offers:
    • dhairyasenjaliya | Contributor | 26010517

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 9, 2023
  2. melvin-bot commented on May 9, 2023

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 9, 2023

    @melvin-bot
  4. joekaufmanexpensify commented on May 9, 2023

    @joekaufmanexpensify
  5. allroundexperts commented on May 9, 2023

    @allroundexperts
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Assign Task field does not have limit on length

    What is the root cause of that problem?

    We don't have maxLength defined for the input here.

    What changes do you think we should make in order to solve the problem?

    We should add a maxLength attribute with the required length that we want to restrict the users to here.

    What alternative solutions did you explore? (Optional)

    None

  6. dhairyasenjaliya commented on May 9, 2023

    @dhairyasenjaliya
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • Assign Task - There is no limit on the length of the title 

    What is the root cause of that problem?

    • The root cause is we have not add any maxLength or any validation to check before form submission

    What changes do you think we should make in order to solve the problem?

    • The problem not only exists on New task page we need to modify this all files NewTaskDetailsPage.js , NewTaskTitlePage.js, NewTaskTitlePage.js , TaskTitlePage.js , NewTaskDescriptionPage.js , TaskDescriptionPage.js

    • To fix the problem we have 2 ways to solve 


    solution 1

    • We can add maxLength (need to define limit) to both the field title and description which are inputID="taskTitle” and inputID="description" on all the above mentioned pages that are affected by infinite character limit

    solution 2

    • Since we are using <Form> on validate() function we can just check length of the both field and based on that we can direct display error

    What alternative solutions did you explore? (Optional)

    • None
  7. joekaufmanexpensify commented on May 10, 2023

    @joekaufmanexpensify
  8. joekaufmanexpensify commented on May 11, 2023

    @joekaufmanexpensify
    Contributor

    Okay, we discussed this in Slack here, and I confirmed this is not a bug. We just didn't build this.

    While it prob makes sense to add a limit at some point, we decided we don't need to prioritize this and it can be polish. Particularly because:

    • We also don't have a limit for room names, and this has caused no issues so far.
    • We don't allow multiple characters by holding down a key in the app. So if someone wants to make a task that's 100 characters long, they need to type 100 keys. It doesn't feel super realistic that a user would intentionally make a room or task name that's longer than any limit we decided to set.

    When we do ultimately decide to do this, we'll want to consider all of the areas that don't have a limit, like task name, room name, etc. and add a limit to all of them.

  9. changed the title [-]Assign Task - There is no limit on the length of the title[/-] [+][Polish] Add limit on length of task names, room names, etc. [/+] on May 11, 2023
  10. added
    NewFeatureSomething to build that is a new item.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 11, 2023
  11. melvin-bot commented on May 11, 2023

    @melvin-bot

    Current assignee @joekaufmanexpensify is eligible for the NewFeature assigner, not assigning anyone new.

  12. 229 remaining items

  13. joekaufmanexpensify commented on Feb 19, 2024

    @joekaufmanexpensify
    Contributor

    Payment due soon

  14. mananjadhav commented on Feb 19, 2024

    @mananjadhav
    Collaborator

    @joekaufmanexpensify We have got multiple test cases for this one. I think we can reuse the ones mentioned in the Test steps of the PR.

    There won't be any offending PR as this was more of a feature request.

  15. joekaufmanexpensify commented on Feb 20, 2024

    @joekaufmanexpensify
    Contributor

    Sounds good! Regression test issue shared above.

  16. joekaufmanexpensify commented on Feb 20, 2024

    @joekaufmanexpensify
    Contributor

    All set to issue payment here. We need to issue the following payments for this one:

  17. joekaufmanexpensify commented on Feb 20, 2024

    @joekaufmanexpensify
    Contributor

    @dhairyasenjaliya $1000 sent and contract ended!

  18. joekaufmanexpensify commented on Feb 20, 2024

    @joekaufmanexpensify
    Contributor

    @mananjadhav could you please request $1000 via NewDot and confirm once complete?

  19. mananjadhav commented on Feb 21, 2024

    @mananjadhav
    Collaborator

    Done @joekaufmanexpensify. Thanks for the bump.

  20. joekaufmanexpensify commented on Feb 21, 2024

    @joekaufmanexpensify
    Contributor

    Awesome. TY! Closing as this is all set. Thanks everyone!

  21. JmillsExpensify commented on Feb 27, 2024

    @JmillsExpensify
    Contributor

    $1,000 approved for @mananjadhav based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions