You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-20] [$1000] [Polish] Add limit on length of task names, room names, etc. #18647
Please re-state the problem that we are trying to solve in this issue.
Assign Task - There is no limit on the length of the title
What is the root cause of that problem?
The root cause is we have not add any maxLength or any validation to check before form submission
What changes do you think we should make in order to solve the problem?
The problem not only exists on New task page we need to modify this all files NewTaskDetailsPage.js , NewTaskTitlePage.js, NewTaskTitlePage.js , TaskTitlePage.js , NewTaskDescriptionPage.js , TaskDescriptionPage.js
To fix the problem we have 2 ways to solve
solution 1
We can add maxLength (need to define limit) to both the field title and description which are inputID="taskTitle” and inputID="description" on all the above mentioned pages that are affected by infinite character limit
solution 2
Since we are using <Form> on validate() function we can just check length of the both field and based on that we can direct display error
What alternative solutions did you explore? (Optional)
Okay, we discussed this in Slack here, and I confirmed this is not a bug. We just didn't build this.
While it prob makes sense to add a limit at some point, we decided we don't need to prioritize this and it can be polish. Particularly because:
We also don't have a limit for room names, and this has caused no issues so far.
We don't allow multiple characters by holding down a key in the app. So if someone wants to make a task that's 100 characters long, they need to type 100 keys. It doesn't feel super realistic that a user would intentionally make a room or task name that's longer than any limit we decided to set.
When we do ultimately decide to do this, we'll want to consider all of the areas that don't have a limit, like task name, room name, etc. and add a limit to all of them.
changed the title [-]Assign Task - There is no limit on the length of the title[/-][+][Polish] Add limit on length of task names, room names, etc. [/+]on May 11, 2023
Activity
melvin-bot commentedon May 9, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 9, 2023
joekaufmanexpensify commentedon May 9, 2023
allroundexperts commentedon May 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Assign Task field does not have limit on length
What is the root cause of that problem?
We don't have
maxLengthdefined for the input here.What changes do you think we should make in order to solve the problem?
We should add a
maxLengthattribute with the required length that we want to restrict the users to here.What alternative solutions did you explore? (Optional)
None
dhairyasenjaliya commentedon May 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
The problem not only exists on
New taskpage we need to modify this all filesNewTaskDetailsPage.js,NewTaskTitlePage.js,NewTaskTitlePage.js,TaskTitlePage.js,NewTaskDescriptionPage.js,TaskDescriptionPage.jsTo fix the problem we have 2 ways to solve
solution 1
maxLength(need to define limit) to both the fieldtitleanddescriptionwhich areinputID="taskTitle”andinputID="description"on all the above mentioned pages that are affected by infinite character limitsolution 2
<Form>onvalidate()function we can just check length of the both field and based on that we can direct display errorWhat alternative solutions did you explore? (Optional)
joekaufmanexpensify commentedon May 10, 2023
joekaufmanexpensify commentedon May 11, 2023
Okay, we discussed this in Slack here, and I confirmed this is not a bug. We just didn't build this.
While it prob makes sense to add a limit at some point, we decided we don't need to prioritize this and it can be polish. Particularly because:
When we do ultimately decide to do this, we'll want to consider all of the areas that don't have a limit, like task name, room name, etc. and add a limit to all of them.
[-]Assign Task - There is no limit on the length of the title[/-][+][Polish] Add limit on length of task names, room names, etc. [/+]melvin-bot commentedon May 11, 2023
Current assignee @joekaufmanexpensify is eligible for the NewFeature assigner, not assigning anyone new.
229 remaining items
joekaufmanexpensify commentedon Feb 19, 2024
Payment due soon
mananjadhav commentedon Feb 19, 2024
@joekaufmanexpensify We have got multiple test cases for this one. I think we can reuse the ones mentioned in the Test steps of the PR.
There won't be any offending PR as this was more of a feature request.
joekaufmanexpensify commentedon Feb 20, 2024
Sounds good! Regression test issue shared above.
joekaufmanexpensify commentedon Feb 20, 2024
All set to issue payment here. We need to issue the following payments for this one:
joekaufmanexpensify commentedon Feb 20, 2024
@dhairyasenjaliya $1000 sent and contract ended!
joekaufmanexpensify commentedon Feb 20, 2024
@mananjadhav could you please request $1000 via NewDot and confirm once complete?
mananjadhav commentedon Feb 21, 2024
Done @joekaufmanexpensify. Thanks for the bump.
joekaufmanexpensify commentedon Feb 21, 2024
Awesome. TY! Closing as this is all set. Thanks everyone!
JmillsExpensify commentedon Feb 27, 2024
$1,000 approved for @mananjadhav based on summary above.