Skip to content

[HOLD for payment 2023-06-05] [$1000] An overlapped skeleton UI in the payment details section #19442

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on FAB icon
  2. Click on 'Send money'
  3. Enter amount & click on 'Next' button
  4. Search user
  5. Select user
  6. Click on 'I will settle up elsewhere' button
  7. Click on settled up message
  8. Click on the sent money preview component

Expected Result:

The rows of the skeleton UI shouldn't be overlapped

Actual Result:

The rows of the skeleton UI are overlapped

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.17
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Annotation 2023-05-19 152438

2023-05-19.15.22.18.mp4
az_recorder_20230523_093326.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684499328591959

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01faa2727c8013d2a4
  • Upwork Job ID: 1661352382463225856
  • Last Price Increase: 2023-05-24

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 23, 2023
  2. melvin-bot commented on May 23, 2023

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 23, 2023

    @melvin-bot
  4. hungvu193 commented on May 23, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    An overlapped skeleton UI in the payment details section

    What is the root cause of that problem?

    The problem came from here:

    const possibleVisibleContentItems = Math.ceil(props.containerHeight / CONST.CHAT_SKELETON_VIEW.AVERAGE_ROW_HEIGHT);

    When the header view of request money takes a lot of space, Math.celi return a greater number, which make the remaining space couldn't be enough for all the skeleton.

    What changes do you think we should make in order to solve the problem?

    Instead of using Math.celi, we should use Math.floor to calculate the number of skeleton lines.

    const possibleVisibleContentItems = Math.floor(props.containerHeight / CONST.CHAT_SKELETON_VIEW.AVERAGE_ROW_HEIGHT);

    What alternative solutions did you explore? (Optional)

    N/A.

  5. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2023
  6. removed their assignment
    on May 24, 2023
  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2023
  8. melvin-bot commented on May 24, 2023

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. melvin-bot commented on May 24, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  10. conorpendergrast commented on May 24, 2023

    @conorpendergrast
    Contributor

    Reproduced on Mac OSX Chrome 👍

  11. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 24, 2023
  12. changed the title [-]An overlapped skeleton UI in the payment details section[/-] [+][$1000] An overlapped skeleton UI in the payment details section[/+] on May 24, 2023
  13. 28 remaining items

  14. melvin-bot commented on May 29, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 29, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-05. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on May 29, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. s77rt commented on May 30, 2023

    @s77rt
    Member
  18. parasharrajat commented on May 30, 2023

    @parasharrajat
    Member

    Did we confirm the design with the design team?

    The skeleton preset should start from the header end edge. This was the case when it was built. It is always good to request reviews from the design team for design related problems.

  19. dangrous commented on Jun 2, 2023

    @dangrous
    Contributor

    Hm @shawnborton what do you think? For payment details chats, should the skeleton UI be aligned to the bottom (like the chats actually show up) or to the top (like other chats)? Could sort of go either way.

  20. shawnborton commented on Jun 5, 2023

    @shawnborton
    Contributor

    I don't feel strongly either, I would say let's just be consistent with what we do with other chats.

  21. conorpendergrast commented on Jun 6, 2023

    @conorpendergrast
    Contributor

    I'm gonna get this paid tomorrow, haven't forgotten about it

  22. conorpendergrast commented on Jun 7, 2023

    @conorpendergrast
    Contributor

    Paid everyone 👍

    @dangrous Can you open a new issue for that design change?

  23. dangrous commented on Aug 15, 2023

    @dangrous
    Contributor

    Oops, I never actually made the issue. To confirm the plan - @shawnborton - Should I create an issue to make the payment details skeleton UI aligned to the top to match how we see other chats?

  24. shawnborton commented on Aug 16, 2023

    @shawnborton
    Contributor

    I guess at this point a payment details view is just a thread, and a thread is just another kind of chat. So yeah, whatever we do with other chats, we should be consistent with the payment details. Let me know if that's helpful!

  25. dangrous commented on Aug 16, 2023

    @dangrous
    Contributor

    See linked issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions