You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-05] [$1000] An overlapped skeleton UI in the payment details section #19442
The rows of the skeleton UI shouldn't be overlapped
Actual Result:
The rows of the skeleton UI are overlapped
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.17 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
When the header view of request money takes a lot of space, Math.celi return a greater number, which make the remaining space couldn't be enough for all the skeleton.
What changes do you think we should make in order to solve the problem?
Instead of using Math.celi, we should use Math.floor to calculate the number of skeleton lines.
changed the title [-]An overlapped skeleton UI in the payment details section[/-][+][$1000] An overlapped skeleton UI in the payment details section[/+]on May 24, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The skeleton preset should start from the header end edge. This was the case when it was built. It is always good to request reviews from the design team for design related problems.
Hm @shawnborton what do you think? For payment details chats, should the skeleton UI be aligned to the bottom (like the chats actually show up) or to the top (like other chats)? Could sort of go either way.
Oops, I never actually made the issue. To confirm the plan - @shawnborton - Should I create an issue to make the payment details skeleton UI aligned to the top to match how we see other chats?
I guess at this point a payment details view is just a thread, and a thread is just another kind of chat. So yeah, whatever we do with other chats, we should be consistent with the payment details. Let me know if that's helpful!
Activity
melvin-bot commentedon May 23, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 23, 2023
hungvu193 commentedon May 23, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
An overlapped skeleton UI in the payment details section
What is the root cause of that problem?
The problem came from here:
App/src/components/ReportActionsSkeletonView/index.js
Line 20 in b424edc
When the header view of request money takes a lot of space, Math.celi return a greater number, which make the remaining space couldn't be enough for all the skeleton.
What changes do you think we should make in order to solve the problem?
Instead of using Math.celi, we should use Math.floor to calculate the number of skeleton lines.
What alternative solutions did you explore? (Optional)
N/A.
melvin-bot commentedon May 24, 2023
Triggered auto assignment to @conorpendergrast (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)conorpendergrast commentedon May 24, 2023
Reproduced on Mac OSX Chrome 👍
[-]An overlapped skeleton UI in the payment details section[/-][+][$1000] An overlapped skeleton UI in the payment details section[/+]28 remaining items
melvin-bot commentedon May 29, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 29, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon May 30, 2023
parasharrajat commentedon May 30, 2023
Did we confirm the design with the design team?
The skeleton preset should start from the header end edge. This was the case when it was built. It is always good to request reviews from the design team for design related problems.
dangrous commentedon Jun 2, 2023
Hm @shawnborton what do you think? For payment details chats, should the skeleton UI be aligned to the bottom (like the chats actually show up) or to the top (like other chats)? Could sort of go either way.
shawnborton commentedon Jun 5, 2023
I don't feel strongly either, I would say let's just be consistent with what we do with other chats.
conorpendergrast commentedon Jun 6, 2023
I'm gonna get this paid tomorrow, haven't forgotten about it
conorpendergrast commentedon Jun 7, 2023
Paid everyone 👍
@dangrous Can you open a new issue for that design change?
dangrous commentedon Aug 15, 2023
Oops, I never actually made the issue. To confirm the plan - @shawnborton - Should I create an issue to make the payment details skeleton UI aligned to the top to match how we see other chats?
shawnborton commentedon Aug 16, 2023
I guess at this point a payment details view is just a thread, and a thread is just another kind of chat. So yeah, whatever we do with other chats, we should be consistent with the payment details. Let me know if that's helpful!
dangrous commentedon Aug 16, 2023
See linked issue!