Skip to content

[HOLD for payment 2023-06-07] [HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline #19702

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #18454

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to Settings -> Workspaces -> Open any WS -> Reimbursements -> Rate
  4. Turn off the internet connection
  5. Change rate and unit value -> Save

Expected Result:

The new rate is grey out in Reimbursements page

Actual Result:

The new rate is not grey out in Reimbursements page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: Yes

Reproducible in production?: new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/310d0478d0a3bcb69df82330bcb4b5441ec5bc4eeb4398616079c3090c6550bd

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 26, 2023
  2. melvin-bot commented on May 26, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 26, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hoangzinh commented on May 26, 2023

    @hoangzinh
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reimbursements - The new rate is not grey out when it was changed offline

    What is the root cause of that problem?

    Current we don't wrap distanceRate inside a OfflineWithFeedback component in the workspace reimburse view => It won't show grey when it was changed offline

    What changes do you think we should make in order to solve the problem?

    We need to wrap distanceRate inside a OfflineWithFeedback component. pendingAction props will be passed same as here

    Result:
    Screenshot 2023-05-27 at 06 07 16

  5. sakluger commented on May 27, 2023

    @sakluger
    Contributor

    Verified on production that we currently gray out the fields if they are changed while offline:

    image
  6. sakluger commented on May 27, 2023

    @sakluger
    Contributor

    I commented on the PR.

  7. ShogunFire commented on May 29, 2023

    @ShogunFire
    Contributor

    I am going to do a PR for this

  8. luacmartins commented on May 29, 2023

    @luacmartins
    Contributor

    I'm addressing this issue in #19748

  9. self-assigned this
    on May 29, 2023
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 29, 2023
  11. 5 remaining items

  12. changed the title [-][HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline[/-] [+][HOLD for payment 2023-06-07] [HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline[/+] on May 31, 2023
  13. melvin-bot commented on May 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on May 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Save button for rate and unit #18454
    • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: author is aware and left many comments on the related issues
    • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: current checklist already covers this
    • [@luacmartins] Determine if we should create a regression test for this bug. N/A this was caught in regression test
    • [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. luacmartins commented on May 31, 2023

    @luacmartins
    Contributor

    Checklist complete

  16. luacmartins commented on Jun 7, 2023

    @luacmartins
    Contributor

    @sakluger are we still waiting on payment?

  17. luacmartins commented on Jun 12, 2023

    @luacmartins
    Contributor

    Actually, there are no payments due here since:

    • Reporter is Applause
    • This was a regression from a contributor's PR, but I submitted a fix
    • C+ didn't review the PR

    Gonna close. Please reopen if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions