You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-07] [HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline #19702
Please re-state the problem that we are trying to solve in this issue.
Reimbursements - The new rate is not grey out when it was changed offline
What is the root cause of that problem?
Current we don't wrap distanceRate inside a OfflineWithFeedback component in the workspace reimburse view => It won't show grey when it was changed offline
What changes do you think we should make in order to solve the problem?
We need to wrap distanceRate inside a OfflineWithFeedback component. pendingAction props will be passed same as here
changed the title [-][HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline[/-][+][HOLD for payment 2023-06-07] [HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline[/+]on May 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: author is aware and left many comments on the related issues
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: current checklist already covers this
[@luacmartins] Determine if we should create a regression test for this bug. N/A this was caught in regression test
[@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon May 26, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hoangzinh commentedon May 26, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Reimbursements - The new rate is not grey out when it was changed offline
What is the root cause of that problem?
Current we don't wrap distanceRate inside a
OfflineWithFeedbackcomponent in the workspace reimburse view => It won't show grey when it was changed offlineWhat changes do you think we should make in order to solve the problem?
We need to wrap distanceRate inside a
OfflineWithFeedbackcomponent.pendingActionprops will be passed same as hereResult:

sakluger commentedon May 27, 2023
Verified on production that we currently gray out the fields if they are changed while offline:
sakluger commentedon May 27, 2023
I commented on the PR.
ShogunFire commentedon May 29, 2023
I am going to do a PR for this
luacmartins commentedon May 29, 2023
I'm addressing this issue in #19748
5 remaining items
[-][HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline[/-][+][HOLD for payment 2023-06-07] [HOLD for payment 2023-06-05] Reimbursements - The new rate is not grey out when it was changed offline[/+]melvin-bot commentedon May 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
luacmartins commentedon May 31, 2023
Checklist complete
luacmartins commentedon Jun 7, 2023
@sakluger are we still waiting on payment?
luacmartins commentedon Jun 12, 2023
Actually, there are no payments due here since:
Gonna close. Please reopen if I missed anything.