You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-22] [Feature request] Replace the moment library with some lightweight date utility library #19810
Coming from this Slack thread and Callstack proposal.
The moment library is a powerful library but has performance disadvantages that comes from its OOP design. This design makes it fail working with tree-shaking, so it’s bundle size it’s huge (especially with internalisation or timezone support enabled) - this impacts mostly the web version of Expensify app.
Moreover, the moment library is now a “legacy project in maintenance mode” so it is not actively developed anymore.
There are some other powerful yet lightweight date libraries like day.js (the most lightweight) or date-fns (supports tree-shaking) that could successfully replace the moment library in our app. My personal preference is date-fns because of its support for tree-shaking and wider popularity among community, but using day.js may be easier from the Expensify codebase perspective because of its API that is quite similar to the moment one (e.g. parsing date strings using constructor or day/month/year getters etc. - please check the link I’ve posted below for more details).
Hey @mountiny! Sorry for being silent in this issue - I'm 100% involved in the Secure Logins issue (migration to use accountID's instead of emails in personal details) right now and had no time for anything else. I'll do my best to share some plan for this issue today or on Monday.
changed the title [-][Feature request] Replace the moment library with some lightweight date utility library[/-][+][HOLD for payment 2023-11-22] [Feature request] Replace the moment library with some lightweight date utility library[/+]on Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Activity
melvin-bot commentedon May 30, 2023
Triggered auto assignment to @anmurali (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.mountiny commentedon May 30, 2023
No need to action here now Anu, Callstack will work on this
burczu commentedon May 30, 2023
Hey! It's Bartek from Callstack - expert contributor group - I'll be working on this one.
mountiny commentedon May 30, 2023
Thanks, please, first post a plan of how to exectute this migration before you go ahead.
mountiny commentedon Jun 7, 2023
@burczu would you be bale to share a plan for this project and some ETA, thanks!
burczu commentedon Jun 9, 2023
Hey @mountiny! Sorry for being silent in this issue - I'm 100% involved in the Secure Logins issue (migration to use accountID's instead of emails in personal details) right now and had no time for anything else. I'll do my best to share some plan for this issue today or on Monday.
96 remaining items
mountiny commentedon Nov 14, 2023
Thanks for continued work on this ❤️
[-][Feature request] Replace the moment library with some lightweight date utility library[/-][+][HOLD for payment 2023-11-22] [Feature request] Replace the moment library with some lightweight date utility library[/+]melvin-bot commentedon Nov 15, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 15, 2023
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Nov 16, 2023
@allroundexperts could you please summarize what needs to be paid here to you, it was couple of PRs.
No Testrail cases are needed fo this, it was a migration of a package for performance reasons and no new behaviour has been added in this issue
allroundexperts commentedon Nov 26, 2023
Hi @mountiny!
It's been a long issue but I've tried to summarise the payment below. Please let me know if I missed something.
mountiny commentedon Nov 27, 2023
Sounds good to me, Could you please request $1625 on NewDot and note here, then we can close this issue. Thanks!
allroundexperts commentedon Nov 27, 2023
All done @mountiny!
mountiny commentedon Nov 28, 2023
Thanks, we should be all good here and we can close, thanks @waterim and @burczu and @allroundexperts for the effort here
JmillsExpensify commentedon Dec 13, 2023
$1,625 payment approved based on this comment.