Skip to content

LOW: [$500] Selection List Refactor: Simple Selection List #20354

Closed

Description

@thiagobrez

This issue keeps track of Phase 3 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:

  • Phase 1: Radio Button List
  • Phase 2: Checkbox List
  • Phase 3: Simple Selection List (this phase)

Thoroughly discussed in the parent issue: #11795 (comment)

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a737edd58e0c740d
  • Upwork Job ID: 1698702807486967808
  • Last Price Increase: 2023-09-04
Issue OwnerCurrent Issue Owner: @cristipaval

Activity

  1. self-assigned this
    on Jun 7, 2023
  2. thiagobrez commented on Jun 30, 2023

    @thiagobrez
    ContributorAuthor

    I imagine I will be able to start on this next week.

  3. cristipaval commented on Jun 30, 2023

    @cristipaval
    Contributor

    I forgot to assign you to the issue, @thiagobrez . Sorry for that

  4. cristipaval commented on Jul 11, 2023

    @cristipaval
    Contributor

    I'll set this one on hold until the second phase is done.

  5. changed the title [-]Selection List Refactor: Simple Selection List[/-] [+][HOLD App issue #20353] Selection List Refactor: Simple Selection List[/+] on Jul 11, 2023
  6. thiagobrez commented on Jul 14, 2023

    @thiagobrez
    ContributorAuthor

    Starting to investigate this today, while second phase PR is in review

  7. thiagobrez commented on Jul 14, 2023

    @thiagobrez
    ContributorAuthor

    Good news, these lists are fitting well with the new components. Group members list is ready

  8. 232 remaining items

  9. quinthar commented on May 12, 2024

    @quinthar
    Contributor

    Should this be closed? If not, what is the next step, who is doing it, and when?

  10. MrMuzyk commented on May 13, 2024

    @MrMuzyk
    Contributor

    @quinthar Hey, so we have a PR that is waiting to be reviewed and tested again. After this is merged then whole refactor is complete and this issue can be closed.

    Note: PR has been opened for 3 weeks now but it was hanging due to merge freeze I guess. In the meantime a new feature has been merged (uneven splits) that did some major changes in the refactored component and added a new feature to deprecated component that was being removed in this PR. I had to start pretty much from scratch thus the request to review and test it again before merging.

  11. rushatgabhane commented on May 13, 2024

    @rushatgabhane
    Member

    yep, it was reviewed 2 weeks ago but then a new feature was added in the deprecated component. Need to re-review now

  12. melvin-bot commented on May 15, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. melvin-bot commented on May 15, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. melvin-bot commented on May 15, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. melvin-bot commented on May 16, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. melvin-bot commented on May 16, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @JmillsExpensify, @cristipaval, @rushatgabhane, @lukemorawski eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  17. JmillsExpensify commented on May 19, 2024

    @JmillsExpensify
    Contributor

    Can we close this issue out yet?

  18. MrMuzyk commented on May 20, 2024

    @MrMuzyk
    Contributor

    Refactor is complete. I'm fine closing it.

  19. laurenreidexpensify commented on May 31, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

    C+ Review

    @rushatgabhane

    Total: $4500

    Payment Method: Please request in Newdot

    Contributor

    @lukemorawski Agency contributor, no payment owed

  20. JmillsExpensify commented on May 31, 2024

    @JmillsExpensify
    Contributor

    $4,5000 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.MonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions