You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
LOW: [$500] Selection List Refactor: Simple Selection List #20354
This issue keeps track of Phase 3 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:
@quinthar Hey, so we have a PR that is waiting to be reviewed and tested again. After this is merged then whole refactor is complete and this issue can be closed.
Note: PR has been opened for 3 weeks now but it was hanging due to merge freeze I guess. In the meantime a new feature has been merged (uneven splits) that did some major changes in the refactored component and added a new feature to deprecated component that was being removed in this PR. I had to start pretty much from scratch thus the request to review and test it again before merging.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
thiagobrez commentedon Jun 30, 2023
I imagine I will be able to start on this next week.
cristipaval commentedon Jun 30, 2023
I forgot to assign you to the issue, @thiagobrez . Sorry for that
cristipaval commentedon Jul 11, 2023
I'll set this one on hold until the second phase is done.
[-]Selection List Refactor: Simple Selection List[/-][+][HOLD App issue #20353] Selection List Refactor: Simple Selection List[/+]thiagobrez commentedon Jul 14, 2023
Starting to investigate this today, while second phase PR is in review
thiagobrez commentedon Jul 14, 2023
Good news, these lists are fitting well with the new components. Group members list is ready
232 remaining items
quinthar commentedon May 12, 2024
Should this be closed? If not, what is the next step, who is doing it, and when?
MrMuzyk commentedon May 13, 2024
@quinthar Hey, so we have a PR that is waiting to be reviewed and tested again. After this is merged then whole refactor is complete and this issue can be closed.
Note: PR has been opened for 3 weeks now but it was hanging due to merge freeze I guess. In the meantime a new feature has been merged (uneven splits) that did some major changes in the refactored component and added a new feature to deprecated component that was being removed in this PR. I had to start pretty much from scratch thus the request to review and test it again before merging.
rushatgabhane commentedon May 13, 2024
yep, it was reviewed 2 weeks ago but then a new feature was added in the deprecated component. Need to re-review now
melvin-bot commentedon May 15, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 15, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 15, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 16, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 16, 2024
This issue has not been updated in over 15 days. @JmillsExpensify, @cristipaval, @rushatgabhane, @lukemorawski eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
JmillsExpensify commentedon May 19, 2024
Can we close this issue out yet?
MrMuzyk commentedon May 20, 2024
Refactor is complete. I'm fine closing it.
laurenreidexpensify commentedon May 31, 2024
Payment Summary:
C+ Review
@rushatgabhane
Total: $4500
Payment Method: Please request in Newdot
Contributor
@lukemorawski Agency contributor, no payment owed
JmillsExpensify commentedon May 31, 2024
$4,5000 approved for @rushatgabhane