Skip to content

[HOLD for payment 2023-07-20] Make secondary-login "Delete" always succeed, even if the login didn't exist before #20701

Closed

Description

@cristipaval

This is a follow-up issue polishing one of the Contact Methods flows. Here is the tracker issue.

Coming from here, we want to change Auth to return success when trying to delete a login that doesn't exist.

cc @Beamanator

Activity

  1. self-assigned this
    on Jun 13, 2023
  2. Beamanator commented on Jun 14, 2023

    @Beamanator
    Contributor

    Agreed!

  3. flodnv commented on Jun 19, 2023

    @flodnv
    Contributor

    we want to change Auth to return success when trying to delete a login that doesn't exist.

    I am not sure I agree with that.

    1. Why is the client trying to delete a login that does not exist?
    2. Even if there's a good reason for (1), why isn't the client gracefully handling an error it triggered?
  4. cristipaval commented on Jun 19, 2023

    @cristipaval
    ContributorAuthor

    Hey @flodnv! Thanks for jumping into this one! Please see this for more context.

  5. flodnv commented on Jun 19, 2023

    @flodnv
    Contributor

    Hmmmkay, it kind of makes the command idempotent, which if we go forward with this change we could mark it as such in Auth.php, which is not a bad thing... besides adding a lot like Scott suggested, my remaining concern is, what's going to happen in this flow for OldDot? For example see this request: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%227d623de2dc163860-LHR%22)+AND+timestamp:[2023-06-12T11:54:19.492Z+TO+2023-06-12T13:54:19.492Z]&index=logs_expensify-022770

  6. cristipaval commented on Jun 20, 2023

    @cristipaval
    ContributorAuthor

    Nothing happens, OldDot acts as if that secondary login existed and deletes it from the front-end 🤷

  7. flodnv commented on Jun 20, 2023

    @flodnv
    Contributor

    Oh, perfect then! 😄

  8. cristipaval commented on Jun 20, 2023

    @cristipaval
    ContributorAuthor

    Oh, perfect then! 😄

    So do you think we can proceed with this solution or do you still think it is an antipattern? 👀

  9. cristipaval commented on Jun 20, 2023

    @cristipaval
    ContributorAuthor

    Ah, sorry, I missed your comment on the PR.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 13, 2023
  11. 10 remaining items

  12. cristipaval commented on Jul 13, 2023

    @cristipaval
    ContributorAuthor

    Added Bug label for the payments

  13. NicMendonca commented on Jul 24, 2023

    @NicMendonca
    Contributor

    @allroundexperts will you request payment via Expensify?

  14. allroundexperts commented on Jul 24, 2023

    @allroundexperts
    Contributor

    @allroundexperts will you request payment via Expensify?

    Sure!

  15. NicMendonca commented on Jul 24, 2023

    @NicMendonca
    Contributor

    in that case, we can close this! @allroundexperts don't forget! 💰

  16. JmillsExpensify commented on Jul 27, 2023

    @JmillsExpensify
    Contributor

    @NicMendonca Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @allroundexperts NewDot payments. More information on this compliance process in Slack.

  17. NicMendonca commented on Jul 30, 2023

    @NicMendonca
    Contributor

    (cc @JmillsExpensify)

  18. JmillsExpensify commented on Jul 31, 2023

    @JmillsExpensify
    Contributor

    Reviewed details for @allroundexperts. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions