You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-20] Make secondary-login "Delete" always succeed, even if the login didn't exist before #20701
@NicMendonca Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @allroundexperts NewDot payments. More information on this compliance process in Slack.
Activity
Beamanator commentedon Jun 14, 2023
Agreed!
flodnv commentedon Jun 19, 2023
I am not sure I agree with that.
cristipaval commentedon Jun 19, 2023
Hey @flodnv! Thanks for jumping into this one! Please see this for more context.
flodnv commentedon Jun 19, 2023
Hmmmkay, it kind of makes the command idempotent, which if we go forward with this change we could mark it as such in
Auth.php, which is not a bad thing... besides adding a lot like Scott suggested, my remaining concern is, what's going to happen in this flow for OldDot? For example see this request: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%227d623de2dc163860-LHR%22)+AND+timestamp:[2023-06-12T11:54:19.492Z+TO+2023-06-12T13:54:19.492Z]&index=logs_expensify-022770cristipaval commentedon Jun 20, 2023
Nothing happens, OldDot acts as if that secondary login existed and deletes it from the front-end 🤷
flodnv commentedon Jun 20, 2023
Oh, perfect then! 😄
cristipaval commentedon Jun 20, 2023
So do you think we can proceed with this solution or do you still think it is an antipattern? 👀
cristipaval commentedon Jun 20, 2023
Ah, sorry, I missed your comment on the PR.
10 remaining items
cristipaval commentedon Jul 13, 2023
Added
Buglabel for the paymentsNicMendonca commentedon Jul 24, 2023
@allroundexperts will you request payment via Expensify?
allroundexperts commentedon Jul 24, 2023
Sure!
NicMendonca commentedon Jul 24, 2023
in that case, we can close this! @allroundexperts don't forget! 💰
JmillsExpensify commentedon Jul 27, 2023
@NicMendonca Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @allroundexperts NewDot payments. More information on this compliance process in Slack.
NicMendonca commentedon Jul 30, 2023
(cc @JmillsExpensify)
JmillsExpensify commentedon Jul 31, 2023
Reviewed details for @allroundexperts. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.